Linter

Author: pbuehler

PWGUD/Core/decayTree.cxx

@@ -195,7 +195,7 @@ void resonance::Print()
     fpidSelector.Print();
   } else {
     LOGF(info, "      Angle cuts");
-    for (const auto anglecut : fangleCuts) {
+    for (const auto& anglecut : fangleCuts) {
       anglecut->Print();
     }
   }
@@ -883,11 +883,11 @@ bool decayTree::init(std::string const& parFile, o2::framework::HistogramRegistr
 void decayTree::updateParents()
 {
   // reset parents
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     res->clearParents();
   }
 
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     for (const auto& daughName : res->getDaughters()) {
       auto daugh = getResonance(daughName);
       daugh->addParent(res->name());
@@ -899,7 +899,7 @@ void decayTree::reset()
 {
   fStatus = 0;
   fChargeState = -1;
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     res->reset();
   }
 }
@@ -914,7 +914,7 @@ void decayTree::updateStatus()
   bool isULS = true;
   bool isLS = true;
   fStatus = 1;
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     if (res->status() < 3) {
       return;
     }
@@ -942,26 +942,26 @@ void decayTree::Print()
   LOGF(info, "  dBCRange: %d : %d", fdBCMin, fdBCMax);
   LOGF(info, "  FITVetoes: [ %d %d %d %d %d ]", fFITvetos[0], fFITvetos[1], fFITvetos[2], fFITvetos[3], fFITvetos[4]);
   LOGF(info, "  ULS states");
-  for (const auto chstat : fULSstates) {
+  for (const auto& chstat : fULSstates) {
     LOGF(info, "    %d", chstat);
   }
   LOGF(info, "  LS states");
-  for (const auto chstat : fLSstates) {
+  for (const auto& chstat : fLSstates) {
     LOGF(info, "    %d", chstat);
   }
   LOGF(info, "");
   LOGF(info, "decayTree");
   LOGF(info, "  nResonances: %d", fResonances.size());
   LOGF(info, "  nFinals: %d", fnFinals);
   LOGF(info, "  Resonances");
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     res->Print();
   }
 }
 
 resonance* decayTree::getResonance(std::string name)
 {
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     if (res->name() == name) {
       return res;
     }
@@ -972,7 +972,7 @@ resonance* decayTree::getResonance(std::string name)
 
 resonance* decayTree::getFinal(int counter)
 {
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     if (res->counter() == counter) {
       return res;
     }
@@ -992,7 +992,7 @@ std::vector<resonance*> decayTree::getFinals(resonance* res)
     } else {
       for (const auto& d2Name : d1->getDaughters()) {
         auto d2 = getResonance(d2Name);
-        for (const auto d3 : getFinals(d2)) {
+        for (const auto& d3 : getFinals(d2)) {
           resFinals.push_back(d3);
         }
       }
@@ -1005,10 +1005,10 @@ std::vector<resonance*> decayTree::getFinals(resonance* res)
 void decayTree::checkAngles()
 {
   // loop over resonances
-  for (const auto res : fResonances) {
+  for (const auto& res : fResonances) {
     auto anglecuts = res->getAngleCuts();
     // loop over angle cuts
-    for (const auto anglecut : anglecuts) {
+    for (const auto& anglecut : anglecuts) {
       auto rnames = anglecut->rNames();
       auto anglerange = anglecut->angleRange();
 

PWGUD/Core/decayTree.h

@@ -83,7 +83,7 @@ class pidSelector
   bool goodTrack(TTs track)
   {
     // loop over pidcuts
-    for (const auto pidcut : fpidCuts) {
+    for (const auto& pidcut : fpidCuts) {
 
       float mom = 0.;
       float detValue = 0.;
@@ -503,9 +503,9 @@ class decayTree
 
     // loop over possible combinations
     LOGF(debug, "New event");
-    for (const auto comb : combs) {
+    for (const auto& comb : combs) {
       std::string scomb("");
-      for (auto i : comb) {
+      for (const auto& i : comb) {
         scomb.append(" ").append(std::to_string(i));
       }
       LOGF(debug, "  combination:%s", scomb);
@@ -519,7 +519,7 @@ class decayTree
 
       // loop over resonances and compute
       reset();
-      for (const auto res : fResonances) {
+      for (const auto& res : fResonances) {
         computeResonance(res, tracks, comb);
       }
 
@@ -531,7 +531,7 @@ class decayTree
       if (fStatus >= 2) {
         goodCombs.push_back(newHash);
         std::map<std::string, reconstructedParticle> recResonances;
-        for (const auto res : fResonances) {
+        for (const auto& res : fResonances) {
           recResonances.insert({res->name(), reconstructedParticle(res->name(), res->IVM(), comb)});
         }
 
@@ -559,7 +559,7 @@ class decayTree
 
     // results["ULS"] contains the ULS results
     // results["LS"] contains the LS results
-    for (const auto cc : fccs) {
+    for (const auto& cc : fccs) {
       // result is a std::vector<std::map<std::string, reconstructedParticle>>
       for (auto result : results[cc]) {
 
@@ -851,7 +851,7 @@ class decayTree
     std::string hname;
     std::string annot;
     fhistPointers.clear();
-    for (const auto res : getResonances()) {
+    for (const auto& res : getResonances()) {
       auto max = AxisSpec(res->nmassBins(), res->massHistRange()[0], res->massHistRange()[1]);
       auto momax = AxisSpec(res->nmomBins(), res->momHistRange()[0], res->momHistRange()[1]);
 

PWGUD/TableProducer/DGCandProducer.cxx

@@ -520,7 +520,7 @@ struct McDGCandProducer {
         // mothers
         newmids.clear();
         auto oldmids = mcpart.mothersIds();
-        for (const auto oldmid : oldmids) {
+        for (const auto& oldmid : oldmids) {
           auto m = McParts.rawIteratorAt(oldmid);
           LOGF(debug, "    m %d", m.globalIndex());
           if (mcPartIsSaved.find(oldmid) != mcPartIsSaved.end()) {