Skip to content

Commit 0434f1b

Browse files
author
Fabien Servant
committed
rename meshIntersection methods
1 parent c842742 commit 0434f1b

File tree

9 files changed

+18
-18
lines changed

9 files changed

+18
-18
lines changed

src/aliceVision/mesh/MeshIntersection.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ bool MeshIntersection::initialize(const std::string & pathToModel)
2828
return true;
2929
}
3030

31-
bool MeshIntersection::peekPoint(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords)
31+
bool MeshIntersection::pickPoint(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords)
3232
{
3333
const Vec3 posCamera = _pose.center();
3434
const Vec3 wdir = intrinsic.backprojectTransform(imageCoords, true, _pose, 1.0);
@@ -58,7 +58,7 @@ bool MeshIntersection::peekPoint(Vec3 & output, const camera::IntrinsicBase & in
5858
return true;
5959
}
6060

61-
bool MeshIntersection::peekNormal(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords)
61+
bool MeshIntersection::pickNormal(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords)
6262
{
6363
const Vec3 posCamera = _pose.center();
6464
const Vec3 wdir = intrinsic.backprojectTransform(imageCoords, true, _pose, 1.0);
@@ -88,7 +88,7 @@ bool MeshIntersection::peekNormal(Vec3 & output, const camera::IntrinsicBase & i
8888
return true;
8989
}
9090

91-
bool MeshIntersection::peekPointAndNormal(Vec3 & point, Vec3 & normal, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords)
91+
bool MeshIntersection::pickPointAndNormal(Vec3 & point, Vec3 & normal, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords)
9292
{
9393
const Vec3 posCamera = _pose.center();
9494
const Vec3 wdir = intrinsic.backprojectTransform(imageCoords, true, _pose, 1.0);

src/aliceVision/mesh/MeshIntersection.hpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class MeshIntersection
2222
bool initialize(const std::string & pathToModel);
2323

2424
/**
25-
* @brief Update pose to use for peeking
25+
* @brief Update pose to use for picking
2626
* @param pose transformation to use (in aliceVision standard form)
2727
*/
2828
void setPose(const geometry::Pose3 & pose)
@@ -31,32 +31,32 @@ class MeshIntersection
3131
}
3232

3333
/**
34-
* @brief peek a point on the mesh given a input camera observation
34+
* @brief pick a point on the mesh given a input camera observation
3535
* @param output the output measured point
3636
* @param intrinsic the camera intrinsics to use for ray computation
3737
* @param imageCoords the camera observation we want to use to estimate its 'depth'
3838
* @return true if the ray intersect the mesh.
3939
*/
40-
bool peekPoint(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);
40+
bool pickPoint(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);
4141

4242
/**
43-
* @brief peek a point and get its normal on the mesh given a input camera observation
43+
* @brief pick a point and get its normal on the mesh given a input camera observation
4444
* @param output the output measured normal
4545
* @param intrinsic the camera intrinsics to use for ray computation
4646
* @param imageCoords the camera observation we want to use to estimate its 'depth'
4747
* @return true if the ray intersect the mesh.
4848
*/
49-
bool peekNormal(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);
49+
bool pickNormal(Vec3 & output, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);
5050

5151
/**
52-
* @brief peek a point and get its normal on the mesh given a input camera observation
52+
* @brief pick a point and get its normal on the mesh given a input camera observation
5353
* @param point the output measured point
5454
* @param normal the output measured normal
5555
* @param intrinsic the camera intrinsics to use for ray computation
5656
* @param imageCoords the camera observation we want to use to estimate its 'depth'
5757
* @return true if the ray intersect the mesh.
5858
*/
59-
bool peekPointAndNormal(Vec3 & point, Vec3 & normal, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);
59+
bool pickPointAndNormal(Vec3 & point, Vec3 & normal, const camera::IntrinsicBase & intrinsic, const Vec2 & imageCoords);
6060

6161
private:
6262
GEO::Mesh _mesh;

src/aliceVision/sfm/pipeline/expanding/ExpansionChunk.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ void ExpansionChunk::setConstraints(sfmData::SfMData & sfmData, const track::Tra
234234
}
235235

236236
Vec3 point, normal;
237-
if (!_pointFetcherHandler->peekPointAndNormal(point, normal, intrinsics, trackItem.coords))
237+
if (!_pointFetcherHandler->pickPointAndNormal(point, normal, intrinsics, trackItem.coords))
238238
{
239239
continue;
240240
}

src/aliceVision/sfm/pipeline/expanding/PointFetcher.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class PointFetcher
3535
* @param imageCoords the input image pixel coordinates in 2D.
3636
* @return false on error
3737
*/
38-
virtual bool peekPointAndNormal(Vec3 & point,
38+
virtual bool pickPointAndNormal(Vec3 & point,
3939
Vec3 & normal,
4040
const camera::IntrinsicBase & intrinsic,
4141
const Vec2 & imageCoords) = 0;

src/software/pipeline/main_sfmBootstraping.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ bool landmarksFromMesh(
8787
const double scale = track.featPerView.at(referenceViewId).scale;
8888

8989
Vec3 point;
90-
if (!mi.peekPoint(point, intrinsic, refpt))
90+
if (!mi.pickPoint(point, intrinsic, refpt))
9191
{
9292
continue;
9393
}

src/software/pipeline/main_sfmExpanding.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ class MeshPointFetcher : public sfm::PointFetcher
6565
* @param imageCoords the input image pixel coordinates in 2D.
6666
* @return false on error
6767
*/
68-
bool peekPointAndNormal(Vec3 & point,
68+
bool pickPointAndNormal(Vec3 & point,
6969
Vec3 & normal,
7070
const camera::IntrinsicBase & intrinsic,
7171
const Vec2 & imageCoords) override
7272
{
73-
return _mi.peekPointAndNormal(point, normal, intrinsic, imageCoords);
73+
return _mi.pickPointAndNormal(point, normal, intrinsic, imageCoords);
7474
}
7575

7676
private:

src/software/utils/main_depthMapRendering.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ int aliceVision_main(int argc, char** argv)
117117
//Find the 3d point
118118
//Which is the intersection of the ray and the mesh
119119
Vec3 pt3d;
120-
if (!mi.peekPoint(pt3d, *intrinsic, pt))
120+
if (!mi.pickPoint(pt3d, *intrinsic, pt))
121121
{
122122
continue;
123123
}

src/software/utils/main_normalMapRendering.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ int aliceVision_main(int argc, char** argv)
109109
//Which is the intersection of the ray and the mesh
110110
//And get its normal
111111
Vec3 normal;
112-
if (!mi.peekNormal(normal, *intrinsic, pt))
112+
if (!mi.pickNormal(normal, *intrinsic, pt))
113113
{
114114
continue;
115115
}

src/software/utils/main_sfmTransform.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ bool parseLineUp(const std::string & lineUpFilename, const std::string & tracksF
409409
const Vec2 & imageCoords = trackitem.coords;
410410

411411
Vec3 pt3d;
412-
if (!meshIntersection.peekPoint(pt3d, *intrinsic, imageCoords))
412+
if (!meshIntersection.pickPoint(pt3d, *intrinsic, imageCoords))
413413
{
414414
continue;
415415
}

0 commit comments

Comments
 (0)