Skip to content

Commit ac78b3e

Browse files
author
Fabien Servant
committed
Typos removal
1 parent 5cf45cc commit ac78b3e

File tree

5 files changed

+14
-20
lines changed

5 files changed

+14
-20
lines changed

src/aliceVision/camera/Pinhole.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -169,12 +169,6 @@ Eigen::Matrix<double, 3, Eigen::Dynamic> Pinhole::getDerivativeBackProjectUnitWr
169169
J.block<3, 2>(0, 0) = getDerivativetoUnitSphereWrtPoint(ptUndist) * getDerivativeRemoveDistoWrtPt(ptMeters) * getDerivativeIma2CamWrtScale(pt2D);
170170
J.block<3, 2>(0, 2) = getDerivativetoUnitSphereWrtPoint(ptUndist) * getDerivativeRemoveDistoWrtPt(ptMeters) * getDerivativeIma2CamWrtPrincipalPoint();
171171

172-
/*if (disto_size > 0)
173-
{
174-
J.block(0, 4, 3, disto_size) = getDerivativetoUnitSphereWrtPoint(ptUndist) * getDerivativeRemoveDistoWrtDisto(ptMeters);
175-
}*/
176-
177-
178172
return J;
179173
}
180174

src/aliceVision/localization/optimization.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -301,11 +301,11 @@ bool refineSequence(std::vector<LocalizationResult>& vec_localizationResult,
301301
// update the intrinsics of each localization result
302302

303303
auto intrinsic = tinyScene.getIntrinsics().at(0);
304-
auto casted = camera::IntrinsicScaleOffsetDisto::cast(intrinsic);
304+
auto isod = camera::IntrinsicScaleOffsetDisto::cast(intrinsic);
305305
std::shared_ptr<camera::Distortion> distortion;
306-
if (casted)
306+
if (isod)
307307
{
308-
distortion = casted->getDistortion();
308+
distortion = isod->getDistortion();
309309
}
310310

311311
// get its optimized parameters
@@ -324,10 +324,10 @@ bool refineSequence(std::vector<LocalizationResult>& vec_localizationResult,
324324
}
325325
currResult.updateIntrinsics(params);
326326

327-
auto curDistortion = currResult.getIntrinsics().getDistortion();
328-
if (distortion && curDistortion)
327+
auto currDistortion = currResult.getIntrinsics().getDistortion();
328+
if (distortion && currDistortion)
329329
{
330-
curDistortion->setParameters(distortion->getParameters());
330+
currDistortion->setParameters(distortion->getParameters());
331331
}
332332

333333

src/aliceVision/sfm/bundle/BundleAdjustmentCeres.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1021,7 +1021,7 @@ bool BundleAdjustmentCeres::adjust(sfmData::SfMData& sfmData, ERefineOptions ref
10211021
ceres::Solve(options, &problem, &summary);
10221022

10231023
// print summary
1024-
//if (_ceresOptions.summary)
1024+
if (_ceresOptions.summary)
10251025
ALICEVISION_LOG_INFO(summary.FullReport());
10261026

10271027
// solution is not usable

src/aliceVision/sfm/bundle/costfunctions/intrinsicsProject.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,19 @@ class CostIntrinsicsProject : public ceres::CostFunction
2121
{
2222
set_num_residuals(2);
2323

24-
size_t size_disto = 1;
24+
size_t sizeDisto = 1;
2525
auto isod = camera::IntrinsicScaleOffsetDisto::cast(intrinsics);
2626
if (isod)
2727
{
2828
_distortion = isod->getDistortion();
2929
if (_distortion)
3030
{
31-
size_disto = _distortion->getParameters().size();
31+
sizeDisto = _distortion->getParameters().size();
3232
}
3333
}
3434

3535
mutable_parameter_block_sizes()->push_back(intrinsics->getParametersSize());
36-
mutable_parameter_block_sizes()->push_back(size_disto);
36+
mutable_parameter_block_sizes()->push_back(sizeDisto);
3737
mutable_parameter_block_sizes()->push_back(3);
3838
}
3939

src/software/utils/main_imageProcessing.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1431,14 +1431,14 @@ int aliceVision_main(int argc, char* argv[])
14311431

14321432
if (pParams.par.enabled)
14331433
{
1434-
auto casted = camera::IntrinsicScaleOffset::cast(cam);
1435-
if (casted)
1434+
auto iso = camera::IntrinsicScaleOffset::cast(cam);
1435+
if (iso)
14361436
{
1437-
pParams.par.value = casted->getScale().y() / casted->getScale().x();
1437+
pParams.par.value = iso->getScale().y() / iso->getScale().x();
14381438
}
14391439
}
14401440

1441-
// Image processSing
1441+
// Image processing
14421442
processImage(image, pParams, viewMetadata, cam);
14431443

14441444
if (pParams.applyDcpMetadata)

0 commit comments

Comments
 (0)