FIX: Explicitly set MSVC runtime library versions

This commit adapts the project to the new handling of CMP0091:

    (1) Explicitly sets the msvcrt flags based on the current configuration (Debug, Non-Debug; Static or Shared Libraries)
    (2) Explicitly sets the appropriate nvcc "--compiler-flags" to pass through the current msvcrt configuration when compiling CUDA code

Fixes linker errors if compiling CUDA code with MSVC as host compiler when cmake_minimum_required() is > 3.15. Unifies MSVC runtime library selection throughout the project.

Signed-off-by: Philipp Remy <[email protected]>

Author: philippremy

src/CMakeLists.txt

@@ -136,6 +136,13 @@ if (WIN32)
     add_definitions(-DNOMINMAX)
     add_definitions(-D_USE_MATH_DEFINES)
     if (MSVC)
+        # MSVC library version
+        cmake_policy(SET CMP0091 NEW)   # Manually choose msvcrt version
+        if(BUILD_SHARED_LIBS)
+            set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
+        else()
+            set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
+        endif()
         add_compile_options(/bigobj)
         add_compile_options(/MP)
     endif()

src/cmake/Helpers.cmake

@@ -40,9 +40,27 @@ function(alicevision_add_library library_name)
         endif()
 
     elseif (BUILD_SHARED_LIBS)
-        cuda_add_library(${library_name} SHARED ${LIBRARY_SOURCES} OPTIONS --compiler-options "-fPIC")
+        if(MSVC)
+            if(CMAKE_BUILD_TYPE MATCHES "Debug")
+                set(CUDA_LIB_OPTIONS --compiler-options "/MDd")
+            else()
+                set(CUDA_LIB_OPTIONS --compiler-options "/MD")
+            endif()
+        else()
+            set(CUDA_LIB_OPTIONS --compiler-options "-fPIC")
+        endif()
+        cuda_add_library(${library_name} SHARED ${LIBRARY_SOURCES} OPTIONS ${CUDA_LIB_OPTIONS})
     else()
-        cuda_add_library(${library_name} ${LIBRARY_SOURCES})
+        if(MSVC)
+            if(CMAKE_BUILD_TYPE MATCHES "Debug")
+                set(CUDA_LIB_OPTIONS --compiler-options "/MTd")
+            else()
+                set(CUDA_LIB_OPTIONS --compiler-options "/MT")
+            endif()
+        else()
+            set(CUDA_LIB_OPTIONS --compiler-options "-fPIC")
+        endif()
+        cuda_add_library(${library_name} ${LIBRARY_SOURCES} OPTIONS ${CUDA_LIB_OPTIONS})
     endif()
 
     if (ALICEVISION_REMOVE_ABSOLUTE)