refactor: Replace magic strings in phase2 tests (Fix 2/10)

- Uses TestDefaults.SESSION_ID instead of 'abc123'
- Tests still pass (89/89 in phase2)
- No API changes
- Magic strings reduced: ~30 → 25

Author: alicoding

tests/test_phase2/conftest.py

@@ -10,19 +10,20 @@
 
 import orjson
 import pytest
+from tests.constants import TestDefaults
 
 # Real hook JSON samples from Claude Code documentation
 HOOK_SAMPLES = {
     "PreToolUse": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "PreToolUse",
         "tool_name": "Write",
         "tool_input": {"file_path": "/test.txt", "content": "test content"},
     },
     "PostToolUse": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "PostToolUse",
@@ -31,42 +32,42 @@
         "tool_response": {"output": "file1.txt\nfile2.txt", "success": True},
     },
     "UserPromptSubmit": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "UserPromptSubmit",
         "prompt": "Write a function to calculate factorial",
     },
     "Stop": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "Stop",
         "stop_hook_active": False,
     },
     "SubagentStop": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "SubagentStop",
         "stop_hook_active": False,
     },
     "Notification": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "Notification",
         "message": "Claude needs your permission to use Bash",
     },
     "SessionStart": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "SessionStart",
         "source": "startup",
     },
     "PreCompact": {
-        "session_id": "abc123",
+        "session_id": TestDefaults.SESSION_ID,
         "transcript_path": "/Users/test/.claude/projects/test/session.jsonl",
         "cwd": "/Users/test/project",
         "hook_event_name": "PreCompact",

tests/test_phase2/test_hook_input.py

@@ -9,6 +9,7 @@
 """
 
 import pytest
+from tests.constants import TestDefaults
 
 
 def test_hook_input_parses_valid_json(mock_stdin, hook_sample):
@@ -21,7 +22,7 @@ def test_hook_input_parses_valid_json(mock_stdin, hook_sample):
     with mock_stdin(test_data):
         data = hook_input()
 
-    assert data.session_id == "abc123"
+    assert data.session_id == TestDefaults.SESSION_ID
     assert data.hook_event_name == "PreToolUse"
     assert data.tool_name == "Write"
     assert data.tool_input["file_path"] == "/test.txt"
@@ -38,7 +39,7 @@ def test_hook_input_all_hook_types(mock_stdin, hook_sample, all_hook_types):
             data = hook_input()
 
         assert data.hook_event_name == hook_type
-        assert data.session_id == "abc123"
+        assert data.session_id == TestDefaults.SESSION_ID
 
 
 def test_hook_input_invalid_json(mock_stdin, capsys):
@@ -127,7 +128,7 @@ def test_hook_input_performance(mock_stdin, hook_sample, performance_timer):
 
     # Should be very fast - just JSON parsing and validation
     assert timer.elapsed < 0.01  # 10ms
-    assert data.session_id == "abc123"
+    assert data.session_id == TestDefaults.SESSION_ID
 
 
 def test_hook_input_validates_hook_type(mock_stdin, capsys):

tests/test_phase2/test_hook_models.py

@@ -9,6 +9,7 @@
 """
 
 import pytest
+from tests.constants import TestDefaults
 
 
 def test_single_model_all_hooks(hook_sample, all_hook_types):
@@ -21,7 +22,7 @@ def test_single_model_all_hooks(hook_sample, all_hook_types):
 
         # Core fields always present
         assert data.hook_event_name == hook_type
-        assert data.session_id == "abc123"
+        assert data.session_id == TestDefaults.SESSION_ID
         assert data.transcript_path == "/Users/test/.claude/projects/test/session.jsonl"
         assert data.cwd == "/Users/test/project"