Skip to content

Commit 269ede8

Browse files
committed
Workarround concurrent modification issue
1 parent 44fffb8 commit 269ede8

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

elasticsearch-annotations/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>org.alien4cloud</groupId>
66
<artifactId>elasticsearch-mapping-parent</artifactId>
7-
<version>1.7.6-SNAPSHOT</version>
7+
<version>1.7.6</version>
88
</parent>
99

1010
<artifactId>elasticsearch-annotations</artifactId>
@@ -18,4 +18,4 @@
1818
<artifactId>elasticsearch</artifactId>
1919
</dependency>
2020
</dependencies>
21-
</project>
21+
</project>

elasticsearch-mapping/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>org.alien4cloud</groupId>
66
<artifactId>elasticsearch-mapping-parent</artifactId>
7-
<version>1.7.6-SNAPSHOT</version>
7+
<version>1.7.6</version>
88
</parent>
99

1010
<artifactId>elasticsearch-mapping</artifactId>
@@ -41,4 +41,4 @@
4141
<scope>test</scope>
4242
</dependency>
4343
</dependencies>
44-
</project>
44+
</project>

elasticsearch-mapping/src/main/java/org/elasticsearch/mapping/QueryHelper.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,10 @@ private List<AggregationBuilder> buildAggregations(String className, Set<String>
592592
return aggregationBuilders;
593593
}
594594

595-
for (IFacetBuilderHelper facetBuilderHelper : facetBuilderHelpers) {
595+
// FIXME: concurrent modifications here, to instruct
596+
IFacetBuilderHelper[] IFacetBuilderHelpers = new IFacetBuilderHelper[facetBuilderHelpers.size()];
597+
facetBuilderHelpers.toArray(IFacetBuilderHelpers);
598+
for (IFacetBuilderHelper facetBuilderHelper : IFacetBuilderHelpers) {
596599
if (filters == null || !filters.contains(facetBuilderHelper.getEsFieldName())) {
597600
aggregationBuilders.addAll(facetBuilderHelper.buildFacets());
598601
}

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>org.alien4cloud</groupId>
55
<artifactId>elasticsearch-mapping-parent</artifactId>
6-
<version>1.7.6-SNAPSHOT</version>
6+
<version>1.7.6</version>
77
<packaging>pom</packaging>
88

99
<name>Elastic search mapping parent</name>

0 commit comments

Comments
 (0)