Allow customization of VisitorCollection IVisitors; Add a UriTypeVisitor (#104)

Author: gsteencg

src/Aliencube.AzureFunctions.Extensions.OpenApi.CLI/Program.cs

@@ -84,7 +84,7 @@ public void Generate(
             var filter = new RouteConstraintFilter();
             var acceptor = new OpenApiSchemaAcceptor();
             var namingStrategy = new CamelCaseNamingStrategy();
-            var collection = this.GetVisitorCollection();
+            var collection = VisitorCollection.CreateInstance();
             var helper = new DocumentHelper(filter, acceptor);
             var document = new Document(helper);
 
@@ -136,17 +136,5 @@ public void Generate(
 
             File.WriteAllText($"{outputpath}{directorySeparator}swagger.{format.ToDisplayName()}", swagger, Encoding.UTF8);
         }
-
-        private VisitorCollection GetVisitorCollection()
-        {
-            var visitors = typeof(IVisitor).Assembly
-                                           .GetTypes()
-                                           .Where(p => p.Name.EndsWith("Visitor") && p.IsClass && !p.IsAbstract)
-                                           .Select(p => (IVisitor)Activator.CreateInstance(p))
-                                           .ToList();
-            var collection = new VisitorCollection(visitors);
-
-            return collection;
-        }
     }
 }

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/BooleanTypeVisitor.cs

@@ -14,6 +14,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class BooleanTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public BooleanTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/DateTimeObjectTypeVisitor.cs

@@ -14,6 +14,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class DateTimeObjectTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public DateTimeObjectTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/DateTimeOffsetObjectTypeVisitor.cs

@@ -14,6 +14,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class DateTimeOffsetObjectTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public DateTimeOffsetObjectTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/DateTimeTypeVisitor.cs

@@ -14,6 +14,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class DateTimeTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public DateTimeTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/DecimalTypeVisitor.cs

@@ -14,6 +14,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class DecimalTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public DecimalTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/DictionaryObjectTypeVisitor.cs

@@ -16,6 +16,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class DictionaryObjectTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public DictionaryObjectTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {
@@ -55,8 +61,7 @@ public override void Visit(IAcceptor acceptor, KeyValuePair<string, Type> type,
                 Schemas = schemas,
             };
 
-            var collection = VisitorCollection.CreateInstance();
-            subAcceptor.Accept(collection, namingStrategy);
+            subAcceptor.Accept(this.VisitorCollection, namingStrategy);
 
             var properties = subAcceptor.Schemas.First().Value;
 
@@ -120,8 +125,7 @@ public override OpenApiSchema PayloadVisit(Type type, NamingStrategy namingStrat
 
             // Gets the schema for the underlying type.
             var underlyingType = type.GetGenericArguments()[1];
-            var collection = VisitorCollection.CreateInstance();
-            var properties = collection.PayloadVisit(underlyingType, namingStrategy);
+            var properties = this.VisitorCollection.PayloadVisit(underlyingType, namingStrategy);
 
             // Adds the reference to the schema for the underlying type.
             var reference = new OpenApiReference()

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/DoubleTypeVisitor.cs

@@ -14,6 +14,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class DoubleTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public DoubleTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/GuidObjectTypeVisitor.cs

@@ -14,6 +14,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class GuidObjectTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public GuidObjectTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Visitors/Int16EnumTypeVisitor.cs

@@ -19,6 +19,12 @@ namespace Aliencube.AzureFunctions.Extensions.OpenApi.Core.Visitors
     /// </summary>
     public class Int16EnumTypeVisitor : TypeVisitor
     {
+        /// <inheritdoc />
+        public Int16EnumTypeVisitor(VisitorCollection visitorCollection)
+            : base(visitorCollection)
+        {
+        }
+
         /// <inheritdoc />
         public override bool IsVisitable(Type type)
         {