DO-1802: Fix changeset publishing by switching to in-place builds

TheOrangePuff · TheOrangePuff · commit 8e92c7fdce51 · 2025-08-08T12:00:36.000+09:30
- Change TypeScript compilation to build in-place within packages/ instead of separate dist/ folder
- Update all tsconfig.app.json files to use outDir: "." and rootDir: "."
- Update all Nx project.json build targets to use direct tsc compilation
- Add .gitignore files to exclude compiled JS/d.ts files from version control
- Add .npmignore files to exclude TypeScript source files from published packages
- Update root .gitignore to globally exclude compiled artifacts

This fixes the issue where changeset was publishing raw TypeScript source files
instead of compiled JavaScript, which happened because changeset doesn't support
building to separate dist directories. Version 2.13.0 of prerender-fargate was
broken because it contained .ts files instead of .js files.

The new workflow:
- Development: Work with TypeScript source files (tracked in git)
- Build: Compile TypeScript in-place within packages/
- Publish: Changeset publishes compiled JS (source excluded by .npmignore)
- Git: Compiled files excluded from version control
diff --git a/.gitignore b/.gitignore
@@ -7,6 +7,15 @@
 node_modules/
 dist/
 
+# Compiled JavaScript files in packages (built in-place)
+packages/**/*.js
+packages/**/*.d.ts
+packages/**/*.js.map
+
+# But keep specific files that should be tracked
+!packages/**/lib/handlers/**/*.js
+!packages/**/lib/prerender/**/*.js
+
 # Yarn (https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored)
 .yarn/*
 !.yarn/cache
diff --git a/packages/basic-auth/project.json b/packages/basic-auth/project.json
@@ -5,15 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/basic-auth/index.ts",
-        "outputPath": "dist/basic-auth",
-        "tsConfig": "packages/basic-auth/tsconfig.app.json",
-        "assets": [
-          "packages/basic-auth/lib/handlers/**",
-          "packages/basic-auth/README.md"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/basic-auth"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -30,7 +25,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs basic-auth {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/basic-auth"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/basic-auth/tsconfig.app.json b/packages/basic-auth/tsconfig.app.json
@@ -1,10 +1,11 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
-  "exclude": ["./jest.config.ts", "lib/handlers"],
+  "exclude": ["./jest.config.ts", "lib/handlers", "**/*.test.ts", "**/*.spec.ts"],
   "include": ["lib/**/*.ts", "index.ts"]
 }
diff --git a/packages/cloudfront-security-headers/project.json b/packages/cloudfront-security-headers/project.json
@@ -5,15 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/cloudfront-security-headers/index.ts",
-        "outputPath": "dist/cloudfront-security-headers",
-        "tsConfig": "packages/cloudfront-security-headers/tsconfig.app.json",
-        "assets": [
-          "packages/cloudfront-security-headers/lib/handlers/**",
-          "packages/cloudfront-security-headers/README.md"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/cloudfront-security-headers"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -30,7 +25,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs cloudfront-security-headers {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/cloudfront-security-headers"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/cloudfront-security-headers/tsconfig.app.json b/packages/cloudfront-security-headers/tsconfig.app.json
@@ -1,7 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
diff --git a/packages/esbuild/project.json b/packages/esbuild/project.json
@@ -5,14 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/esbuild/index.ts",
-        "outputPath": "dist/esbuild",
-        "tsConfig": "packages/esbuild/tsconfig.app.json",
-        "assets": ["packages/esbuild/README.md"]
-      },
-      "dependsOn": ["merge-gitignore"]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/esbuild"
     },
     "lint": {
       "executor": "@nx/eslint:lint",
@@ -27,7 +23,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs esbuild {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/esbuild"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/esbuild/tsconfig.app.json b/packages/esbuild/tsconfig.app.json
@@ -1,7 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
diff --git a/packages/feature-env-handlers/project.json b/packages/feature-env-handlers/project.json
@@ -5,15 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/feature-env-handlers/index.ts",
-        "outputPath": "dist/feature-env-handlers",
-        "tsConfig": "packages/feature-env-handlers/tsconfig.app.json",
-        "assets": [
-          "packages/feature-env-handlers/README.md",
-          "packages/feature-env-handlers/docs/**"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/feature-env-handlers"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -30,7 +25,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs feature-env-handlers {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/feature-env-handlers"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/feature-env-handlers/tsconfig.app.json b/packages/feature-env-handlers/tsconfig.app.json
@@ -1,7 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
diff --git a/packages/geoip-redirect/project.json b/packages/geoip-redirect/project.json
@@ -5,15 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/geoip-redirect/index.ts",
-        "outputPath": "dist/geoip-redirect",
-        "tsConfig": "packages/geoip-redirect/tsconfig.app.json",
-        "assets": [
-          "packages/geoip-redirect/lib/handlers/**",
-          "packages/geoip-redirect/README.md"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/geoip-redirect"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -30,7 +25,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs geoip-redirect {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/geoip-redirect"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/geoip-redirect/tsconfig.app.json b/packages/geoip-redirect/tsconfig.app.json
@@ -1,7 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
diff --git a/packages/graphql-mesh-server/project.json b/packages/graphql-mesh-server/project.json
@@ -5,16 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/graphql-mesh-server/index.ts",
-        "outputPath": "dist/graphql-mesh-server",
-        "tsConfig": "packages/graphql-mesh-server/tsconfig.app.json",
-        "assets": [
-          "packages/graphql-mesh-server/assets/**",
-          "packages/graphql-mesh-server/README.md",
-          "packages/graphql-mesh-server/docs/**"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/graphql-mesh-server"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -31,7 +25,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs graphql-mesh-server {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/graphql-mesh-server"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/graphql-mesh-server/tsconfig.app.json b/packages/graphql-mesh-server/tsconfig.app.json
@@ -1,7 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
diff --git a/packages/header-change-detection/project.json b/packages/header-change-detection/project.json
@@ -5,16 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/header-change-detection/index.ts",
-        "outputPath": "dist/header-change-detection",
-        "tsConfig": "packages/header-change-detection/tsconfig.app.json",
-        "assets": [
-          "packages/header-change-detection/lib/lambda/**",
-          "packages/header-change-detection/README.md",
-          "packages/header-change-detection/docs/**"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/header-change-detection"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -31,7 +25,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs header-change-detection {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/header-change-detection"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/header-change-detection/tsconfig.app.json b/packages/header-change-detection/tsconfig.app.json
@@ -1,7 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
diff --git a/packages/prerender-fargate/project.json b/packages/prerender-fargate/project.json
@@ -5,16 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/prerender-fargate/index.ts",
-        "outputPath": "dist/prerender-fargate",
-        "tsConfig": "packages/prerender-fargate/tsconfig.app.json",
-        "assets": [
-          "packages/prerender-fargate/lib/prerender/**",
-          "packages/prerender-fargate/README.md",
-          "packages/prerender-fargate/docs/**"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/prerender-fargate"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -31,7 +25,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs prerender-fargate {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/prerender-fargate"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/prerender-fargate/tsconfig.app.json b/packages/prerender-fargate/tsconfig.app.json
@@ -1,10 +1,11 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
+    "outDir": ".",
+    "rootDir": ".",
     "module": "commonjs",
     "types": ["node"]
   },
-  "exclude": ["./jest.config.ts"],
+  "exclude": ["./jest.config.ts", "**/*.test.ts", "**/*.spec.ts"],
   "include": ["lib/**/*.ts", "index.ts"]
 }
diff --git a/packages/prerender-proxy/project.json b/packages/prerender-proxy/project.json
@@ -5,15 +5,10 @@
   "projectType": "application",
   "targets": {
     "build": {
-      "executor": "@nx/js:tsc",
+      "executor": "nx:run-commands",
       "options": {
-        "main": "packages/prerender-proxy/index.ts",
-        "outputPath": "dist/prerender-proxy",
-        "tsConfig": "packages/prerender-proxy/tsconfig.app.json",
-        "assets": [
-          "packages/prerender-proxy/lib/handlers/**",
-          "packages/prerender-proxy/README.md"
-        ]
+        "command": "tsc --project tsconfig.app.json",
+        "cwd": "packages/prerender-proxy"
       },
       "dependsOn": ["merge-gitignore"]
     },
@@ -33,7 +28,11 @@
       }
     },
     "publish": {
-      "command": "node tools/scripts/publish.mjs prerender-proxy {args.ver} {args.tag}",
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm publish --access public",
+        "cwd": "packages/prerender-proxy"
+      },
       "dependsOn": ["build"]
     },
     "merge-gitignore": {
diff --git a/packages/prerender-proxy/tsconfig.app.json b/packages/prerender-proxy/tsconfig.app.json
diff --git a/packages/rabbitmq/project.json b/packages/rabbitmq/project.json
diff --git a/packages/rabbitmq/tsconfig.app.json b/packages/rabbitmq/tsconfig.app.json
diff --git a/packages/shared-vpc/project.json b/packages/shared-vpc/project.json
diff --git a/packages/shared-vpc/tsconfig.app.json b/packages/shared-vpc/tsconfig.app.json
diff --git a/packages/static-hosting/project.json b/packages/static-hosting/project.json
diff --git a/packages/static-hosting/tsconfig.app.json b/packages/static-hosting/tsconfig.app.json
diff --git a/packages/waf/project.json b/packages/waf/project.json
diff --git a/packages/waf/tsconfig.app.json b/packages/waf/tsconfig.app.json

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,11 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "./tsconfig.json",`
`3`	`3`	`"compilerOptions": {`
`4`		`- "outDir": "../../dist/out-tsc",`
	`4`	`+ "outDir": ".",`
	`5`	`+ "rootDir": ".",`
`5`	`6`	`"module": "commonjs",`
`6`	`7`	`"types": ["node"]`
`7`	`8`	`},`
`8`		`- "exclude": ["./jest.config.ts", "lib/handlers"],`
	`9`	`+ "exclude": ["./jest.config.ts", "lib/handlers", "*/.test.ts", "*/.spec.ts"],`
`9`	`10`	`"include": ["lib/*/.ts", "index.ts"]`
`10`	`11`	`}`