feat(backend): improve logging and error handling in request and database operations

- Enhance request logging middleware to include response time and error details.
- Add logging for the list_roadmaps function to track pagination and item retrieval.
- Implement error handling in the database connection function to log database errors and ensure rollback on exceptions.

Author: alimkhann

commitly-backend/app/api/roadmap.py

@@ -56,29 +56,37 @@ async def list_roadmaps(
     service: RoadmapService = Depends(get_roadmap_service),
 ) -> CatalogPage:
     """List catalog with filters, sorting, and pagination."""
+    import logging
     import math
 
-    items, total_count = await service.list_catalog(
-        page=page,
-        page_size=page_size,
-        language=language,
-        tag=tag,
-        difficulty=difficulty,
-        min_rating=min_rating,
-        min_views=min_views,
-        min_syncs=min_syncs,
-        sort=sort,
-    )
+    logger = logging.getLogger(__name__)
+    try:
+        logger.info(f"list_roadmaps: Starting with page={page}, page_size={page_size}")
+        items, total_count = await service.list_catalog(
+            page=page,
+            page_size=page_size,
+            language=language,
+            tag=tag,
+            difficulty=difficulty,
+            min_rating=min_rating,
+            min_views=min_views,
+            min_syncs=min_syncs,
+            sort=sort,
+        )
+        logger.info(f"list_roadmaps: Retrieved {len(items)} items, total={total_count}")
 
-    total_pages = math.ceil(total_count / page_size) if total_count > 0 else 0
+        total_pages = math.ceil(total_count / page_size) if total_count > 0 else 0
 
-    return CatalogPage(
-        items=items,
-        page=page,
-        page_size=page_size,
-        total_count=total_count,
-        total_pages=total_pages,
-    )
+        return CatalogPage(
+            items=items,
+            page=page,
+            page_size=page_size,
+            total_count=total_count,
+            total_pages=total_pages,
+        )
+    except Exception as e:
+        logger.error(f"list_roadmaps: Error - {type(e).__name__}: {e}", exc_info=True)
+        raise
 
 
 @router.get("/cached/{owner}/{repo}", response_model=RoadmapResponse)

commitly-backend/app/core/database.py

@@ -37,5 +37,9 @@ def get_db() -> Generator:
     db = SessionLocal()
     try:
         yield db
+    except Exception as e:
+        logger.error(f"Database error in get_db: {e}", exc_info=True)
+        db.rollback()
+        raise
     finally:
         db.close()

commitly-backend/app/main.py

@@ -94,20 +94,25 @@ class RequestLoggingMiddleware(BaseHTTPMiddleware):
     """Log all incoming requests for debugging."""
 
     async def dispatch(self, request: Request, call_next):
+        import time
+        start_time = time.time()
         logger.info(
             f"Request: {request.method} {request.url.path} "
             f"from {request.client.host if request.client else 'unknown'}"
         )
         try:
             response = await call_next(request)
+            elapsed = time.time() - start_time
             logger.info(
                 f"Response: {request.method} {request.url.path} "
-                f"-> {response.status_code}"
+                f"-> {response.status_code} ({elapsed:.3f}s)"
             )
             return response
         except Exception as e:
+            elapsed = time.time() - start_time
             logger.error(
-                f"Error processing {request.method} {request.url.path}: {e}",
+                f"Error processing {request.method} {request.url.path} "
+                f"after {elapsed:.3f}s: {type(e).__name__}: {e}",
                 exc_info=True,
             )
             raise