fix: update tests to use list_catalog with filter parameters

Author: alimkhann

commitly-backend/tests/test_roadmap.py

@@ -69,14 +69,19 @@ async def get_cached(self, repo_full_name: str):
         async def list_synced(self):
             return [roadmap_payload]
 
-        async def list_catalog(self, page: int, page_size: int, sort: str = "newest"):
-            return {
-                "items": [roadmap_payload],
-                "page": page,
-                "page_size": page_size,
-                "total_count": 1,
-                "total_pages": 1,
-            }
+        async def list_catalog(
+            self,
+            page: int = 1,
+            page_size: int = 20,
+            language: str | None = None,
+            tag: str | None = None,
+            difficulty: str | None = None,
+            min_rating: float | None = None,
+            min_views: int | None = None,
+            min_syncs: int | None = None,
+            sort: str = "newest",
+        ):
+            return [roadmap_payload], 1
 
         async def list_user_pins(self, user_id: str):
             assert user_id == "user_123"

commitly-backend/tests/test_roadmap_views.py

@@ -357,7 +357,7 @@ def test_sort_by_newest(self, result_store, mock_session, mock_roadmaps):
         )
         mock_session.query.return_value = mock_query
 
-        items, total = result_store.list_paginated(1, 10, "newest")
+        items, total = result_store.list_catalog(1, 10, sort="newest")
 
         # Verify order_by was called with updated_at.desc()
         assert total == 3
@@ -372,7 +372,7 @@ def test_sort_by_most_viewed(self, result_store, mock_session, mock_roadmaps):
         )
         mock_session.query.return_value = mock_query
 
-        items, total = result_store.list_paginated(1, 10, "most_viewed")
+        items, total = result_store.list_catalog(1, 10, sort="most_viewed")
 
         # Verify order_by was called
         assert total == 3
@@ -387,7 +387,7 @@ def test_sort_by_most_synced(self, result_store, mock_session, mock_roadmaps):
         )
         mock_session.query.return_value = mock_query
 
-        items, total = result_store.list_paginated(1, 10, "most_synced")
+        items, total = result_store.list_catalog(1, 10, sort="most_synced")
 
         assert total == 3
 
@@ -401,7 +401,7 @@ def test_sort_by_highest_rated(self, result_store, mock_session, mock_roadmaps):
         )
         mock_session.query.return_value = mock_query
 
-        items, total = result_store.list_paginated(1, 10, "highest_rated")
+        items, total = result_store.list_catalog(1, 10, sort="highest_rated")
 
         assert total == 3
 
@@ -415,7 +415,7 @@ def test_sort_by_trending(self, result_store, mock_session, mock_roadmaps):
         )
         mock_session.query.return_value = mock_query
 
-        items, total = result_store.list_paginated(1, 10, "trending")
+        items, total = result_store.list_catalog(1, 10, sort="trending")
 
         assert total == 3
 
@@ -427,7 +427,7 @@ def test_pagination_parameters(self, result_store, mock_session):
         mock_query.offset.return_value.limit.return_value.all.return_value = []
         mock_session.query.return_value = mock_query
 
-        items, total = result_store.list_paginated(2, 10, "newest")
+        items, total = result_store.list_catalog(2, 10, sort="newest")
 
         # Verify offset and limit were called correctly
         mock_query.offset.assert_called_with(10)  # (page - 1) * page_size
@@ -442,7 +442,7 @@ def test_page_size_limits(self, result_store, mock_session):
         mock_session.query.return_value = mock_query
 
         # Request page_size > 100
-        items, total = result_store.list_paginated(1, 200, "newest")
+        items, total = result_store.list_catalog(1, 200, sort="newest")
 
         # Verify limit was capped at 100
         mock_query.offset.return_value.limit.assert_called_with(100)