Merge pull request #57 from alimkhann/feature/user-ratings

alimkhann · web-flow · commit eacd74a7efc8 · 2025-11-16T20:59:30.000+08:00
fix: make rating aggregation updates atomic
diff --git a/commitly-backend/app/services/roadmap_rating_store.py b/commitly-backend/app/services/roadmap_rating_store.py
@@ -88,10 +88,11 @@ def action() -> RoadmapRating:
                     )
                     self._session.add(record)
 
-                # Update aggregated stats on GeneratedRoadmap
+                # Update aggregated stats on GeneratedRoadmap atomically
                 roadmap = (
                     self._session.query(GeneratedRoadmap)
                     .filter_by(repo_full_name=repo_full_name)
+                    .with_for_update()
                     .one_or_none()
                 )
 

Original file line number	Diff line number	Diff line change
`@@ -88,10 +88,11 @@ def action() -> RoadmapRating:`
`88`	`88`	`)`
`89`	`89`	`self._session.add(record)`
`90`	`90`
`91`		`- # Update aggregated stats on GeneratedRoadmap`
	`91`	`+ # Update aggregated stats on GeneratedRoadmap atomically`
`92`	`92`	`roadmap = (`
`93`	`93`	`self._session.query(GeneratedRoadmap)`
`94`	`94`	`.filter_by(repo_full_name=repo_full_name)`
	`95`	`+ .with_for_update()`
`95`	`96`	`.one_or_none()`
`96`	`97`	`)`
`97`	`98`