Merge pull request #27 from alipay/using_lombok

Using lombok

Author: ScottWryyyyy

README.md

@@ -12,7 +12,7 @@ https://mvnrepository.com/artifact/com.alipay.global.sdk/global-open-sdk-java
 <dependency>
     <groupId>com.alipay.global.sdk</groupId>
     <artifactId>global-open-sdk-java</artifactId>
-    <version>2.0.23</version>
+    <version>2.0.25</version>
 </dependency>
 ```
 

pom.xml

@@ -4,7 +4,7 @@
     <groupId>com.alipay.global.sdk</groupId>
     <artifactId>global-open-sdk-java</artifactId>
     <packaging>jar</packaging>
-    <version>2.0.23</version>
+    <version>2.0.25</version>
     <name>global-open-sdk-java</name>
     <url>https://github.com/alipay/global-open-sdk-java</url>
     <description>
@@ -69,6 +69,13 @@
             <artifactId>fastjson</artifactId>
             <version>1.2.83</version>
         </dependency>
+        <!-- https://mvnrepository.com/artifact/org.projectlombok/lombok -->
+        <dependency>
+            <groupId>org.projectlombok</groupId>
+            <artifactId>lombok</artifactId>
+            <version>1.18.30</version>
+            <scope>provided</scope>
+        </dependency>
     </dependencies>
 
     <build>

src/main/java/com/alipay/global/api/BaseAlipayClient.java

@@ -7,20 +7,20 @@
 import com.alipay.global.api.request.AlipayRequest;
 import com.alipay.global.api.response.AlipayResponse;
 import com.alipay.global.api.tools.Constants;
-import com.alipay.global.api.tools.SignatureTool;
 import com.alipay.global.api.tools.DateTool;
+import com.alipay.global.api.tools.SignatureTool;
 import org.apache.commons.lang3.StringUtils;
 
 import java.util.HashMap;
 import java.util.Map;
 
-public abstract class BaseAlipayClient implements AlipayClient{
+public abstract class BaseAlipayClient implements AlipayClient {
 
     private static final Integer DEFAULT_KEY_VERSION = 1;
     /**
-     * eg:https://open-na.alipay.com
+     * eg: https://open-na.alipay.com
      */
-    private String               gatewayUrl;
+    private String gatewayUrl;
     /**
      * merchants private key
      */
@@ -30,10 +30,10 @@ public abstract class BaseAlipayClient implements AlipayClient{
      */
     private String alipayPublicKey;
 
-    public BaseAlipayClient(){
+    public BaseAlipayClient() {
     }
 
-    public BaseAlipayClient(String gatewayUrl, String merchantPrivateKey, String alipayPublicKey ){
+    public BaseAlipayClient(String gatewayUrl, String merchantPrivateKey, String alipayPublicKey) {
         this.gatewayUrl = gatewayUrl;
         this.merchantPrivateKey = merchantPrivateKey;
         this.alipayPublicKey = alipayPublicKey;
@@ -43,12 +43,12 @@ public <T extends AlipayResponse> T execute(AlipayRequest<T> alipayRequest) thro
 
         checkRequestParam(alipayRequest);
 
-        String  clientId    = alipayRequest.getClientId();
-        String  httpMethod  = alipayRequest.getHttpMethod();
-        String  path        = alipayRequest.getPath();
-        Integer keyVersion  = alipayRequest.getKeyVersion();
-        String  reqTime     = DateTool.getCurrentTimeMillis();
-        String  reqBody     = JSON.toJSONString(alipayRequest);
+        String clientId = alipayRequest.getClientId();
+        String httpMethod = alipayRequest.getHttpMethod();
+        String path = alipayRequest.getPath();
+        Integer keyVersion = alipayRequest.getKeyVersion();
+        String reqTime = DateTool.getCurrentTimeMillis();
+        String reqBody = JSON.toJSONString(alipayRequest);
 
         /**
          * 对内容加签(Sign the content)
@@ -58,9 +58,9 @@ public <T extends AlipayResponse> T execute(AlipayRequest<T> alipayRequest) thro
         /**
          *  生成必要header(Generate required headers)
          */
-        Map<String, String> header       = buildBaseHeader(reqTime, clientId, keyVersion, signValue);
+        Map<String, String> header = buildBaseHeader(reqTime, clientId, keyVersion, signValue);
         Map<String, String> customHeader = buildCustomHeader();
-        if(customHeader != null && customHeader.size() > 0){
+        if (customHeader != null && !customHeader.isEmpty()) {
             header.putAll(customHeader);
         }
 
@@ -70,33 +70,33 @@ public <T extends AlipayResponse> T execute(AlipayRequest<T> alipayRequest) thro
          */
         HttpRpcResult rsp = sendRequest(requestUrl, httpMethod, header, reqBody);
 
-        if(rsp == null){
+        if (rsp == null) {
             throw new AlipayApiException("HttpRpcResult is null.");
         }
 
-        int    httpRespCode = rsp.getRspCode();
-        String rspBody      = rsp.getRspBody();
-        if(httpRespCode != Constants.HTTP_SUCCESS_CODE){
+        int httpRespCode = rsp.getRspCode();
+        String rspBody = rsp.getRspBody();
+        if (httpRespCode != Constants.HTTP_SUCCESS_CODE) {
             throw new AlipayApiException("Response data error, rspBody:" + rspBody);
         }
-        Class<T> responseClass   = alipayRequest.getResponseClass();
-        T        alipayResponse  = JSON.parseObject(rspBody, responseClass);
-        Result   result          = alipayResponse.getResult();
-        if(result == null){
+        Class<T> responseClass = alipayRequest.getResponseClass();
+        T alipayResponse = JSON.parseObject(rspBody, responseClass);
+        Result result = alipayResponse.getResult();
+        if (result == null) {
             throw new AlipayApiException("Response data error, result field is null, rspBody:" + rspBody);
         }
 
         String rspSignValue = rsp.getRspSign();
-        String rspTime      = rsp.getResponseTime();
-        if(null == rspSignValue || rspSignValue.isEmpty() || null == rspTime || rspTime.isEmpty()){
+        String rspTime = rsp.getResponseTime();
+        if (null == rspSignValue || rspSignValue.isEmpty() || null == rspTime || rspTime.isEmpty()) {
             return alipayResponse;
         }
 
         /**
          * 对返回结果验签(Verify the result signature)
          */
         boolean isVerifySuccess = checkRspSign(httpMethod, path, clientId, rspTime, rspBody, rspSignValue);
-        if(!isVerifySuccess){
+        if (!isVerifySuccess) {
             throw new AlipayApiException("Response signature verify fail.");
         }
 
@@ -113,84 +113,83 @@ private String genSignValue(String httpMethod, String path, String clientId, Str
         return signatureValue;
     }
 
-    private boolean checkRspSign(String httpMethod, String path, String clientId, String responseTime, String rspBody, String rspSignValue) throws AlipayApiException{
-        try{
+    private boolean checkRspSign(String httpMethod, String path, String clientId, String responseTime, String rspBody, String rspSignValue) throws AlipayApiException {
+        try {
             boolean isVerify = SignatureTool.verify(httpMethod, path, clientId, responseTime, rspBody, rspSignValue, alipayPublicKey);
             return isVerify;
-        } catch(Exception e){
+        } catch (Exception e) {
             throw new AlipayApiException(e);
         }
 
     }
 
-    private void checkRequestParam(AlipayRequest alipayRequest) throws AlipayApiException{
-        if(alipayRequest == null){
+    private void checkRequestParam(AlipayRequest alipayRequest) throws AlipayApiException {
+        if (alipayRequest == null) {
             throw new AlipayApiException("alipayRequest can't null");
         }
 
         String clientId = alipayRequest.getClientId();
-        String httpMehod = alipayRequest.getHttpMethod();
+        String httpMethod = alipayRequest.getHttpMethod();
         String path = alipayRequest.getPath();
 
-        if(StringUtils.isBlank(gatewayUrl)){
+        if (StringUtils.isBlank(gatewayUrl)) {
             throw new AlipayApiException("gatewayUrl can't null");
         }
 
-        if(StringUtils.isBlank(clientId)){
+        if (StringUtils.isBlank(clientId)) {
             throw new AlipayApiException("clientId can't null");
         }
 
-        if(StringUtils.isBlank(httpMehod)){
+        if (StringUtils.isBlank(httpMethod)) {
             throw new AlipayApiException("httpMehod can't null");
         }
 
-        if(StringUtils.isBlank(path)){
+        if (StringUtils.isBlank(path)) {
             throw new AlipayApiException("path can't null");
         }
 
-        if(!path.startsWith("/")){
+        if (!path.startsWith("/")) {
             throw new AlipayApiException("path must start with /");
         }
 
     }
 
-    private String genRequestUrl(String path){
-        if(!gatewayUrl.startsWith("http://") && !gatewayUrl.startsWith("https://")){
+    private String genRequestUrl(String path) {
+        if (!gatewayUrl.startsWith("http://") && !gatewayUrl.startsWith("https://")) {
             gatewayUrl = "https://" + gatewayUrl;
         }
-        if(gatewayUrl.endsWith("/")){
+        if (gatewayUrl.endsWith("/")) {
             int len = gatewayUrl.length();
             gatewayUrl = gatewayUrl.substring(0, len - 1);
         }
-        String requestUrl = gatewayUrl + path;
-        return requestUrl;
+        return gatewayUrl + path;
 
     }
 
     /**
      * Generate required headers
+     *
      * @param requestTime
      * @param clientId
      * @param keyVersion
      * @param signatureValue
      * @return
      */
-    private Map<String,String> buildBaseHeader(String requestTime, String clientId, Integer keyVersion, String signatureValue){
+    private Map<String, String> buildBaseHeader(String requestTime, String clientId, Integer keyVersion, String signatureValue) {
         Map<String, String> header = new HashMap<String, String>();
         header.put(Constants.CONTENT_TYPE_HEADER, "application/json; charset=UTF-8");
         header.put(Constants.REQ_TIME_HEADER, requestTime);
         header.put(Constants.CLIENT_ID_HEADER, clientId);
-        if(keyVersion == null){
+        if (keyVersion == null) {
             keyVersion = DEFAULT_KEY_VERSION;
         }
         String signatureHeader = "algorithm=RSA256,keyVersion=" + keyVersion + ",signature=" + signatureValue;
         header.put(Constants.REQ_SIGN_HEADER, signatureHeader);
         return header;
     }
 
-    public abstract Map<String,String> buildCustomHeader();
-
-    public abstract HttpRpcResult sendRequest(String requestUrl, String httpMethod, Map<String, String> header, String reqBody)throws AlipayApiException;
+    public abstract Map<String, String> buildCustomHeader();
 
+    public abstract HttpRpcResult sendRequest(String requestUrl, String httpMethod, Map<String, String> header, String reqBody) throws AlipayApiException;
 
 }

src/main/java/com/alipay/global/api/DefaultAlipayClient.java

@@ -1,11 +1,11 @@
 package com.alipay.global.api;
 
-import java.util.Map;
-
 import com.alipay.global.api.exception.AlipayApiException;
 import com.alipay.global.api.net.DefaultHttpRPC;
 import com.alipay.global.api.net.HttpRpcResult;
 
+import java.util.Map;
+
 public class DefaultAlipayClient extends BaseAlipayClient {
 
     public DefaultAlipayClient(String gatewayUrl, String merchantPrivateKey, String alipayPublicKey) {

src/main/java/com/alipay/global/api/example/PayNotifyListener.java

@@ -11,35 +11,35 @@
 
 public class PayNotifyListener {
 
-    public void acceptNotify(HttpRequest request, HttpResponse response){
+    public void acceptNotify(HttpRequest request, HttpResponse response) {
 
         InputStream inputStream = request.getInputStream();
-        String      reqBody     = read(inputStream);
+        String reqBody = read(inputStream);
 
         PayNotifyRequest payNotifyRequest = JSON.parseObject(reqBody, PayNotifyRequest.class);
 
-        if(!PaymentNotifyType.PAYMENT_RESULT.equals(payNotifyRequest.getNotifyType())){
+        if (!PaymentNotifyType.PAYMENT_RESULT.equals(payNotifyRequest.getNotifyType())) {
             return;
         }
-        Result resultInfo       = payNotifyRequest.getResultInfo();
+        Result resultInfo = payNotifyRequest.getResultInfo();
         String paymentRequestId = payNotifyRequest.getPaymentRequestId();
         ResultStatusType resultStatus = resultInfo.getResultStatus();
 
         boolean isAcceptSuccess = false;
-        if(ResultStatusType.S.equals(resultStatus)){
+        if (ResultStatusType.S.equals(resultStatus)) {
             // TODO Update the record status to success by paymentRequestId
             isAcceptSuccess = true;
-        } else if(ResultStatusType.F.equals(resultStatus)){
+        } else if (ResultStatusType.F.equals(resultStatus)) {
             // TODO Update the record status to fail by paymentRequestId
             isAcceptSuccess = true;
         } else {
             // TODO Notify exception, contact tech support
-            return ;
+            return;
         }
 
-        Result result = new Result("SUCCESS", "success", ResultStatusType.S);
-        if(!isAcceptSuccess){
-            result = new Result("PROCESS_FAIL", "failure", ResultStatusType.F);
+        Result result = new Result("SUCCESS", ResultStatusType.S, "success");
+        if (!isAcceptSuccess) {
+            result = new Result("PROCESS_FAIL", ResultStatusType.F, "failure");
         }
         try {
             PayNotifyResponse payNotifyResponse = new PayNotifyResponse();
@@ -50,7 +50,7 @@ public void acceptNotify(HttpRequest request, HttpResponse response){
 
     }
 
-    public String read(InputStream inputStream){
+    public String read(InputStream inputStream) {
 
         return null;
     }

src/main/java/com/alipay/global/api/example/RiskDecideDemoCode.java

@@ -196,7 +196,7 @@ public static void buildRiskDecideRequest(RiskDecideRequest request) {
         buyer.setReferenceBuyerId("test12345678");
         buyer.setBuyerPhoneNo("12345678912");
         buyer.setBuyerEmail("[email protected]");
-        buyer.setAccountVerified(true);
+        buyer.setIsAccountVerified(true);
         buyer.setSuccessfulOrderCount(100);
         UserName buyerName = new UserName();
         buyerName.setFirstName("Dehua");

src/main/java/com/alipay/global/api/example/excutable/CashierExecutableDemoCode.java

@@ -95,7 +95,7 @@ private static void cashierPay(){
 
         // set auth capture payment mode
         PaymentFactor paymentFactor = new PaymentFactor();
-        paymentFactor.setAuthorization(true);
+        paymentFactor.setIsAuthorization(true);
         alipayPayRequest.setPaymentFactor(paymentFactor);
 
         // replace to your notify url

src/main/java/com/alipay/global/api/example/excutable/CashierPayExecutableDemoCode.java

@@ -143,7 +143,7 @@ public static void executePayWithCard() {
 
         // set auth capture payment mode
         PaymentFactor paymentFactor = new PaymentFactor();
-        paymentFactor.setAuthorization(true);
+        paymentFactor.setIsAuthorization(true);
         alipayPayRequest.setPaymentFactor(paymentFactor);
 
         // replace to your notify url
@@ -216,7 +216,7 @@ public static void executePayWithBlik() {
 
         // set auth capture payment mode
         PaymentFactor paymentFactor = new PaymentFactor();
-        paymentFactor.setAuthorization(true);
+        paymentFactor.setIsAuthorization(true);
         alipayPayRequest.setPaymentFactor(paymentFactor);
 
         // replace to your notify url
@@ -268,7 +268,7 @@ public static void executePaymentSessionCreateWithCard(){
 
         // set auth capture payment mode
         PaymentFactor paymentFactor = new PaymentFactor();
-        paymentFactor.setAuthorization(true);
+        paymentFactor.setIsAuthorization(true);
         alipayPaymentSessionRequest.setPaymentFactor(paymentFactor);
 
         // replace to your orderId