Add base fragment

Author: sLee0306

app/src/main/java/com/sample/android/tmdb/ui/base/BaseDetailFragment.kt

@@ -4,37 +4,23 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import androidx.annotation.LayoutRes
-import androidx.databinding.DataBindingUtil
 import androidx.databinding.ViewDataBinding
 import androidx.databinding.library.baseAdapters.BR
 import androidx.lifecycle.ViewModel
-import dagger.android.support.DaggerFragment
 
-abstract class BaseDetailFragment<VM: ViewModel, VB: ViewDataBinding>(
-    @LayoutRes private val layoutId: Int
-): DaggerFragment() {
+abstract class BaseDetailFragment<VM: ViewModel, VB: ViewDataBinding>: BaseFragment<VB>() {
 
     protected abstract val viewModel: VM
 
-    private var _binding: VB? = null
-
-    protected val binding get() = _binding!!
-
     override fun onCreateView(
         inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?
-    ): View? {
-        _binding = DataBindingUtil.inflate(inflater, layoutId, container, false)
+    ): View {
+        super.onCreateView(inflater, container, savedInstanceState)
         binding.apply {
             setVariable(BR.vm, viewModel)
             // Set the lifecycleOwner so DataBinding can observe LiveData
             lifecycleOwner = viewLifecycleOwner
         }
-        return super.onCreateView(inflater, container, savedInstanceState)
-    }
-
-    override fun onDestroyView() {
-        super.onDestroyView()
-        _binding = null
+        return binding.root
     }
 }

app/src/main/java/com/sample/android/tmdb/ui/base/BaseFragment.kt

@@ -0,0 +1,31 @@
+package com.sample.android.tmdb.ui.base
+
+import android.os.Bundle
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
+import androidx.databinding.ViewDataBinding
+import dagger.android.support.DaggerFragment
+
+open class BaseFragment<VB: ViewDataBinding>: DaggerFragment() {
+
+    private var _binding: VB? = null
+
+    protected val binding get() = _binding!!
+
+    protected open fun setBinding(): VB? = null
+
+    override fun onCreateView(
+        inflater: LayoutInflater,
+        container: ViewGroup?,
+        savedInstanceState: Bundle?
+    ): View? {
+        _binding = this.setBinding()
+        return binding.root
+    }
+
+    override fun onDestroyView() {
+        super.onDestroyView()
+        _binding = null
+    }
+}

app/src/main/java/com/sample/android/tmdb/ui/base/BaseNavigationFragment.kt

@@ -2,14 +2,14 @@ package com.sample.android.tmdb.ui.base
 
 import android.content.Intent
 import android.os.Bundle
+import androidx.databinding.ViewDataBinding
 import com.sample.android.tmdb.domain.model.TmdbItem
 import com.sample.android.tmdb.ui.detail.movie.DetailMovieActivity
 import com.sample.android.tmdb.ui.detail.tvshow.DetailTVShowActivity
 import com.sample.android.tmdb.ui.feed.NavType
 import com.sample.android.tmdb.util.Constants
-import dagger.android.support.DaggerFragment
 
-abstract class BaseNavigationFragment : DaggerFragment()  {
+abstract class BaseNavigationFragment<VB: ViewDataBinding> : BaseFragment<VB>()  {
 
     protected abstract val navType: NavType
 

app/src/main/java/com/sample/android/tmdb/ui/detail/DetailFragment.kt

@@ -20,15 +20,16 @@ import com.sample.android.tmdb.util.setupActionBar
 import com.sample.android.tmdb.util.toVisibility
 import javax.inject.Inject
 
-abstract class DetailFragment : BaseDetailFragment<DetailViewModel, FragmentDetailBinding>
-    (R.layout.fragment_detail) {
+abstract class DetailFragment : BaseDetailFragment<DetailViewModel, FragmentDetailBinding>() {
 
     @Inject
     lateinit var tmdbItem: TmdbItem
 
+    override fun setBinding() = FragmentDetailBinding.inflate(layoutInflater)
+
     override fun onCreateView(
         inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?
-    ): View? {
+    ): View {
         super.onCreateView(inflater, container, savedInstanceState)
         with(binding) {
             tmdbItem = this@DetailFragment.tmdbItem

app/src/main/java/com/sample/android/tmdb/ui/feed/FeedFragment.kt

@@ -10,7 +10,7 @@ import com.sample.android.tmdb.ui.common.Content
 import com.sample.android.tmdb.ui.common.TmdbTheme
 import com.sample.android.tmdb.ui.common.composeView
 
-abstract class FeedFragment<T : TmdbItem> : BaseNavigationFragment() {
+abstract class FeedFragment<T : TmdbItem> : BaseNavigationFragment<Nothing>() {
 
     protected abstract val viewModel: FeedViewModel<T>
 

app/src/main/java/com/sample/android/tmdb/ui/paging/BasePagingFragment.kt

@@ -13,27 +13,23 @@ import com.sample.android.tmdb.data.paging.Status.RUNNING
 import com.sample.android.tmdb.ui.base.BaseNavigationFragment
 import com.sample.android.tmdb.widget.MarginDecoration
 
-abstract class BasePagingFragment<T : TmdbItem> : BaseNavigationFragment() {
+abstract class BasePagingFragment<T : TmdbItem> : BaseNavigationFragment<FragmentMainBinding>() {
 
     protected abstract val viewModel: BasePagingViewModel<T>
 
-    private var _binding: FragmentMainBinding? = null
-
-    protected val binding get() = _binding!!
-
     protected lateinit var tmdbAdapter: TmdbAdapter<T>
 
     protected open fun refresh() {
         viewModel.refresh()
     }
 
+    override fun setBinding() = FragmentMainBinding.inflate(layoutInflater)
+
     override fun onCreateView(
         inflater: LayoutInflater, container: ViewGroup?,
         savedInstanceState: Bundle?
     ): View? {
-
-        _binding = FragmentMainBinding.inflate(inflater)
-
+        super.onCreateView(inflater, container, savedInstanceState)
         tmdbAdapter = TmdbAdapter(viewModel::retry, object : TmdbClickCallback<T> {
             override fun onClick(t: T) {
                 startDetailActivity(t)
@@ -79,9 +75,4 @@ abstract class BasePagingFragment<T : TmdbItem> : BaseNavigationFragment() {
 
         return binding.root
     }
-
-    override fun onDestroyView() {
-        super.onDestroyView()
-        _binding = null
-    }
 }

app/src/main/java/com/sample/android/tmdb/ui/person/PersonFragment.kt

@@ -14,7 +14,7 @@ import javax.inject.Inject
 
 class PersonFragment @Inject
 constructor() // Required empty public constructor
-    : BaseDetailFragment<PersonViewModel, FragmentPersonBinding>(R.layout.fragment_person) {
+    : BaseDetailFragment<PersonViewModel, FragmentPersonBinding>() {
 
     @Inject
     lateinit var factory: PersonViewModel.Factory
@@ -26,6 +26,8 @@ constructor() // Required empty public constructor
         ViewModelProvider(this, factory)[PersonViewModel::class.java]
     }
 
+    override fun setBinding() = FragmentPersonBinding.inflate(layoutInflater)
+
     override fun onCreateView(
         inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?
     ): View {

app/src/main/res/layout/tmdb_item.xml

@@ -23,6 +23,7 @@
         android:onClick="@{() -> callback.onClick(tmdbItem)}"
         app:cardElevation="@dimen/z_app_bar"
         app:ImageUrl="@{tmdbItem.posterUrl}"
+        app:cardCornerRadius="10dp"
         tools:ignore="KeyboardInaccessibleWidget">
 
         <ImageView