Lint

Author: vkucera

machine_learning_hep/analysis/do_systematics.py

@@ -15,9 +15,6 @@
 Author: Vit Kucera <[email protected]>
 """
 
-# pylint: disable=too-many-lines, too-many-instance-attributes, too-many-statements, too-many-locals
-# pylint: disable=too-many-nested-blocks, too-many-branches, consider-using-f-string
-
 import argparse
 import logging
 import os
@@ -94,7 +91,7 @@ def __init__(self, path_database_analysis: str, typean: str):
 
         with open(path_database_analysis, encoding="utf-8") as file_in:
             db_analysis = yaml.safe_load(file_in)
-        case = list(db_analysis.keys())[0]
+        case = next(iter(db_analysis.keys()))
         self.datap = db_analysis[case]
         self.db_typean = self.datap["analysis"][self.typean]
 
@@ -790,28 +787,21 @@ def do_jet_systematics(self, var: str):
                                     count_sys_up = count_sys_up + 1
                             else:
                                 error_var_up = max(error_var_up, error)
-                        else:
-                            if self.systematic_rms[sys_cat] is True:
-                                if self.systematic_rms_both_sides[sys_cat] is True:
-                                    error_var_up += error * error
-                                    if not out_sys:
-                                        count_sys_up = count_sys_up + 1
-                                else:
-                                    error_var_down += error * error
-                                    if not out_sys:
-                                        count_sys_down = count_sys_down + 1
+                        elif self.systematic_rms[sys_cat] is True:
+                            if self.systematic_rms_both_sides[sys_cat] is True:
+                                error_var_up += error * error
+                                if not out_sys:
+                                    count_sys_up = count_sys_up + 1
                             else:
-                                error_var_down = max(error_var_down, abs(error))
-                    if self.systematic_rms[sys_cat] is True:
-                        if count_sys_up != 0:
-                            error_var_up = error_var_up / count_sys_up
+                                error_var_down += error * error
+                                if not out_sys:
+                                    count_sys_down = count_sys_down + 1
                         else:
-                            error_var_up = 0.0
+                            error_var_down = max(error_var_down, abs(error))
+                    if self.systematic_rms[sys_cat] is True:
+                        error_var_up = error_var_up / count_sys_up if count_sys_up != 0 else 0.0
                         error_var_up = sqrt(error_var_up)
-                        if count_sys_down != 0:
-                            error_var_down = error_var_down / count_sys_down
-                        else:
-                            error_var_down = 0.0
+                        error_var_down = error_var_down / count_sys_down if count_sys_down != 0 else 0.0
                         if self.systematic_rms_both_sides[sys_cat] is True:
                             error_var_down = error_var_up
                         else:
@@ -918,7 +908,8 @@ def do_jet_systematics(self, var: str):
                 shapebins_error_down_cat = []
                 for ibinshape in range(n_bins_obs_gen):
                     shapebins_contents_cat.append(0)
-                    if abs(input_histograms_default[iptjet].GetBinContent(ibinshape + 1)) < 1.0e-7:
+                    epsilon_float = 1.0e-7
+                    if abs(input_histograms_default[iptjet].GetBinContent(ibinshape + 1)) < epsilon_float:
                         print("WARNING!!! Input histogram at bin", iptjet, " equal 0", suffix)
                         e_up = 0
                         e_down = 0
@@ -992,7 +983,8 @@ def do_jet_systematics(self, var: str):
             suffix = self.get_suffix_ptjet(iptjet)
             h_default_stat_err.append(input_histograms_default[iptjet].Clone("h_default_stat_err" + suffix))
             for i in range(h_default_stat_err[iptjet].GetNbinsX()):
-                if abs(input_histograms_default[iptjet].GetBinContent(i + 1)) < 1.0e-7:
+                epsilon_float = 1.0e-7
+                if abs(input_histograms_default[iptjet].GetBinContent(i + 1)) < epsilon_float:
                     print("WARNING!!! Input histogram at bin", iptjet, " equal 0", suffix)
                     h_default_stat_err[iptjet].SetBinContent(i + 1, 0)
                     h_default_stat_err[iptjet].SetBinError(i + 1, 0)

machine_learning_hep/plotting/plot_jetsubstructure_run3.py

@@ -15,10 +15,6 @@
 Author: Vit Kucera <[email protected]>
 """
 
-# pylint: disable=too-many-lines, too-many-instance-attributes, too-many-statements, too-many-locals
-# pylint: disable=too-many-nested-blocks, too-many-branches, consider-using-f-string
-# pylint: disable=unused-variable
-
 import argparse
 import logging
 import os
@@ -106,7 +102,7 @@ def __init__(self, path_input_file: str, path_database_analysis: str, typean: st
 
         with open(path_database_analysis, encoding="utf-8") as file_db:
             db_analysis = yaml.safe_load(file_db)
-        case = list(db_analysis.keys())[0]
+        case = next(iter(db_analysis.keys()))
         self.datap = db_analysis[case]
         self.db_typean = self.datap["analysis"][self.typean]
 
@@ -406,7 +402,7 @@ def get_run3_sim(self) -> dict:
         source = {"monash": "M", "mode2": "SM2"}
         dict_obj = {}
         with TFile.Open(path_file) as file:
-            for s_obs, obs in obs.items():
+            for s_obs, n_obs in obs.items():
                 dict_obj[s_obs] = {}
                 for s_spec, spec in species.items():
                     dict_obj[s_obs][s_spec] = {}
@@ -418,7 +414,7 @@ def get_run3_sim(self) -> dict:
                             name = pattern % (
                                 spec,
                                 src,
-                                obs,
+                                n_obs,
                                 self.edges_ptjet_gen[iptjet],
                                 self.edges_ptjet_gen[iptjet + 1],
                             )
@@ -681,7 +677,7 @@ def plot(self):
                 self.make_plot(f"{self.species}_efficiency_{self.var}")
 
                 bins_ptjet = (0, 1, 2, 3)
-                for cat, label in zip(("pr", "np"), ("prompt", "non-prompt")):
+                for cat, label in zip(("pr", "np"), ("prompt", "non-prompt"), strict=False):
                     self.list_obj = self.get_objects(
                         *(
                             f"h_ptjet-pthf_effnew_{cat}_{string_range_ptjet(get_bin_limits(axis_ptjet, iptjet + 1))}"
@@ -1206,7 +1202,7 @@ def plot(self):
                 # TODO: if plot_run2_lc_ff_data
                 if h_run2 is not None:
                     n_obj = len(self.list_obj)
-                    self.plot_order = list(range(n_obj)) + [-1, -0.5]
+                    self.plot_order = [*list(range(n_obj)), -1, -0.5]
                     self.list_obj += [g_run2, h_run2]
                     self.labels_obj += [f"{self.text_run2}, {self.get_text_range_ptjet(2)}", ""]
                     self.list_colours += [get_colour(-1)] * 2

machine_learning_hep/utilities.py

@@ -128,10 +128,7 @@ def write_df(dfo, path):
 
 def read_df(path, **kwargs):
     try:
-        if path.endswith(".parquet"):
-            df = pd.read_parquet(path, **kwargs)
-        else:
-            df = pickle.load(openfile(path, "rb"))
+        df = pd.read_parquet(path, **kwargs) if path.endswith(".parquet") else pickle.load(openfile(path, "rb"))
     except Exception as e:  # pylint: disable=broad-except
         logger.critical("failed to open file <%s>: %s", path, str(e))
         sys.exit()
@@ -294,12 +291,12 @@ def make_latex_table(column_names, row_names, rows, caption=None, save_path="./t
         columns = "|".join(["c"] * (len(column_names) + 1))
         f.write("\\begin{tabular}{" + columns + "}\n")
         f.write("\\hline\n")
-        columns = "&".join([""] + column_names)
+        columns = "&".join(["", *column_names])
         columns = columns.replace("_", "\\_")
         f.write(columns + "\\\\\n")
         f.write("\\hline\\hline\n")
-        for rn, row in zip(row_names, rows):
-            row_string = "&".join([rn] + row)
+        for rn, row in zip(row_names, rows, strict=False):
+            row_string = "&".join([rn, *row])
             row_string = row_string.replace("_", "\\_")
             f.write(row_string + "\\\\\n")
         f.write("\\end{tabular}\n")
@@ -349,12 +346,12 @@ def make_message_notfound(name, location=None):
 
 
 def z_calc(pt_1, phi_1, eta_1, pt_2, phi_2, eta_2):
-    np_pt_1 = pt_1.values
-    np_pt_2 = pt_2.values
-    np_phi_1 = phi_1.values
-    np_phi_2 = phi_2.values
-    np_eta_1 = eta_1.values
-    np_eta_2 = eta_2.values
+    np_pt_1 = pt_1.to_numpy()
+    np_pt_2 = pt_2.to_numpy()
+    np_phi_1 = phi_1.to_numpy()
+    np_phi_2 = phi_2.to_numpy()
+    np_eta_1 = eta_1.to_numpy()
+    np_eta_2 = eta_2.to_numpy()
 
     cos_phi_1 = np.cos(np_phi_1)
     cos_phi_2 = np.cos(np_phi_2)
@@ -397,10 +394,7 @@ def equal_axis_list(axis1, list2, precision=10):
     bins = get_bins(axis1)
     if len(bins) != len(list2):
         return False
-    for i, j in zip(bins, list2):
-        if round(i, precision) != round(j, precision):
-            return False
-    return True
+    return all(round(i, precision) == round(j, precision) for i, j in zip(bins, list2, strict=False))
 
 
 def equal_binning(his1, his2):
@@ -418,9 +412,7 @@ def equal_binning_lists(his, list_x=None, list_y=None, list_z=None):
         return False
     if list_y is not None and not equal_axis_list(his.GetYaxis(), list_y):
         return False
-    if list_z is not None and not equal_axis_list(his.GetZaxis(), list_z):
-        return False
-    return True
+    return not (list_z is not None and not equal_axis_list(his.GetZaxis(), list_z))
 
 
 def folding(h_input, response_matrix, h_output):
@@ -939,13 +931,13 @@ def plot_latex(latex):
     # set canvas margins
     if isinstance(margins_c, list) and len(margins_c) > 0:
         for setter, value in zip(
-            [can.SetBottomMargin, can.SetLeftMargin, can.SetTopMargin, can.SetRightMargin], margins_c
+            [can.SetBottomMargin, can.SetLeftMargin, can.SetTopMargin, can.SetRightMargin], margins_c, strict=False
         ):
             setter(value)
     # set logarithmic scale for selected axes
     log_y = False
     if isinstance(logscale, str) and len(logscale) > 0:
-        for setter, axis in zip([can.SetLogx, can.SetLogy, can.SetLogz], ["x", "y", "z"]):
+        for setter, axis in zip([can.SetLogx, can.SetLogy, can.SetLogz], ["x", "y", "z"], strict=False):
             if axis in logscale:
                 setter()
                 if axis == "y":
@@ -1349,7 +1341,7 @@ def format_value_with_unc(y, e_stat=None, e_syst_plus=None, e_syst_minus=None, n
         if str_e_syst_plus == str_e_syst_minus:
             str_value += f" ± {str_e_syst_plus} (syst.)"
         else:
-            str_value += f" +{str_e_syst_plus} −{str_e_syst_minus} (syst.)"
+            str_value += f" +{str_e_syst_plus} −{str_e_syst_minus} (syst.)"  # noqa: RUF001
     return str_value