Skip to content

Commit 4b1ccaa

Browse files
committed
fix default mode issue
1 parent 69877d2 commit 4b1ccaa

File tree

6 files changed

+18
-7
lines changed

6 files changed

+18
-7
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,4 @@ resource/metas.go
2020
local-*
2121
coverage.txt
2222
oss/lib/ossutil_test*
23+
coverage.html

config/configuration_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func TestCFNewProfile(t *testing.T) {
4646
assert.Len(t, cf.Profiles, 1)
4747
exp := Profile{
4848
Name: "default",
49-
Mode: AK,
49+
Mode: "",
5050
OutputFormat: "json",
5151
Language: "en",
5252
}
@@ -60,7 +60,7 @@ func TestConfiguration(t *testing.T) {
6060
assert.False(t, ok)
6161
assert.Equal(t, Profile{Name: "hh"}, p)
6262
p, ok = cf.GetProfile("default")
63-
assert.Equal(t, Profile{Name: "default", Mode: AK, OutputFormat: "json", Language: "en"}, p)
63+
assert.Equal(t, Profile{Name: "default", Mode: "", OutputFormat: "json", Language: "en"}, p)
6464

6565
//PutProfile
6666
assert.Len(t, cf.Profiles, 1)
@@ -103,7 +103,7 @@ func TestConfiguration(t *testing.T) {
103103
assert.Equal(t, Profile{Name: "test", Mode: StsToken, OutputFormat: "json", Language: "en"}, p)
104104
os.Setenv("ALICLOUD_PROFILE", "")
105105
p = cf.GetCurrentProfile(ctx)
106-
assert.Equal(t, Profile{Name: "default", Mode: AK, OutputFormat: "json", Language: "en"}, p)
106+
assert.Equal(t, Profile{Name: "default", Mode: "", OutputFormat: "json", Language: "en"}, p)
107107
}
108108

109109
func TestLoadProfile(t *testing.T) {
@@ -242,7 +242,7 @@ func TestLoadConfiguration(t *testing.T) {
242242
//testcase 1
243243
cf, err := LoadConfiguration(GetConfigPath() + "/" + configFile)
244244
assert.Nil(t, err)
245-
assert.Equal(t, &Configuration{CurrentProfile: "default", Profiles: []Profile{Profile{Name: "default", Mode: "AK", OutputFormat: "json", Language: "en"}}}, cf)
245+
assert.Equal(t, &Configuration{CurrentProfile: "default", Profiles: []Profile{Profile{Name: "default", Mode: "", OutputFormat: "json", Language: "en"}}}, cf)
246246
conf := &Configuration{Profiles: []Profile{Profile{Language: "en", Name: "default", Mode: "AK", AccessKeyId: "access_key_id", AccessKeySecret: "access_key_secret", RegionId: "cn-hangzhou", OutputFormat: "json"}}}
247247
err = SaveConfiguration(conf)
248248
assert.Nil(t, err)

config/hello_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ func TestDoHello(t *testing.T) {
3232
ctx := cli.NewCommandContext(w, stderr)
3333
ctx.Flags().AddByName("skip-secure-verify")
3434
profile := NewProfile("default")
35+
profile.Mode = AK
3536

3637
exw := "-----------------------------------------------\n" +
3738
"!!! Configure Failed please configure again !!!\n" +

config/profile.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,13 @@ type Profile struct {
7878
func NewProfile(name string) Profile {
7979
return Profile{
8080
Name: name,
81-
Mode: AK,
81+
Mode: "",
8282
OutputFormat: "json",
8383
Language: "en",
8484
}
8585
}
8686

8787
func (cp *Profile) Validate() error {
88-
8988
if cp.RegionId == "" {
9089
return fmt.Errorf("region can't be empty")
9190
}
@@ -198,7 +197,14 @@ func (cp *Profile) OverwriteWithFlags(ctx *cli.Context) {
198197
}
199198

200199
if cp.StsToken == "" {
201-
cp.StsToken = os.Getenv("SECURITY_TOKEN")
200+
switch {
201+
case os.Getenv("ALIBABACLOUD_SECURITY_TOKEN") != "":
202+
cp.StsToken = os.Getenv("ALIBABACLOUD_SECURITY_TOKEN")
203+
case os.Getenv("ALICLOUD_SECURITY_TOKEN") != "":
204+
cp.StsToken = os.Getenv("ALICLOUD_SECURITY_TOKEN")
205+
case os.Getenv("SECURITY_TOKEN") != "":
206+
cp.StsToken = os.Getenv("SECURITY_TOKEN")
207+
}
202208
}
203209

204210
if cp.RegionId == "" {
@@ -211,6 +217,7 @@ func (cp *Profile) OverwriteWithFlags(ctx *cli.Context) {
211217
cp.RegionId = os.Getenv("REGION")
212218
}
213219
}
220+
214221
AutoModeRecognition(cp)
215222
}
216223

config/profile_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ func TestNewProfile(t *testing.T) {
5353
exp := newProfile()
5454
exp.Mode = AK
5555
p := NewProfile("default")
56+
p.Mode = AK
5657
assert.Equal(t, exp, &p)
5758
}
5859

openapi/commando_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,7 @@ func Test_complete(t *testing.T) {
313313

314314
func TestCreateInvoker(t *testing.T) {
315315
profile := config.NewProfile("test")
316+
profile.Mode = config.AK
316317
profile.AccessKeyId = "AccessKeyId"
317318
profile.AccessKeySecret = "AccessKeySecret"
318319
profile.RegionId = "cn-hangzhou"

0 commit comments

Comments
 (0)