Skip to content

Commit b0e3baf

Browse files
authored
fix: Call error when adding -FILE after parameter name (#227)
1 parent 58336d4 commit b0e3baf

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
### Master
44

5+
- fix: Invoke error when reading parameter value from file using `-FILE`
6+
57
### 3.0.28
68

79
- update: meta data

cli/flag_set.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ package cli
1515

1616
import (
1717
"fmt"
18+
"strings"
1819
)
1920

2021
type FlagSet struct {
@@ -59,6 +60,9 @@ func (fs *FlagSet) AddByName(name string) (*Flag, error) {
5960
f := &Flag{
6061
Name: name,
6162
}
63+
if strings.HasSuffix(name, "-FILE") {
64+
f.Aliases = append(f.Aliases, strings.TrimSuffix(name, "-FILE"))
65+
}
6266
fs.Add(f)
6367
return f, nil
6468
}

cli/flag_set_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ func TestAddByName(t *testing.T) {
5858
assert.Nil(t, f)
5959
assert.EqualError(t, err, "flag duplicated --MrX2")
6060

61+
f, err = fs.AddByName("Mrx-FILE")
62+
assert.Nil(t, err)
63+
assert.Equal(t, 1, len(f.Aliases))
64+
assert.Equal(t, "Mrx", f.Aliases[0])
65+
6166
}
6267

6368
func TestGet(t *testing.T) {

0 commit comments

Comments
 (0)