Skip to content

promise FanIn future 使用错误 #102

@epolar

Description

@epolar
func FanIn(futures ...*Future) *Future {
	f := NewFuture()
	go func() {
		fanResults := make([]*FanResult, len(futures))
		wg := new(sync.WaitGroup)
		wg.Add(len(futures))
                 // 协程捕获到的 f 是错误的,只会是最后一个
		for i, f := range futures {
			go func(idx int) {
				defer wg.Done()
				ret, err := f.Get()
				fanResults[idx] = &FanResult{Result: ret, Err: err}
			}(i)
		}
		wg.Wait()
		f.Set(fanResults, nil)
	}()
	return f
}

修正版:

func FanIn(futures ...*Future) *Future {
	f := NewFuture()
	go func() {
		fanResults := make([]*FanResult, len(futures))
		wg := new(sync.WaitGroup)
		wg.Add(len(futures))
                 // 协程捕获到的 f 是错误的,只会是最后一个
		for i, f := range futures {
			go func(idx int, f *Future) {
				defer wg.Done()
				ret, err := f.Get()
				fanResults[idx] = &FanResult{Result: ret, Err: err}
			}(i, f)
		}
		wg.Wait()
		f.Set(fanResults, nil)
	}()

SDK版本:
v1.7.17

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions