fix: golint and clippy

Author: decebal

apps/control-plane/main.go

@@ -18,18 +18,23 @@ import (
 	"github.com/allsource/control-plane/internal"
 )
 
+// Control plane configuration constants.
 const (
-	DefaultPort    = "3901"
+	// DefaultPort is the default port the control plane listens on.
+	DefaultPort = "3901"
+	// CoreServiceURL is the URL of the core event store service.
 	CoreServiceURL = "http://localhost:3900"
 )
 
+// ControlPlane is the main control plane service that manages the event store cluster.
 type ControlPlane struct {
 	client    *resty.Client
 	router    *gin.Engine
 	metrics   *ControlPlaneMetrics
 	container *internal.Container
 }
 
+// NewControlPlane creates a new control plane instance with default configuration.
 func NewControlPlane() *ControlPlane {
 	client := resty.New().
 		SetTimeout(5 * time.Second).
@@ -220,6 +225,7 @@ func (cp *ControlPlane) replayHandler(c *gin.Context) {
 	})
 }
 
+// Start starts the control plane HTTP server on the specified port.
 func (cp *ControlPlane) Start(port string) error {
 	return cp.router.Run(":" + port)
 }

apps/control-plane/main_v1.go

@@ -15,10 +15,13 @@ import (
 	"github.com/allsource/control-plane/internal/domain/entities"
 )
 
+// Version constants for the control plane.
 const (
+	// Version is the current version of the control plane.
 	Version = "1.0.0"
 )
 
+// ControlPlaneV1 is the v1.0 control plane with authentication and audit logging.
 type ControlPlaneV1 struct {
 	client      *resty.Client
 	router      *gin.Engine
@@ -27,6 +30,7 @@ type ControlPlaneV1 struct {
 	auditLogger *AuditLogger
 }
 
+// NewControlPlaneV1 creates a new v1.0 control plane instance with auth and audit logging.
 func NewControlPlaneV1() (*ControlPlaneV1, error) {
 	// Initialize auth client
 	jwtSecret := os.Getenv("JWT_SECRET")
@@ -463,10 +467,12 @@ func (cp *ControlPlaneV1) proxyToCoreAuthWithBody(c *gin.Context, method, path s
 	return resp, nil
 }
 
+// Start starts the control plane HTTP server on the specified port.
 func (cp *ControlPlaneV1) Start(port string) error {
 	return cp.router.Run(":" + port)
 }
 
+// Shutdown gracefully shuts down the control plane and closes resources.
 func (cp *ControlPlaneV1) Shutdown() error {
 	if cp.auditLogger != nil {
 		return cp.auditLogger.Close()

apps/control-plane/policy.go

@@ -13,10 +13,14 @@ import (
 // PolicyAction represents an action that can be taken
 type PolicyAction string
 
+// Policy action constants.
 const (
+	// ActionAllow permits the operation.
 	ActionAllow PolicyAction = "allow"
-	ActionDeny  PolicyAction = "deny"
-	ActionWarn  PolicyAction = "warn"
+	// ActionDeny blocks the operation.
+	ActionDeny PolicyAction = "deny"
+	// ActionWarn allows the operation but logs a warning.
+	ActionWarn PolicyAction = "warn"
 )
 
 // PolicyCondition represents a condition for a policy

apps/core/src/application/services/replay.rs

@@ -162,7 +162,7 @@ impl ReplayManager {
             request
                 .projection_name
                 .as_ref()
-                .map(|n| format!(" (projection: {})", n))
+                .map(|n| format!(" (projection: {n})"))
                 .unwrap_or_default()
         );
 
@@ -319,7 +319,7 @@ impl ReplayManager {
         let replays = self.replays.read();
 
         let state = replays.iter().find(|r| r.id == replay_id).ok_or_else(|| {
-            AllSourceError::ValidationError(format!("Replay not found: {}", replay_id))
+            AllSourceError::ValidationError(format!("Replay not found: {replay_id}"))
         })?;
 
         let processed = state.processed_events.load(Ordering::Relaxed);
@@ -362,7 +362,7 @@ impl ReplayManager {
         let replays = self.replays.read();
 
         let state = replays.iter().find(|r| r.id == replay_id).ok_or_else(|| {
-            AllSourceError::ValidationError(format!("Replay not found: {}", replay_id))
+            AllSourceError::ValidationError(format!("Replay not found: {replay_id}"))
         })?;
 
         let status = *state.status.read();
@@ -423,7 +423,7 @@ impl ReplayManager {
             .iter()
             .position(|r| r.id == replay_id)
             .ok_or_else(|| {
-                AllSourceError::ValidationError(format!("Replay not found: {}", replay_id))
+                AllSourceError::ValidationError(format!("Replay not found: {replay_id}"))
             })?;
 
         let status = *replays[idx].status.read();

apps/core/src/application/services/schema.rs

@@ -247,15 +247,15 @@ impl SchemaRegistry {
         let schemas = self.schemas.read();
 
         let subject_schemas = schemas.get(subject).ok_or_else(|| {
-            AllSourceError::ValidationError(format!("Subject not found: {}", subject))
+            AllSourceError::ValidationError(format!("Subject not found: {subject}"))
         })?;
 
         let version = match version {
             Some(v) => v,
             None => {
                 let latest_versions = self.latest_versions.read();
                 *latest_versions.get(subject).ok_or_else(|| {
-                    AllSourceError::ValidationError(format!("No versions for subject: {}", subject))
+                    AllSourceError::ValidationError(format!("No versions for subject: {subject}"))
                 })?
             }
         };
@@ -273,7 +273,7 @@ impl SchemaRegistry {
         let schemas = self.schemas.read();
 
         let subject_schemas = schemas.get(subject).ok_or_else(|| {
-            AllSourceError::ValidationError(format!("Subject not found: {}", subject))
+            AllSourceError::ValidationError(format!("Subject not found: {subject}"))
         })?;
 
         let mut versions: Vec<u32> = subject_schemas.keys().copied().collect();
@@ -326,7 +326,7 @@ impl SchemaRegistry {
                 for req_field in required {
                     if let Some(field_name) = req_field.as_str() {
                         if !obj.contains_key(field_name) {
-                            errors.push(format!("Missing required field: {}", field_name));
+                            errors.push(format!("Missing required field: {field_name}"));
                         }
                     }
                 }
@@ -361,7 +361,7 @@ impl SchemaRegistry {
                 if let Some(prop_schema) = properties.get(key) {
                     let nested_errors = self.validate_json(value, prop_schema);
                     for err in nested_errors {
-                        errors.push(format!("{}.{}", key, err));
+                        errors.push(format!("{key}.{err}"));
                     }
                 }
             }

apps/core/src/domain/entities/audit_event.rs

@@ -210,9 +210,9 @@ impl Actor {
     /// Get actor identifier for logging
     pub fn identifier(&self) -> String {
         match self {
-            Self::User { user_id, .. } => format!("user:{}", user_id),
-            Self::ApiKey { key_id, .. } => format!("api_key:{}", key_id),
-            Self::System { component } => format!("system:{}", component),
+            Self::User { user_id, .. } => format!("user:{user_id}"),
+            Self::ApiKey { key_id, .. } => format!("api_key:{key_id}"),
+            Self::System { component } => format!("system:{component}"),
         }
     }
 }
@@ -389,14 +389,14 @@ impl AuditEvent {
     /// Get a human-readable description
     pub fn description(&self) -> String {
         let actor_desc = match &self.actor {
-            Actor::User { username, .. } => format!("User '{}'", username),
-            Actor::ApiKey { key_name, .. } => format!("API Key '{}'", key_name),
-            Actor::System { component } => format!("System component '{}'", component),
+            Actor::User { username, .. } => format!("User '{username}'"),
+            Actor::ApiKey { key_name, .. } => format!("API Key '{key_name}'"),
+            Actor::System { component } => format!("System component '{component}'"),
         };
 
         let resource_desc =
             if let (Some(r_type), Some(r_id)) = (&self.resource_type, &self.resource_id) {
-                format!(" on {} '{}'", r_type, r_id)
+                format!(" on {r_type} '{r_id}'")
             } else {
                 String::new()
             };

apps/core/src/domain/value_objects/event_type.rs

@@ -141,7 +141,7 @@ impl EventType {
             .all(|c| c.is_lowercase() || c.is_numeric() || c == '.' || c == '_')
         {
             return Err(crate::error::AllSourceError::InvalidInput(
-                format!("Event type '{}' must be lowercase with dots/underscores. Convention: namespace.entity.action", value),
+                format!("Event type '{value}' must be lowercase with dots/underscores. Convention: namespace.entity.action"),
             ));
         }
 

apps/core/src/domain/value_objects/tenant_id.rs

@@ -89,7 +89,7 @@ impl TenantId {
             .all(|c| c.is_alphanumeric() || c == '-' || c == '_')
         {
             return Err(crate::error::AllSourceError::InvalidInput(
-                format!("Tenant ID '{}' contains invalid characters. Only alphanumeric, hyphens, and underscores allowed", value),
+                format!("Tenant ID '{value}' contains invalid characters. Only alphanumeric, hyphens, and underscores allowed"),
             ));
         }
 

apps/core/src/error.rs

@@ -77,7 +77,7 @@ impl From<crate::infrastructure::persistence::SimdJsonError> for AllSourceError
 #[cfg(feature = "postgres")]
 impl From<sqlx::Error> for AllSourceError {
     fn from(err: sqlx::Error) -> Self {
-        AllSourceError::StorageError(format!("Database error: {}", err))
+        AllSourceError::StorageError(format!("Database error: {err}"))
     }
 }
 

apps/core/src/infrastructure/cluster/request_router.rs

@@ -73,7 +73,7 @@ impl RequestRouter {
             })?;
 
         self.registry.get_node(node_id).ok_or_else(|| {
-            AllSourceError::InternalError(format!("Node {} not found in registry", node_id))
+            AllSourceError::InternalError(format!("Node {node_id} not found in registry"))
         })
     }