Failure when using openzfs port on remote server

[hxw]

• the path /sbin/zfs is hard coded on the ssh lines
• the openzfs port installs the zfs command to /usr/local/sbin/zfs
• this was detected when updating FreeNAS 11→TrueNAS 12

[allanjude]

It is actually not hard coded:

LZFS=$( which zfs )
RZFS=$LZFS

Just make sure your PATH prefers /usr/local/sbin before /sbin and it should "do the right thing"

[hxw]

For the local side:

% command -v zfs
/sbin/zfs

For remote side:

freenas:~ # command -v zfs
/usr/local/sbin/zfs

/sbin/zfs is hard coded for -O and -T options:

zxfer/zxfer

Line 1943 in 1cc89cc

LZFS="ssh $OPTARG /sbin/zfs"

zxfer/zxfer

Line 1962 in 1cc89cc

RZFS="ssh $OPTARG /sbin/zfs"

I am using -T so I think the second line is the problem. I expect a separate ssh command -v zfs is necessary to get the remote path.

[hxw]

It just occurred to me that the PATH will be setup on the remote so ssh $OPTARG zfs should always work, so no need to hard code the /sbin path in the ssh commands.