Print all tasks hostname and port

Author: Oskar Jagodzinski

.travis.yml

@@ -4,7 +4,7 @@ sudo: false
 services:
   - docker
 go:
-  - 1.8
+  - 1.12
 before_install:
   - go get github.com/mattn/goveralls
 script:

Makefile

@@ -29,8 +29,8 @@ deps:
 lint: deps lint-deps onlylint
 
 lint-deps:
-	go get -u github.com/alecthomas/gometalinter
-	gometalinter --install
+	@which golangci-lint > /dev/null || \
+	(go get -u github.com/golangci/golangci-lint/cmd/golangci-lint)
 
 release: lint test
 	GOARCH=amd64 GOOS=linux $(GO_BUILD) -o build/appcop .
@@ -45,14 +45,7 @@ pack: test lint build
 	docker build -t appcop . && mkdir -p dist && docker run -v ${PWD}/dist:/work/dist appcop
 
 onlylint: build
-	gometalinter \
-	--deadline=720s \
-	--disable=dupl \
-	--disable=gotype \
-	--disable=gas \
-	--disable=golint \
-	--enable=gofmt \
-	--vendor
+	golangci-lint run --config=golangcilinter.yaml web marathon metrics mgc score config
 
 version: deps
 	echo -n $(v) > VERSION

golangcilinter.yaml

@@ -0,0 +1,21 @@
+run:
+  aggregate: true
+  concurrency: 2
+  cyclo: 14
+  deadline: "300s"
+  skip-files:
+  - ".*_string.go"
+  - ".*_test.go"
+issues:
+  max-same-issues: 0
+linters:
+  disable-all: true
+  enable:
+    - stylecheck
+    - deadcode
+    - errcheck
+    - gocyclo
+    - goimports
+    - golint
+    - gosimple
+    - govet

marathon/app.go

@@ -42,7 +42,7 @@ func (app *App) penalize() error {
 	if app.Instances >= 1 {
 		app.Instances--
 	} else {
-		return fmt.Errorf("Unable to scale down, zero instance")
+		return fmt.Errorf("unable to scale down, zero instance")
 	}
 
 	if app.Instances == 0 {

marathon/app_test.go

@@ -252,7 +252,7 @@ var penalizeTestCases = []struct {
 		expectedApp: &App{ID: "testApp4",
 			Instances: 0,
 			Labels:    map[string]string{"APPLABEL": "true"}},
-		expectedErr: fmt.Errorf("Unable to scale down, zero instance"),
+		expectedErr: fmt.Errorf("unable to scale down, zero instance"),
 	},
 }
 

marathon/marathon.go

@@ -165,7 +165,7 @@ func (m Marathon) get(url string) ([]byte, error) {
 	if response.StatusCode != 200 {
 		metrics.Mark("marathon.get.error")
 		metrics.Mark(fmt.Sprintf("marathon.get.error.%d", response.StatusCode))
-		err = fmt.Errorf("Expected 200 but got %d for %s", response.StatusCode, response.Request.URL.Path)
+		err = fmt.Errorf("expected 200 but got %d for %s", response.StatusCode, response.Request.URL.Path)
 		m.logHTTPError(response, err)
 		return nil, err
 	}
@@ -202,7 +202,7 @@ func (m Marathon) update(url string, d []byte) ([]byte, error) {
 	if response.StatusCode != 200 {
 		metrics.Mark("marathon.put.error")
 		metrics.Mark(fmt.Sprintf("marathon.put.error.%d", response.StatusCode))
-		err = fmt.Errorf("Expected 200 but got %d for %s", response.StatusCode, response.Request.URL.Path)
+		err = fmt.Errorf("expected 200 but got %d for %s", response.StatusCode, response.Request.URL.Path)
 		m.logHTTPError(response, err)
 		return nil, err
 	}
@@ -239,7 +239,7 @@ func (m Marathon) delete(url string) ([]byte, error) {
 	if response.StatusCode != 200 {
 		metrics.Mark("marathon.delete.error")
 		metrics.Mark(fmt.Sprintf("marathon.delete.error.%d", response.StatusCode))
-		err = fmt.Errorf("Expected 200 but got %d for %s", response.StatusCode, response.Request.URL.Path)
+		err = fmt.Errorf("expected 200 but got %d for %s", response.StatusCode, response.Request.URL.Path)
 		m.logHTTPError(response, err)
 		return nil, err
 	}

marathon/marathon_stub.go

@@ -34,7 +34,7 @@ type ScaleCounter struct {
 // AppsGet get stubbed apps
 func (m MStub) AppsGet() ([]*App, error) {
 	if m.AppsGetFail {
-		return nil, errors.New("Unable to get applications from marathon")
+		return nil, errors.New("unable to get applications from marathon")
 	}
 	return m.Apps, nil
 }
@@ -79,7 +79,7 @@ func (m MStub) LeaderGet() (string, error) {
 // AppScaleDown by one instance
 func (m MStub) AppScaleDown(app *App) error {
 	if m.AppScaleDownFail {
-		return errors.New("Unable to scale down")
+		return errors.New("unable to scale down")
 	}
 	m.ScaleCounter.Counter = 1
 	return nil
@@ -88,12 +88,12 @@ func (m MStub) AppScaleDown(app *App) error {
 // AppDelete application by provided AppID
 func (m MStub) AppDelete(appID AppID) error {
 	if m.AppDelFail {
-		return errors.New("Unable to delete app")
+		return errors.New("unable to delete app")
 	}
 	if m.AppDelHalfFail {
 		if m.FailCounter.Counter%2 == 0 {
 			m.FailCounter.Counter++
-			return errors.New("Unable to delete app")
+			return errors.New("unable to delete app")
 		}
 		m.FailCounter.Counter++
 	}
@@ -103,7 +103,7 @@ func (m MStub) AppDelete(appID AppID) error {
 // GroupDelete by provided GroupID
 func (m MStub) GroupDelete(groupID GroupID) error {
 	if m.GroupDelFail {
-		return errors.New("Unable to delete group")
+		return errors.New("unable to delete group")
 	}
 	return nil
 }

metrics/metrics.go

@@ -12,12 +12,14 @@ import (
 	"time"
 
 	log "github.com/Sirupsen/logrus"
-	"github.com/cyberdelia/go-metrics-graphite"
+	graphite "github.com/cyberdelia/go-metrics-graphite"
 	"github.com/rcrowley/go-metrics"
 )
 
 const (
-	PathSeparator   = "/"
+	// PathSeparator is separator of groups in app name
+	PathSeparator = "/"
+	// MetricSeparator is separator of groups in metrics system
 	MetricSeparator = "."
 )
 
@@ -28,6 +30,7 @@ var (
 	appSubPrefix    string
 )
 
+// FilterOutEmptyStrings filters empty strings
 func FilterOutEmptyStrings(data []string) []string {
 	var parts []string
 	for _, part := range data {
@@ -57,7 +60,7 @@ func Mark(name string) {
 	meter.Mark(1)
 }
 
-// Mark or register Meter on graphite
+// MarkApp marks or register Meter on graphite
 func MarkApp(name string) {
 	meter := metrics.GetOrRegisterMeter(
 		appMetric(name),
@@ -124,7 +127,7 @@ func Init(cfg Config) error {
 		log.Infof("Metrics disabled")
 		return nil
 	default:
-		return fmt.Errorf("Invalid metrics target %s", cfg.Target)
+		return fmt.Errorf("invalid metrics target %s", cfg.Target)
 	}
 }
 

score/score.go

@@ -156,7 +156,7 @@ func (s *Scorer) EvaluateApps() {
 	if err != nil && i == 0 {
 		log.WithError(err).Error("Failed to evaluate")
 	}
-	log.Debug("%d apps qualified for penalty", i)
+	log.Debugf("%d apps qualified for penalty", i)
 }
 
 func (s *Scorer) evaluateApps() (int, error) {
@@ -221,7 +221,7 @@ func (s *Scorer) scaleDown(appID marathon.AppID) error {
 	if app.HasImmunity() {
 		// returning error up makes sure rate limiting works,
 		// otherwise AppCop could loop over immune apps
-		return fmt.Errorf("App: %s has immunity", app.ID)
+		return fmt.Errorf("app: %s has immunity", app.ID)
 	}
 
 	err = s.service.AppScaleDown(app)

web/event.go

@@ -92,7 +92,7 @@ func parseEvent(reader *bufio.Reader) (Event, error) {
 		if err == io.EOF {
 			dispatch = e.parseLine(line)
 			if !dispatch {
-				return e, errors.New("Unexpected EOF")
+				return e, errors.New("unexpected EOF")
 			}
 			return e, io.EOF
 		}