I've half-added PowerShell support in #37 but there is a sticky problem: PowerShell strings are all Unicode, and they cannot contain arbitrary bytes. The API of shell-quote doesn't accommodate this; it expects that all shells have a way to represent arbitrary bytes in strings. I could write the PowerShell support such that it panics when encountering unencodable bytes, but this feels like pushing a square peg through a round hole. PowerShell is simply not like the UNIX shells that this crate has so far supported.

Notes

Arbitrary binary data can be represented in PowerShell as a byte array:

$bytes = [byte[]] (0x48, 0x65, 0x6C, 0x6C, 0x6F)  # "Hello"

or:

[byte[]] $bytes = 0x48, 0x65, 0x6C, 0x6C, 0x6F  # "Hello"

but they cannot be used in the same places as a string. For example, compare writing to stdout with a string and with a byte array:

[Console]::Write("Hello, world!")  # String
[Console]::OpenStandardOutput().Write($bytes, 0, $bytes.Length)  # Byte array

As far as I know there's no way to mix these types, i.e. the following can't work in a natural way:

let mut script = String::new();
script.push_quoted(Pwsh, "foo");
script.push_quoted(Pwsh, &[0u8]);
script.push_quoted(Pwsh, "bar");

Well, it could work if the crate were to always output byte array syntax, but I think that would not be useful to most people 🤷

Essentially, a Quotable::Bytes cannot be reliably quoted into a PowerShell string, and fixing that means changing the API of this whole crate. I'm not necessarily against that – the API is a bit convoluted and could probably do with some improvement – but it's unlikely that I'll get to it at any point soon.

Add support for PowerShell #32

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions