Merge pull request #89 from allenhutchison/fix/remove-subscribed-only-parameter

fix: remove obsolete subscribed_only parameter from list_podcasts calls

Author: allenhutchison

scripts/backfill_last_new_episode.py

@@ -24,7 +24,7 @@ def backfill_last_new_episode():
     print("Backfilling last_new_episode for podcasts...")
 
     # Get all podcasts using public API
-    podcasts = repo.list_podcasts(subscribed_only=False)
+    podcasts = repo.list_podcasts()
 
     updated_count = 0
     skipped_count = 0

scripts/export_sqlite_to_sql.py

@@ -53,10 +53,13 @@ def export_table_data(cursor, table_name, output_file):
         table_name: Name of table to export
         output_file: File object to write INSERT statements to
     """
+    # Columns to exclude (removed from schema)
+    excluded_columns = {'is_subscribed'}
+
     # Boolean columns (SQLite stores as INTEGER 0/1, PostgreSQL needs true/false)
     # These are known boolean columns in our schema
     boolean_columns = {
-        'is_subscribed', 'itunes_explicit', 'is_active', 'is_admin',
+        'itunes_explicit', 'is_active', 'is_admin',
         'email_digest_enabled', 'smtp_use_tls'
     }
 
@@ -73,16 +76,19 @@ def export_table_data(cursor, table_name, output_file):
         output_file.write(f"-- No data in {table_name}\n")
         return
 
-    # Get column names from cursor description
-    columns = [desc[0] for desc in cursor.description]
+    # Get column names from cursor description, excluding removed columns
+    all_columns = [desc[0] for desc in cursor.description]
+    columns = [col for col in all_columns if col not in excluded_columns]
+    keep_indices = [i for i, col in enumerate(all_columns) if col not in excluded_columns]
     col_list = ", ".join(columns)
 
     output_file.write(f"-- Inserting {len(rows)} rows into {table_name}\n")
 
     for row in rows:
         values = []
-        for idx, val in enumerate(row):
-            col_name = columns[idx]
+        for idx in keep_indices:
+            col_name = all_columns[idx]
+            val = row[idx]
             # Handle JSON columns - keep as-is, just wrap in single quotes
             if col_name in json_columns:
                 if val is None:

scripts/migrate_sqlite_to_postgres.py

@@ -59,14 +59,25 @@ def migrate_podcasts(sqlite_conn, pg_conn, dry_run=False):
     """Migrate podcasts table."""
     sqlite_cur = sqlite_conn.cursor()
     sqlite_cur.execute("SELECT * FROM podcasts")
-    columns = [description[0] for description in sqlite_cur.description]
+    all_columns = [description[0] for description in sqlite_cur.description]
     rows = sqlite_cur.fetchall()
 
     logger.info(f"Found {len(rows)} podcasts to migrate")
 
     if dry_run or not rows:
         return len(rows)
 
+    # Columns to exclude (removed from schema)
+    excluded_columns = {'is_subscribed'}
+
+    # Filter columns and get indices to keep
+    columns = []
+    keep_indices = []
+    for i, col in enumerate(all_columns):
+        if col not in excluded_columns:
+            columns.append(col)
+            keep_indices.append(i)
+
     pg_cur = pg_conn.cursor()
 
     # Build INSERT statement
@@ -75,11 +86,12 @@ def migrate_podcasts(sqlite_conn, pg_conn, dry_run=False):
     insert_sql = f'INSERT INTO podcasts ({columns_str}) VALUES ({placeholders}) ON CONFLICT (id) DO NOTHING'
 
     for row in rows:
-        # Convert SQLite booleans (0/1) to Python booleans
+        # Convert SQLite booleans (0/1) to Python booleans, excluding removed columns
         converted_row = []
-        for i, val in enumerate(row):
-            col_name = columns[i]
-            if col_name in ('is_subscribed', 'itunes_explicit') and val is not None:
+        for i in keep_indices:
+            col_name = all_columns[i]
+            val = row[i]
+            if col_name == 'itunes_explicit' and val is not None:
                 converted_row.append(bool(val))
             else:
                 converted_row.append(val)

src/db/repository.py

@@ -814,7 +814,7 @@ def get_podcast_stats(self, podcast_id: str) -> dict[str, Any]:
 
         Returns:
             stats (Dict[str, Any]): A dictionary containing per-podcast statistics and counts, typically including:
-                - podcast (dict): A short snapshot of the podcast (e.g., `id`, `title`, `feed_url`, `is_subscribed`).
+                - podcast (dict): A short snapshot of the podcast (e.g., `id`, `title`, `feed_url`).
                 - total_episodes (int): Total number of episodes for the podcast.
                 - by_download_status (dict): Counts keyed by download status (e.g., `pending`, `in_progress`, `completed`, `failed`).
                 - by_transcript_status (dict): Counts keyed by transcript status (e.g., `pending`, `in_progress`, `completed`, `failed`).

src/web/app.py

@@ -689,7 +689,6 @@ async def list_all_podcasts(
     user_id = current_user["sub"]
     all_podcasts = await asyncio.to_thread(
         _repository.list_podcasts,
-        subscribed_only=False,
         sort_by=sort_by,
         sort_order=sort_order
     )

tests/test_web_app.py

@@ -347,47 +347,6 @@ def test_generate_agentic_response_is_async(self):
         assert inspect.isasyncgenfunction(generate_agentic_response)
 
 
-class TestChatEndpointWithSubscribedOnly:
-    """Tests for chat endpoint with subscribed_only parameter."""
-
-    def test_chat_endpoint_accepts_subscribed_only_in_request(self, client):
-        """Test that chat endpoint accepts subscribed_only in request body."""
-        # Note: Will return 401 without auth, but validates request structure
-        response = client.post(
-            "/api/chat",
-            json={
-                "query": "What are the latest episodes?",
-                "subscribed_only": True
-            }
-        )
-        # Should fail auth, not request validation
-        assert response.status_code == 401
-
-    def test_chat_endpoint_accepts_subscribed_only_false(self, client):
-        """Test that chat endpoint accepts subscribed_only=False."""
-        response = client.post(
-            "/api/chat",
-            json={
-                "query": "Search all podcasts",
-                "subscribed_only": False
-            }
-        )
-        assert response.status_code == 401  # Auth failure, not validation
-
-    def test_chat_endpoint_validates_request_with_all_filters(self, client):
-        """Test that chat endpoint accepts multiple filter parameters."""
-        response = client.post(
-            "/api/chat",
-            json={
-                "query": "Test query",
-                "podcast_id": "123e4567-e89b-12d3-a456-426614174000",
-                "subscribed_only": True
-            }
-        )
-        # Should fail auth before processing filters
-        assert response.status_code == 401
-
-
 class TestValidatePodcastId:
     """Tests for _validate_podcast_id function."""