Uncaught Error: Call to undefined method WP_Term_Query::is_search() - While Activating Terms Feature of VIP Enterprise Search

[waqasmehmud]

Description of the bug

While Activating Terms Feature of VIP Enterprise Search we are stuck into this issue. details of error below.

Possible to have a fix of this issue soon?

Uncaught Error: Call to undefined method WP_Term_Query::is_search()
in /var/www/wp-content/plugins/elasticsearch-extensions/lib/adapters/class-vip-enterprise-search.php on line 125

Call stack:

Elasticsearch_Extensions\Adapters\VIP_Enterprise_Search::filter__ep_elasticpress_enabled(false, WP_Term_Query)
wp-includes/class-wp-hook.php:324
WP_Hook::apply_filters(false, array)
wp-includes/plugin.php:205
apply_filters('ep_elasticpress_enabled', false, WP_Term_Query)
wp-content/mu-plugins/search/elasticpress/includes/classes/Indexable.php:668
ElasticPress\Indexable::elasticpress_enabled(WP_Term_Query)
wp-content/mu-plugins/search/elasticpress/includes/classes/Indexable/Term/QueryIntegration.php:66
ElasticPress\I\T\QueryIntegration::action_pre_get_terms(WP_Term_Query)
wp-includes/class-wp-hook.php:324
WP_Hook::apply_filters('', array)
wp-includes/class-wp-hook.php:348
WP_Hook::do_action(array)
wp-includes/plugin.php:565
do_action_ref_array('pre_get_terms', array)
wp-includes/class-wp-term-query.php:365
WP_Term_Query::get_terms()
wp-includes/class-wp-term-query.php:308
WP_Term_Query::query(array)
wp-includes/class-wp-tax-query.php:644
WP_Tax_Query::transform_query(array, 'term_taxonomy_id')
wp-includes/class-wp-tax-query.php:581
WP_Tax_Query::clean_query(array)
wp-includes/class-wp-tax-query.php:395
WP_Tax_Query::get_sql_for_clause(array, array)
wp-includes/class-wp-tax-query.php:325
WP_Tax_Query::get_sql_for_query(array)
wp-includes/class-wp-tax-query.php:275
WP_Tax_Query::get_sql_clauses()
wp-includes/class-wp-tax-query.php:251
WP_Tax_Query::get_sql('wp_2_posts', 'ID')
wp-includes/class-wp-query.php:2298
WP_Query::get_posts()
wp-includes/class-wp-query.php:3949
WP_Query::query(array)
wp-includes/class-wp-theme-json-resolver.php:517
WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles(WP_Theme)
wp-includes/class-wp-theme-json-resolver.php:557
WP_Theme_JSON_Resolver::get_user_data()
wp-includes/class-wp-theme-json-resolver.php:673
WP_Theme_JSON_Resolver::get_merged_data('custom')
wp-includes/global-styles-and-settings.php:80
wp_get_global_settings()
wp-includes/fonts/class-wp-font-face-resolver.php:29
WP_Font_Face_Resolver::get_fonts_from_theme_json()
wp-includes/fonts.php:46
wp_print_font_faces('')
wp-includes/class-wp-hook.php:324
WP_Hook::apply_filters(array, array)
wp-includes/class-wp-hook.php:348
WP_Hook::do_action(array)
wp-includes/plugin.php:517
do_action('admin_print_styles')
wp-admin/admin-header.php:137
require_once('/var/www/wp-admin/admin-header.php')
wp-admin/index.php:137

Steps To Reproduce

1. Go to any wp vip instance where elasticsearch-extensions plugin in activated and vip enterpise search is activated
2. Try activating terms feature of vip enterpise search via vip CLI
3. Visit the site admin panel or frontend or view error logs

Additional Information

No response

[kevinfodness]

This is due to a mismatch between the documented types in the ep_elasticpress_enabled hook and the actual types. The documentation says that $query is a WP_Query object but it could also be a WP_User_Query or WP_Term_Query object.

The code in this plugin needs to be updated to perform a defensive check, since the is_search method doesn't exist on WP_User_Query or WP_Term_Query.