Adding Deprecated attribute to some already deprecated methods (#813)

* Adding Deprecated attribute to some already deprecated methods

* Suppress the deprecation in test_post_create_with_thumbnail for >= 12

* CHANGELOG

Author: srtfisher

CHANGELOG.md

@@ -36,6 +36,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   cleaning the global scope between tests.
 
 
+### Changed
+
+- Added `Deprecation` attribute to some already-deprecated methods in the
+  framework to better indicate their deprecation status.
+
 ## v1.12.4
 
 ### Fixed

src/mantle/console/concerns/trait-interacts-with-io.php

@@ -291,6 +291,7 @@ public function info( $string, $verbosity = null ): void {
 	 *
 	 * @param string $message Message to log.
 	 */
+	#[\Deprecated( 'Use `line()` instead.' )]
 	public function log( string $message ): void {
 		$this->line( $message );
 	}

src/mantle/container/class-container.php

@@ -1114,6 +1114,7 @@ public function flush(): void {
 	 *
 	 * @deprecated Use `get_instance()` instead.
 	 */
+	#[\Deprecated( 'Use get_instance() instead.' )]
 	public static function getInstance(): static {
 		return static::get_instance();
 	}

src/mantle/database/factory/class-attachment-factory.php

@@ -163,6 +163,7 @@ public function with_real_thumbnail( callable|string|null $file = null, int $wid
 	 * @param int   $legacy_parent The parent post ID.
 	 * @param array $legacy_args The arguments.
 	 */
+	#[\Deprecated( 'Use create() or create_and_get() instead.' )]
 	public function create_object( $args, $legacy_parent = 0, $legacy_args = [] ): int|null {
 		// Backward compatibility for legacy argument format.
 		if ( is_string( $args ) ) { // @phpstan-ignore-line
@@ -185,6 +186,7 @@ public function create_object( $args, $legacy_parent = 0, $legacy_args = [] ): i
 	 *
 	 * @return int|\WP_Error The attachment ID on success. The value 0 or WP_Error on failure.
 	 */
+	#[\Deprecated( 'Use the `with_image()` method instead.' )]
 	public function create_upload_object( ?string $file, int $parent = 0 ): int|\WP_Error {
 		return $this->with_image( $file, $parent )->create();
 	}

src/mantle/database/factory/class-factory.php

@@ -116,6 +116,7 @@ public function create( array $args = [] ): mixed {
 	 *
 	 * @param array $args The arguments.
 	 */
+	#[\Deprecated( 'Use create() or create_and_get() instead.' )]
 	public function create_object( array $args ): int|null {
 		return $this->create( $args );
 	}

src/mantle/database/factory/class-post-factory.php

@@ -283,6 +283,7 @@ public function definition(): array {
 	 *
 	 * @param array $args The arguments.
 	 */
+	#[\Deprecated( 'Use the `with_thumbnail()` method instead.' )]
 	public function create_with_thumbnail( array $args = [] ): ?int {
 		return $this->with_thumbnail()->create( $args );
 	}

src/mantle/framework/helpers.php

@@ -5,8 +5,6 @@
  * Intentionally not Namespaced to allow for root-level access to
  * framework methods.
  *
- * @deprecated Deprecated in favor of package-specific helpers.
- *
  * @package Mantle
  *
  * @phpcs:disable WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound, Squiz.Commenting.FunctionComment

src/mantle/http-client/class-http-client.php

@@ -16,6 +16,7 @@ class Http_Client {
 	/**
 	 * Create an instance of the Http Client
 	 */
+	#[\Deprecated( 'Use ' . \Mantle\Http_Client\Factory::class . '::create() instead.' )]
 	public static function create(): \Mantle\Http_Client\Factory {
 		return new Factory();
 	}

src/mantle/http/autoload.php

@@ -105,6 +105,7 @@ function view( ?string $slug = null, array|string|null $name = null, array $vari
 	 * @param array|string $name View name, optional. Supports passing variables in if
 	 *                           $variables is not used.
 	 */
+	#[\Deprecated( 'Use view() instead.' )]
 	function render_view( ...$args ): void {
 		echo view( ...$args ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 	}

src/mantle/http/class-uploaded-file.php

@@ -116,7 +116,7 @@ public function store_as_attachment( string $path = '/', ?string $name = null, $
 		}
 
 		$disk_name = $options['disk'] ?? null;
-		$disk      = Container::getInstance()->make( Filesystem_Manager::class )->drive( $disk_name );
+		$disk      = Container::get_instance()->make( Filesystem_Manager::class )->drive( $disk_name );
 
 		// Create the attachment for the file.
 		$attachment = Attachment::create(