Fix issue with model::for() not actually creating a post/term for the post type/taxonomy (#637)

* Failing test

* Switch to class created with eval

* Remove unused classes

* CHANGELOG typo

* Ignore unset.possiblyHookedProperty

Author: srtfisher

CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## v1.5.4 - 2025-03-06
+
+### Fixed
+
+- Fix the `Post::for()`/`Term::for()` methods to properly set the post
+  type/taxonomy for the model when creating a new instance. Previously, the
+  model would always be created with the default post type/taxonomy.
+
 ## v1.5.3 - 2025-03-04
 
 ### Changed
@@ -18,7 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-- Fixed bad configuration file caling `env()` vs `environment()`.
+- Fixed bad configuration file calling `env()` vs `environment()`.
 
 ## v1.5.1 - 2025-02-06
 

phpstan.neon

@@ -18,6 +18,8 @@ parameters:
 			identifier: require.fileNotFound
 		-
 			identifier: requireOnce.fileNotFound
+		-
+			identifier: unset.possiblyHookedProperty
 		-
 			identifier: function.alreadyNarrowedType
 			paths:

src/mantle/database/model/class-post.php

@@ -8,15 +8,15 @@
 namespace Mantle\Database\Model;
 
 use Carbon\Carbon;
-use DateTime;
 use DateTimeInterface;
 use Mantle\Contracts;
 use Mantle\Database\Model\Relations\Belongs_To;
-use Mantle\Database\Model\Relations\Has_One;
 use Mantle\Database\Query\Builder;
 use Mantle\Database\Query\Post_Query_Builder;
 use Mantle\Support\Helpers;
 
+use function Mantle\Support\Helpers\stringable;
+
 /**
  * Post Model
  *
@@ -182,43 +182,28 @@ public static function find( $object ) {
 	 *
 	 * @param string $post_type Post type to create the model for.
 	 */
-	public static function for( string $post_type ): self {
-		$instance = new class() extends Post {
-			/**
-			 * Constructor.
-			 */
-			public function __construct() {}
-
-			/**
-			 * Post type for the model.
-			 */
-			public static string $for_object_name = '';
-
-			/**
-			 * Retrieve the object name.
-			 */
-			public static function get_object_name(): string {
-				return self::$for_object_name;
-			}
-
-			/**
-			 * Boot the model if it has not been booted.
-			 *
-			 * Prevent booting the model unless the object name is set.
-			 */
-			public static function boot_if_not_booted(): void {
-				if ( empty( self::$for_object_name ) ) {
-					return;
-				}
-
-				parent::boot_if_not_booted();
-			}
-		};
+	public static function for( string $post_type ): Post {
+		$post_type  = sanitize_key( $post_type );
+		$class_name = 'Post_' . stringable( $post_type )->studly()->replace( '-', '_' )->__toString();
+		$namespace  = __NAMESPACE__;
+
+		if ( ! class_exists( "{$namespace}\\{$class_name}" ) ) {
+			// Similar to how Mockery creates classes on the fly for testing. No other
+			// solution was found to create a class on the fly.
+			eval( // phpcs:ignore Squiz.PHP.Eval.Discouraged
+				<<<PHP
+namespace {$namespace} {
+	class {$class_name} extends Post {
+		public static \$object_name = '{$post_type}';
+	}
+}
+PHP
+			);
+		}
 
-		$instance::$for_object_name = $post_type;
-		$instance::boot_if_not_booted();
+		$full_class_name = "{$namespace}\\{$class_name}";
 
-		return $instance;
+		return new $full_class_name();
 	}
 
 	/**

src/mantle/database/model/class-term.php

@@ -13,6 +13,8 @@
 use Mantle\Database\Query\Term_Query_Builder;
 use Mantle\Support\Helpers;
 
+use function Mantle\Support\Helpers\stringable;
+
 /**
  * Term Model
  *
@@ -114,30 +116,27 @@ public static function find( $object ) {
 	 * @param string $taxonomy Taxonomy to create the model for.
 	 */
 	public static function for( string $taxonomy ): self {
-		$instance = new class() extends Term {
-			/**
-			 * Constructor.
-			 */
-			public function __construct() {}
-
-			/**
-			 * Boot the model if it has not been booted.
-			 *
-			 * Prevent booting the model unless the object name is set.
-			 */
-			public static function boot_if_not_booted(): void {
-				if ( empty( self::$object_name ) ) {
-					return;
-				}
-
-				parent::boot_if_not_booted();
-			}
-		};
-
-		$instance::$object_name = $taxonomy;
-		$instance::boot_if_not_booted();
-
-		return $instance;
+		$taxonomy   = sanitize_key( $taxonomy );
+		$class_name = 'Term_' . stringable( $taxonomy )->studly()->replace( '-', '_' )->__toString();
+		$namespace  = __NAMESPACE__;
+
+		if ( ! class_exists( "{$namespace}\\{$class_name}" ) ) {
+			// Similar to how Mockery creates classes on the fly for testing. No other
+			// solution was found to create a class on the fly.
+			eval( // phpcs:ignore Squiz.PHP.Eval.Discouraged
+				<<<PHP
+namespace {$namespace} {
+	class {$class_name} extends Term {
+		public static \$object_name = '{$taxonomy}';
+	}
+}
+PHP
+			);
+		}
+
+		$full_class_name = "{$namespace}\\{$class_name}";
+
+		return new $full_class_name();
 	}
 
 	/**

tests/Database/Model/PostObjectTest.php

@@ -253,13 +253,27 @@ public function test_dynamic_model_instance() {
 
 		$this->assertEquals( 'foo_post_type', get_post_type( $post_id ) );
 
+		$dynamic_model = Post::for( 'foo_post_type' );
+
 		$this->assertEmpty( Post::find( $post_id ) );
-		$this->assertInstanceOf( Post::class, Post::for( 'foo_post_type' ) );
-		$this->assertEquals( $post_id, Post::for( 'foo_post_type' )->find( $post_id )->id() );
+		$this->assertInstanceOf( Post::class, $dynamic_model );
+		$this->assertEquals( $post_id, $dynamic_model->find( $post_id )->id() );
 		$this->assertEquals(
 			$post_two,
-			Post::for( 'foo_post_type' )->where( 'title', 'Post Two' )->first()->id(),
+			$dynamic_model->where( 'title', 'Post Two' )->first()->id(),
 		);
+
+		// Test creating a post via the dynamic model.
+		$new_post = $dynamic_model->create(
+			[
+				'post_title' => 'New Post',
+			]
+		);
+
+		$post = get_post( $new_post->id() );
+
+		$this->assertEquals( 'foo_post_type', $post->post_type );
+		$this->assertEquals( 'New Post', $post->post_title );
 	}
 
 	public function test_query_builder() {