Fix QM collector typing issue (#868)

Author: srtfisher

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## v1.19.1
+
+### Fixed
+
+- Fixed potential issue with bad typing on the Query Monitor package.
+
 ## v1.19.0
 
 - Fix issue introduced in v1.18.1 with packages being moved to `require-dev`.

phpstan.neon

@@ -51,8 +51,6 @@ parameters:
 		- "#ReflectionClass does not specify its types#"
 		- "#ReflectionAttribute does not specify its types#"
 		- "#@return is not subtype of template type TKey#"
-		- "#WP_REST_Request does not specify its types#"
-		- "#WP_REST_Request but does not specify its types#"
 		- "#query of method wpdb::prepare#"
 		-
 			identifier: method.childReturnType

src/mantle/query-monitor/collector/class-remote-request-collector.php

@@ -275,21 +275,28 @@ public function process(): void {
 		foreach ( $this->requests as $key => $request ) {
 			// Provide a timeout response if none exists).
 			if ( ! isset( $this->responses[ $key ] ) ) {
-				$response = [
+				$this->responses[ $key ] = [
 					'args'     => $request['args'],
 					'response' => new WP_Error(
 						'http_request_timed_out',
 						__( 'The HTTP request did not receive a response before the timeout period expired.', 'mantle' ),
 					),
-					'stop'     => floatval( $request['start'] + $response['args']['timeout'] ),
+					'stop'     => floatval( $request['start'] + ( $request['args']['timeout'] ?? 0 ) ),
 					'url'      => $request['url'],
 				];
 			}
 
 			// Convert the response to a Http Client Response instance.
-			$response = $this->responses[ $key ]['response'] instanceof Response
-				? $this->responses[ $key ]['response']
-				: Response::create( $this->responses[ $key ]['response'] );
+			$response = match ( true ) {
+				$this->responses[ $key ]['response'] instanceof Response => $this->responses[ $key ]['response'],
+				is_array( $this->responses[ $key ]['response'] ) => Response::create( $this->responses[ $key ]['response'] ),
+				is_wp_error( $this->responses[ $key ]['response'] ) => Response::create( $this->responses[ $key ]['response'] ),
+				default => null,
+			};
+
+			if ( ! $response instanceof Response ) {
+				continue;
+			}
 
 			$this->data->requests[ $key ] = [
 				'args'           => $request['args'],