Run the model with top oil temperature as an input

[TorbenFricke]

We'd like to run the model with the top oil temperature as an input. As far as I could tell, the implementation does not allow for that in a straight forward way.

Here is how I propose to implement that feature:

• Add an optional parameter to InputProfile named top_oil_temperature_profile.
• When executing model.run(), the top_oil_temperature_profile is used in place of the ambient_temperature_profile if it was provided. If the top oil temperature profile was not provided, the ambient temperature is used instead (current behavior).
• Add an optional parameter to the run method to force the use of the ambient temperature profile instead: model.run(force_use_ambient_temperature=False)

This way the API would remain compatible with the current implementation but would allow for easy switching between running with top oil and ambient temperatures.

Let me know what you think about this implementation idea or if you'd prefer to go another route. I am happy to implement that feature and create a PR.

[Harm1995]

Thanks for your input! This feature isn’t implemented yet, but it’s something we’ve discussed internally as well. If I understand correctly, you’d like to calculate the hotspot temperature using a measured top-oil temperature as input to the model. That would be a valuable addition, and it would be really great if you would implement this!

Regarding your approach: since the ambient temperature is used to calculate the top-oil temperature, simply replacing the ambient temperature with a measured top-oil value wouldn’t produce the intended result. However, if you set top_oil_temp_rise to 0 and use your measured top-oil temperature in place of the ambient temperature, the model’s calculated top-oil temperature would match your input. Is this what you had in mind?

Let me know if you’d like to proceed with this approach!

[TorbenFricke]

Sounds good! I have carved out som time to day to get to implementing.

[TorbenFricke]

I've implemented the feature basically as discussed and added a test case for running the model with a top oil temperature. Let me know if there are any questions, issues or if you'd like changes to better fit with the chosen paradigms for the codebase!

#63

[anna-van-velsen]

Hi Torben,
Thank you for your input. We marked your PR as approved so you can merge the PR 👍

[TorbenFricke]

I seem to have insufficient permissions to merge the PR. Feel free to merge the PR for me. I'll be on vacation starting tomorrow and be back on the 25th of August.

Best and until then
Torben