Skip to content

Commit 1163566

Browse files
committed
Add <atomic> include and fix OpenMP shared directive
Include the <atomic> header where needed to ensure proper functionality. Update OpenMP parallel region directives to explicitly declare the shared variable `counter` to avoid potential issues.
1 parent 76dd44a commit 1163566

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

tasks/example/all/src/ops_all.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
#include "example/all/include/ops_all.hpp"
22

33
#include <mpi.h>
4-
54
#include <cmath>
65
#include <cstddef>
76
#include <functional>
87
#include <thread>
98
#include <vector>
10-
9+
#include <atomic>
1110
#include "core/util/include/util.hpp"
1211
#include "oneapi/tbb/parallel_for.h"
1312

@@ -44,7 +43,7 @@ bool NesterovATestTaskALL::RunImpl() {
4443
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
4544
if (rank == 0) {
4645
std::atomic<int> counter(0);
47-
#pragma omp parallel default(none)
46+
#pragma omp parallel default(none) shared(counter)
4847
{
4948
counter++;
5049
}

tasks/example/omp/src/ops_omp.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include <cmath>
44
#include <cstddef>
55
#include <vector>
6+
#include <atomic>
67

78
namespace nesterov_a_test_task {
89

@@ -34,7 +35,7 @@ bool NesterovATestTaskOMP::RunImpl() {
3435
GetOutput() *= num_threads;
3536

3637
std::atomic<int> counter(0);
37-
#pragma omp parallel default(none)
38+
#pragma omp parallel default(none) shared(counter)
3839
{
3940
counter++;
4041
}

tasks/example/stl/src/ops_stl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#include "example/stl/include/ops_stl.hpp"
2-
2+
#include <atomic>
33
#include <cmath>
44
#include <cstddef>
55
#include <functional>

tasks/example/tbb/src/ops_tbb.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#include <core/util/include/util.hpp>
77
#include <cstddef>
88
#include <vector>
9-
9+
#include <atomic>
1010
#include "oneapi/tbb/parallel_for.h"
1111

1212
namespace nesterov_a_test_task {

0 commit comments

Comments
 (0)