Skip to content

Commit aedafb7

Browse files
committed
Refactor util.hpp and perf_tests.cpp:
- Simplify `NOLINT` macros in `util.hpp` by removing redundant `NOLINTBEGIN` and `NOLINTEND` comments. - Replace `nlohmann::json` with `ppc::util::InitJSONPtr` in `perf_tests.cpp` for consistency. - Remove unused JSON include in `perf_tests.cpp`.
1 parent b01a156 commit aedafb7

File tree

2 files changed

+15
-33
lines changed

2 files changed

+15
-33
lines changed

modules/core/performance/tests/perf_tests.cpp

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "core/performance/tests/test_task.hpp"
1515
#include "core/task/include/task.hpp"
1616
#include "core/util/include/util.hpp"
17-
#include "nlohmann/json.hpp"
1817

1918
TEST(perf_tests, check_perf_pipeline) {
2019
std::vector<uint32_t> in(2000, 1);
@@ -124,15 +123,15 @@ class GetStringTaskTypeTest : public ::testing::TestWithParam<TaskTypeTestCase>
124123

125124
void SetUp() override {
126125
temp_path = std::filesystem::temp_directory_path() / "test_settings.json";
127-
nlohmann::json j;
128-
j["tasks"]["all"] = "ALL";
129-
j["tasks"]["stl"] = "STL";
130-
j["tasks"]["omp"] = "OMP";
131-
j["tasks"]["mpi"] = "MPI";
132-
j["tasks"]["tbb"] = "TBB";
133-
j["tasks"]["seq"] = "SEQ";
134-
135-
std::ofstream(temp_path) << j.dump();
126+
auto j = ppc::util::InitJSONPtr();
127+
(*j)["tasks"]["all"] = "ALL";
128+
(*j)["tasks"]["stl"] = "STL";
129+
(*j)["tasks"]["omp"] = "OMP";
130+
(*j)["tasks"]["mpi"] = "MPI";
131+
(*j)["tasks"]["tbb"] = "TBB";
132+
(*j)["tasks"]["seq"] = "SEQ";
133+
134+
std::ofstream(temp_path) << (*j).dump();
136135
}
137136

138137
void TearDown() override { std::filesystem::remove(temp_path); }

modules/core/util/include/util.hpp

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,29 +17,12 @@
1717
#pragma warning(pop)
1818
#endif
1919

20-
/* NOLINTBEGIN */
21-
#define ASSERT_ANY_THROW_NOLINT(...) ASSERT_ANY_THROW(__VA_ARGS__)
22-
/* NOLINTEND */
23-
24-
/* NOLINTBEGIN */
25-
#define EXPECT_THROW_NOLINT(...) EXPECT_THROW(__VA_ARGS__)
26-
/* NOLINTEND */
27-
28-
/* NOLINTBEGIN */
29-
#define INSTANTIATE_TEST_SUITE_P_NOLINT(...) INSTANTIATE_TEST_SUITE_P(__VA_ARGS__)
30-
/* NOLINTEND */
31-
32-
/* NOLINTBEGIN */
33-
#define TEST_NOLINT(...) TEST(__VA_ARGS__)
34-
/* NOLINTEND */
35-
36-
/* NOLINTBEGIN */
37-
#define ASSERT_DEATH_IF_SUPPORTED_NOLINT(...) ASSERT_DEATH_IF_SUPPORTED(__VA_ARGS__)
38-
/* NOLINTEND */
39-
40-
/* NOLINTBEGIN */
41-
#define TYPED_TEST_NOLINT(...) TYPED_TEST(__VA_ARGS__)
42-
/* NOLINTEND */
20+
#define ASSERT_ANY_THROW_NOLINT(...) ASSERT_ANY_THROW(__VA_ARGS__) // NOLINT
21+
#define EXPECT_THROW_NOLINT(...) EXPECT_THROW(__VA_ARGS__) // NOLINT
22+
#define INSTANTIATE_TEST_SUITE_P_NOLINT(...) INSTANTIATE_TEST_SUITE_P(__VA_ARGS__) // NOLINT
23+
#define TEST_NOLINT(...) TEST(__VA_ARGS__) // NOLINT
24+
#define ASSERT_DEATH_IF_SUPPORTED_NOLINT(...) ASSERT_DEATH_IF_SUPPORTED(__VA_ARGS__) // NOLINT
25+
#define TYPED_TEST_NOLINT(...) TYPED_TEST(__VA_ARGS__) // NOLINT
4326

4427
namespace ppc::util {
4528

0 commit comments

Comments
 (0)