fix(lint): re-enable stricter rules and fix violations

- Enable no-plusplus, arrow-body-style, sort-keys, and react/no-array-index-key in oxlintrc

- Add sort-keys override for Better Auth localization map

- Fix sort order, stable React keys, and small style fixes across portal and web

- Use useId-based slide keys in testimonials carousel to avoid duplicate keys

Made-with: Cursor

Author: kzndotsh

.oxlintrc.json

@@ -28,7 +28,6 @@
     "import/no-namespace": "error",
     "oxc/no-barrel-file": "error",
     "func-style": "off",
-    "sort-keys": "off",
     "global-require": "off",
     "unicorn/prefer-module": "off",
     "no-inline-comments": "off",
@@ -48,7 +47,6 @@
     "no-warning-comments": "off",
     "no-empty-function": "off",
     "unicorn/prefer-dom-node-remove": "off",
-    "no-plusplus": "off",
     "unicorn/prefer-string-replace-all": "off",
     "typescript/consistent-type-imports": "off",
     "unicorn/consistent-function-scoping": "off",
@@ -67,9 +65,7 @@
     "react/no-danger": "off",
     "no-useless-return": "off",
     "max-classes-per-file": "off",
-    "complexity": "off",
-    "arrow-body-style": "off",
-    "react/no-array-index-key": "off"
+    "complexity": "off"
   },
   "overrides": [
     {
@@ -147,6 +143,12 @@
         "no-param-reassign": "off"
       }
     },
+    {
+      "files": ["apps/portal/src/features/auth/lib/localization.ts"],
+      "rules": {
+        "sort-keys": "off"
+      }
+    },
     {
       "files": ["packages/ui/**/*.{ts,tsx}"],
       "rules": {

apps/portal/next.config.ts

@@ -22,13 +22,13 @@ function makeQueryClient() {
         shouldRedactErrors: () => false,
       },
       queries: {
-        // With SSR, we usually want to set some default staleTime
-        // above 0 to avoid refetching immediately on the client
-        staleTime: QUERY_CACHE.STALE_TIME_DEFAULT,
         gcTime: QUERY_CACHE.GC_TIME_DEFAULT,
-        retry: 0, // No retries by default
         // Refetch on window focus is good for keeping data fresh
         refetchOnWindowFocus: true,
+        retry: 0, // No retries by default
+        // With SSR, we usually want to set some default staleTime
+        // above 0 to avoid refetching immediately on the client
+        staleTime: QUERY_CACHE.STALE_TIME_DEFAULT,
       },
     },
   });

apps/portal/packages/api/src/query-client.ts

@@ -11,55 +11,6 @@ import type {
 } from "./types";
 
 export const queryKeys = {
-  // User queries
-  users: {
-    all: ["users"] as const,
-    current: () => [...queryKeys.users.all, "current"] as const,
-    detail: (id: string) => [...queryKeys.users.details(), id] as const,
-    details: () => [...queryKeys.users.all, "detail"] as const,
-    list: (filters?: UserListFilters) =>
-      [...queryKeys.users.lists(), { filters }] as const,
-    lists: () => [...queryKeys.users.all, "list"] as const,
-    stats: () => [...queryKeys.users.all, "stats"] as const,
-  },
-
-  // Session queries
-  sessions: {
-    all: ["sessions"] as const,
-    current: () => [...queryKeys.sessions.all, "current"] as const,
-    detail: (id: string) => [...queryKeys.sessions.details(), id] as const,
-    details: () => [...queryKeys.sessions.all, "detail"] as const,
-    list: (filters?: SessionListFilters) =>
-      [...queryKeys.sessions.lists(), { filters }] as const,
-    lists: () => [...queryKeys.sessions.all, "list"] as const,
-    user: (userId: string) =>
-      [...queryKeys.sessions.all, "user", userId] as const,
-  },
-
-  // API Key queries
-  apiKeys: {
-    all: ["apiKeys"] as const,
-    detail: (id: string) => [...queryKeys.apiKeys.details(), id] as const,
-    details: () => [...queryKeys.apiKeys.all, "detail"] as const,
-    list: (userId?: string) =>
-      [...queryKeys.apiKeys.lists(), { userId }] as const,
-    lists: () => [...queryKeys.apiKeys.all, "list"] as const,
-    user: (userId: string) =>
-      [...queryKeys.apiKeys.all, "user", userId] as const,
-  },
-
-  // OAuth Client queries
-  oauthClients: {
-    all: ["oauthClients"] as const,
-    detail: (id: string) => [...queryKeys.oauthClients.details(), id] as const,
-    details: () => [...queryKeys.oauthClients.all, "detail"] as const,
-    list: (filters?: OAuthClientListFilters) =>
-      [...queryKeys.oauthClients.lists(), { filters }] as const,
-    lists: () => [...queryKeys.oauthClients.all, "list"] as const,
-    user: (userId: string) =>
-      [...queryKeys.oauthClients.all, "user", userId] as const,
-  },
-
   // Admin queries
   admin: {
     all: ["admin"] as const,
@@ -88,6 +39,18 @@ export const queryKeys = {
     },
   },
 
+  // API Key queries
+  apiKeys: {
+    all: ["apiKeys"] as const,
+    detail: (id: string) => [...queryKeys.apiKeys.details(), id] as const,
+    details: () => [...queryKeys.apiKeys.all, "detail"] as const,
+    list: (userId?: string) =>
+      [...queryKeys.apiKeys.lists(), { userId }] as const,
+    lists: () => [...queryKeys.apiKeys.all, "list"] as const,
+    user: (userId: string) =>
+      [...queryKeys.apiKeys.all, "user", userId] as const,
+  },
+
   // Integration queries
   integrations: {
     accounts: {
@@ -113,4 +76,41 @@ export const queryKeys = {
     list: () => [...queryKeys.integrations.lists()] as const,
     lists: () => [...queryKeys.integrations.all, "list"] as const,
   },
+
+  // OAuth Client queries
+  oauthClients: {
+    all: ["oauthClients"] as const,
+    detail: (id: string) => [...queryKeys.oauthClients.details(), id] as const,
+    details: () => [...queryKeys.oauthClients.all, "detail"] as const,
+    list: (filters?: OAuthClientListFilters) =>
+      [...queryKeys.oauthClients.lists(), { filters }] as const,
+    lists: () => [...queryKeys.oauthClients.all, "list"] as const,
+    user: (userId: string) =>
+      [...queryKeys.oauthClients.all, "user", userId] as const,
+  },
+
+  // Session queries
+  sessions: {
+    all: ["sessions"] as const,
+    current: () => [...queryKeys.sessions.all, "current"] as const,
+    detail: (id: string) => [...queryKeys.sessions.details(), id] as const,
+    details: () => [...queryKeys.sessions.all, "detail"] as const,
+    list: (filters?: SessionListFilters) =>
+      [...queryKeys.sessions.lists(), { filters }] as const,
+    lists: () => [...queryKeys.sessions.all, "list"] as const,
+    user: (userId: string) =>
+      [...queryKeys.sessions.all, "user", userId] as const,
+  },
+
+  // User queries
+  users: {
+    all: ["users"] as const,
+    current: () => [...queryKeys.users.all, "current"] as const,
+    detail: (id: string) => [...queryKeys.users.details(), id] as const,
+    details: () => [...queryKeys.users.all, "detail"] as const,
+    list: (filters?: UserListFilters) =>
+      [...queryKeys.users.lists(), { filters }] as const,
+    lists: () => [...queryKeys.users.all, "list"] as const,
+    stats: () => [...queryKeys.users.all, "stats"] as const,
+  },
 } as const;

apps/portal/packages/api/src/query-keys.ts

@@ -36,10 +36,6 @@ if (!process.env.DATABASE_URL) {
 }
 
 export default defineConfig({
-  // Database dialect
-  // Options: "postgresql" | "mysql" | "sqlite" | "turso" | "singlestore" | "mssql" | "cockroachdb"
-  dialect: "postgresql",
-
   // Database connection credentials
   // For PostgreSQL, you can also specify: host, port, user, password, database, ssl
   dbCredentials: {
@@ -53,14 +49,9 @@ export default defineConfig({
     // ssl: process.env.NODE_ENV === "production" ? { rejectUnauthorized: false } : false,
   },
 
-  // Schema file paths (glob-based)
-  // Can be a string, array of strings, or glob pattern
-  // Examples:
-  //   "./src/shared/db/schema.ts"       - Single file
-  //   "./src/shared/db/schema/*"        - All files in schema folder
-  //   ["./src/shared/db/schema/*.ts"]  - Array of glob patterns
-  //   "./src/**/schema.ts"               - All schema.ts files recursively
-  schema: "./src/schema/*",
+  // Database dialect
+  // Options: "postgresql" | "mysql" | "sqlite" | "turso" | "singlestore" | "mssql" | "cockroachdb"
+  dialect: "postgresql",
 
   // Output folder for migrations, snapshots, and pulled schemas
   // Default: "./drizzle"
@@ -70,15 +61,24 @@ export default defineConfig({
   //   - Generated schema.ts from drizzle-kit pull
   out: "./drizzle",
 
-  // Print all SQL statements during operations
-  // Useful for debugging and understanding what Drizzle Kit is doing
-  verbose: true,
+  // Schema file paths (glob-based)
+  // Can be a string, array of strings, or glob pattern
+  // Examples:
+  //   "./src/shared/db/schema.ts"       - Single file
+  //   "./src/shared/db/schema/*"        - All files in schema folder
+  //   ["./src/shared/db/schema/*.ts"]  - Array of glob patterns
+  //   "./src/**/schema.ts"               - All schema.ts files recursively
+  schema: "./src/schema/*",
 
   // Prompt confirmation before running SQL statements (push command)
   // When true, Drizzle Kit will ask for confirmation before executing SQL
   // Recommended: true for production, false for development
   strict: true,
 
+  // Print all SQL statements during operations
+  // Useful for debugging and understanding what Drizzle Kit is doing
+  verbose: true,
+
   // Embed statement breakpoints in generated SQL migrations
   // Required for databases that don't support multiple DDL statements in one transaction
   // (MySQL and SQLite). Default: true