Skip to content

Commit 197d547

Browse files
jktttbaev
authored andcommitted
junit4 - fix npe for tests in default package (via #134)
1 parent f6fbe10 commit 197d547

File tree

3 files changed

+25
-1
lines changed

3 files changed

+25
-1
lines changed

allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,10 @@ private MessageDigest getMessageDigest() {
232232
}
233233

234234
private String getPackage(final Class<?> testClass) {
235-
return testClass.getPackage().getName();
235+
return Optional.of(testClass)
236+
.map(Class::getPackage)
237+
.map(Package::getName)
238+
.orElse("");
236239
}
237240

238241
private StatusDetails getIgnoredMessage(final Description description) {
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import org.junit.Test;
2+
3+
/**
4+
* @author jkt on 15.08.17.
5+
*/
6+
public class SampleTestInDefaultPackage {
7+
8+
@Test
9+
public void testMethod() {
10+
11+
}
12+
}

allure-junit4/src/test/java/io/qameta/allure/junit4/FeatureCombinationsTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.junit.Test;
2424
import org.junit.runner.JUnitCore;
2525
import org.junit.runner.Request;
26+
import org.junit.runner.Result;
2627

2728
import java.util.List;
2829

@@ -224,4 +225,12 @@ public void shouldSetTags() throws Exception {
224225
.extracting(Label::getValue)
225226
.containsExactlyInAnyOrder(CLASS_TAG1, CLASS_TAG2, METHOD_TAG1, METHOD_TAG2);
226227
}
228+
229+
@Test
230+
@DisplayName("Should not throw exception processing test from default package")
231+
public void shouldProcessTestFromDefaultPackage() throws Exception {
232+
Class<?> testInDefaultPackage = Class.forName("SampleTestInDefaultPackage");
233+
Result result = core.run(Request.aClass(testInDefaultPackage));
234+
assertThat(result.wasSuccessful()).isTrue();
235+
}
227236
}

0 commit comments

Comments
 (0)