fix common code problems (via #410)

Author: jreznot

allure-attachments/src/main/java/io/qameta/allure/attachment/http/HttpResponseAttachment.java

@@ -108,7 +108,6 @@ public Builder setUrl(final String url) {
         }
 
         public Builder setResponseCode(final int responseCode) {
-            Objects.requireNonNull(responseCode, "Response code must not be null value");
             this.responseCode = responseCode;
             return this;
         }

allure-cucumber-jvm/src/main/java/io/qameta/allure/cucumberjvm/AllureCucumberJvm.java

@@ -38,15 +38,14 @@
 import io.qameta.allure.util.ResultsUtils;
 
 import java.io.ByteArrayInputStream;
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
-import java.util.Objects;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Deque;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentHashMap;
 
@@ -249,7 +248,7 @@ private void createDataTableAttachment(final List<DataTableRow> dataTableRows) {
             final String attachmentSource = lifecycle
                     .prepareAttachment("Data table", "text/tab-separated-values", "csv");
             lifecycle.writeAttachment(attachmentSource,
-                    new ByteArrayInputStream(dataTableCsv.toString().getBytes(Charset.forName("UTF-8"))));
+                    new ByteArrayInputStream(dataTableCsv.toString().getBytes(StandardCharsets.UTF_8)));
         }
     }
 

allure-cucumber2-jvm/src/main/java/io/qameta/allure/cucumber2jvm/AllureCucumber2Jvm.java

@@ -51,7 +51,6 @@
 import io.qameta.allure.model.TestResultContainer;
 
 import java.io.ByteArrayInputStream;
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.util.Collections;
 import java.util.Deque;
@@ -328,7 +327,7 @@ private void createDataTableAttachment(final PickleTable pickleTable) {
             final String attachmentSource = lifecycle
                     .prepareAttachment("Data table", "text/tab-separated-values", "csv");
             lifecycle.writeAttachment(attachmentSource,
-                    new ByteArrayInputStream(dataTableCsv.toString().getBytes(Charset.forName("UTF-8"))));
+                    new ByteArrayInputStream(dataTableCsv.toString().getBytes(StandardCharsets.UTF_8)));
         }
     }
 

allure-cucumber3-jvm/src/main/java/io/qameta/allure/cucumber3jvm/AllureCucumber3Jvm.java

@@ -51,7 +51,6 @@
 import io.qameta.allure.model.TestResultContainer;
 
 import java.io.ByteArrayInputStream;
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.util.Collections;
 import java.util.Deque;
@@ -330,7 +329,7 @@ private void createDataTableAttachment(final PickleTable pickleTable) {
             final String attachmentSource = lifecycle
                     .prepareAttachment("Data table", "text/tab-separated-values", "csv");
             lifecycle.writeAttachment(attachmentSource,
-                    new ByteArrayInputStream(dataTableCsv.toString().getBytes(Charset.forName("UTF-8"))));
+                    new ByteArrayInputStream(dataTableCsv.toString().getBytes(StandardCharsets.UTF_8)));
         }
     }
 

allure-java-commons/src/main/java/io/qameta/allure/aspects/AttachmentsAspects.java

@@ -39,7 +39,8 @@
 @Aspect
 public class AttachmentsAspects {
 
-    private static InheritableThreadLocal<AllureLifecycle> lifecycle = new InheritableThreadLocal<AllureLifecycle>() {
+    private static final InheritableThreadLocal<AllureLifecycle> LIFECYCLE =
+            new InheritableThreadLocal<AllureLifecycle>() {
         @Override
         protected AllureLifecycle initialValue() {
             return Allure.getLifecycle();
@@ -89,10 +90,10 @@ public void attachment(final JoinPoint joinPoint, final Object result) {
      * @param allure allure lifecycle to set.
      */
     public static void setLifecycle(final AllureLifecycle allure) {
-        lifecycle.set(allure);
+        LIFECYCLE.set(allure);
     }
 
     public static AllureLifecycle getLifecycle() {
-        return lifecycle.get();
+        return LIFECYCLE.get();
     }
 }

allure-java-commons/src/main/java/io/qameta/allure/aspects/StepsAspects.java

@@ -45,7 +45,8 @@
 @Aspect
 public class StepsAspects {
 
-    private static InheritableThreadLocal<AllureLifecycle> lifecycle = new InheritableThreadLocal<AllureLifecycle>() {
+    private static final InheritableThreadLocal<AllureLifecycle> LIFECYCLE
+            = new InheritableThreadLocal<AllureLifecycle>() {
         @Override
         protected AllureLifecycle initialValue() {
             return Allure.getLifecycle();
@@ -98,10 +99,10 @@ public void stepStop() {
      * @param allure allure lifecycle to set.
      */
     public static void setLifecycle(final AllureLifecycle allure) {
-        lifecycle.set(allure);
+        LIFECYCLE.set(allure);
     }
 
     public static AllureLifecycle getLifecycle() {
-        return lifecycle.get();
+        return LIFECYCLE.get();
     }
 }

allure-java-commons/src/main/java/io/qameta/allure/util/PropertiesUtils.java

@@ -43,13 +43,12 @@ public static Properties loadAllureProperties() {
     }
 
     private static void loadPropertiesFrom(final ClassLoader classLoader, final Properties properties) {
-        if (classLoader.getResource(ALLURE_PROPERTIES_FILE) != null) {
-            try (InputStream stream = classLoader.getResourceAsStream(ALLURE_PROPERTIES_FILE)) {
+        try (InputStream stream = classLoader.getResourceAsStream(ALLURE_PROPERTIES_FILE)) {
+            if (stream != null) {
                 properties.load(stream);
-            } catch (IOException e) {
-                LOGGER.error("Error while reading allure.properties file from classpath: %s", e.getMessage());
             }
+        } catch (IOException e) {
+            LOGGER.error("Error while reading allure.properties file from classpath: {}", e.getMessage());
         }
     }
-
 }

allure-spock/src/main/java/io/qameta/allure/spock/AllureSpock.java

@@ -91,7 +91,7 @@ public class AllureSpock extends AbstractRunListener implements IGlobalExtension
     private final ThreadLocal<String> testResults
             = InheritableThreadLocal.withInitial(() -> UUID.randomUUID().toString());
 
-    private AllureLifecycle lifecycle;
+    private final AllureLifecycle lifecycle;
 
     @SuppressWarnings("unused")
     public AllureSpock() {