junit4 - fix npe with ignore annotation on classes (via #119)

Author: gladnik

allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java

@@ -81,8 +81,6 @@ public void testRunFinished(final Result result) throws Exception {
     public void testStarted(final Description description) throws Exception {
         final String uuid = testCases.get();
         final TestResult result = createTestResult(uuid, description);
-        result.getLabels().addAll(getLabels(description));
-        getDisplayName(description).ifPresent(result::setName);
         getLifecycle().scheduleTestCase(result);
         getLifecycle().startTestCase(uuid);
     }
@@ -125,8 +123,6 @@ public void testIgnored(final Description description) throws Exception {
         testCases.remove();
 
         final TestResult result = createTestResult(uuid, description);
-        result.getLabels().addAll(getLabels(description));
-        getDisplayName(description).ifPresent(result::setName);
         result.setStatus(Status.SKIPPED);
         result.setStatusDetails(getIgnoredMessage(description));
         result.setStart(System.currentTimeMillis());
@@ -244,20 +240,28 @@ private StatusDetails getIgnoredMessage(final Description description) {
     }
 
     private TestResult createTestResult(final String uuid, final Description description) {
-        return new TestResult()
+        final String className = description.getClassName();
+        final String methodName = description.getMethodName();
+        final String name = Objects.nonNull(methodName) ? methodName : className;
+        final String fullName = Objects.nonNull(methodName) ? String.format("%s.%s", className, methodName) : className;
+
+        final TestResult testResult = new TestResult()
                 .withUuid(uuid)
                 .withHistoryId(getHistoryId(description))
-                .withName(description.getMethodName())
-                .withFullName(String.format("%s.%s", description.getClassName(), description.getMethodName()))
+                .withName(name)
+                .withFullName(fullName)
                 .withLinks(getLinks(description))
                 .withLabels(
                         new Label().withName("package").withValue(getPackage(description.getTestClass())),
-                        new Label().withName("testClass").withValue(description.getClassName()),
-                        new Label().withName("testMethod").withValue(description.getMethodName()),
-                        new Label().withName("suite").withValue(description.getClassName()),
+                        new Label().withName("testClass").withValue(className),
+                        new Label().withName("testMethod").withValue(name),
+                        new Label().withName("suite").withValue(className),
                         new Label().withName("host").withValue(getHostName()),
                         new Label().withName("thread").withValue(getThreadName())
                 );
+        testResult.getLabels().addAll(getLabels(description));
+        getDisplayName(description).ifPresent(testResult::setName);
+        return testResult;
     }
 
 }

allure-junit4/src/test/java/io/qameta/allure/junit4/FeatureCombinationsTest.java

@@ -5,6 +5,7 @@
 import io.qameta.allure.junit4.samples.AssumptionFailedTest;
 import io.qameta.allure.junit4.samples.BrokenTest;
 import io.qameta.allure.junit4.samples.FailedTest;
+import io.qameta.allure.junit4.samples.IgnoredClassTest;
 import io.qameta.allure.junit4.samples.IgnoredTests;
 import io.qameta.allure.junit4.samples.OneTest;
 import io.qameta.allure.junit4.samples.TaggedTests;
@@ -144,6 +145,16 @@ public void shouldProcessIgnoredTestDescription() throws Exception {
                 .containsExactlyInAnyOrder("Test ignored (without reason)!", "Ignored for some reason");
     }
 
+    @Test
+    @DisplayName("Test result for ignored class gets named by the class name")
+    public void shouldSetNameForIgnoredClass() {
+        core.run(Request.aClass(IgnoredClassTest.class));
+        List<TestResult> testResults = results.getTestResults();
+        assertThat(testResults)
+                .extracting(TestResult::getName)
+                .containsExactly("io.qameta.allure.junit4.samples.IgnoredClassTest");
+    }
+
     @Test
     @DisplayName("Test with steps")
     public void shouldAddStepsToTest() throws Exception {

allure-junit4/src/test/java/io/qameta/allure/junit4/samples/IgnoredClassTest.java

@@ -0,0 +1,16 @@
+package io.qameta.allure.junit4.samples;
+
+import org.junit.Ignore;
+import org.junit.Test;
+
+/**
+ * @author gladnik (Nikolai Gladkov)
+ */
+@Ignore
+public class IgnoredClassTest {
+
+    @Test
+    public void ignoredAsPartOfTheIgnoredClassTest() {
+    }
+
+}