Skip to content

Commit 4eb00e3

Browse files
Fixing category page 404 error due to exception message being passed as nil (#546)
* Adding initital commits * addressing review comment
1 parent 9027aa7 commit 4eb00e3

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

allure-rspec/spec/unit/formatter_example_finished_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
aggregate_failures "Should update correct test case parameters" do
3737
expect(@test_case.stage).to eq(Allure::Stage::FINISHED)
3838
expect(@test_case.status).to eq(Allure::Status::PASSED)
39-
expect(@test_case.status_details).to eq(Allure::StatusDetails.new)
39+
expect(@test_case.status_details).to eq(Allure::StatusDetails.new(message: "NilClass"))
4040
end
4141
end
4242
end

allure-ruby-commons/lib/allure_ruby_commons/result_utils.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def status(exception)
159159
# @param [Exception] exception
160160
# @return [Allure::StatusDetails]
161161
def status_details(exception)
162-
StatusDetails.new(message: exception&.message, trace: exception&.backtrace&.join("\n"))
162+
StatusDetails.new(message: exception&.message || exception.class.name, trace: exception&.backtrace&.join("\n"))
163163
end
164164

165165
# Allure attachment object

allure-ruby-commons/spec/unit/result_utils_spec.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,4 +93,10 @@ def raise_multi_error
9393
expect(status_details.message).to include("Got 2 failures from failure aggregation block")
9494
expect(status_details.trace).not_to be_empty
9595
end
96+
97+
it "returns status details for nill class error" do
98+
status_details = Allure::ResultUtils.status_details(nil)
99+
expect(status_details.message).to eq("NilClass")
100+
expect(status_details.instance_variable_defined?(:@trace)).to be_truthy
101+
end
96102
end

0 commit comments

Comments
 (0)