You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-**Chore**: Changes to our CI configuration files and scripts (e.g: CircleCI, Sauce Labs) or changes that affect the build system
78
81
-**Deps**: Changes to dependencies
79
82
-**Docs**: Documentation only changes
80
83
-**Feat**: A new feature
@@ -84,6 +87,7 @@ MUST be one of the following:
84
87
-**Revert**: Reverting code changes
85
88
-**Test**: Adding missing tests or correcting existing tests
86
89
-**Style**: Changes to code style or styling of components and pages
90
+
<!-- textlint-enable -->
87
91
88
92
##### Scope
89
93
@@ -110,7 +114,7 @@ The following is the list of supported scopes:
110
114
- Repository-wide:
111
115
-`ci`: used for changes that affect the Continuous Integration process and builds
112
116
-`repo`: used for repository-wide changes
113
-
- none/empty string: useful for `Test` and `Refactor` changes that are done across all packages (e.g. `Test: Add missing unit tests`) and for docs changes that are not related to a specific package (e.g.`Docs: Fix typo in the tutorial`).
117
+
- none/empty string: useful for `Test` and `Refactor` changes that are done across all packages (for example `Test: Add missing unit tests`) and for docs changes that are not related to a specific package (for example`Docs: Fix typo in the tutorial`).
114
118
115
119
##### Summary
116
120
@@ -125,7 +129,7 @@ Use the summary field to provide a succinct description of the change:
125
129
Just as in the summary, use the imperative, present tense: "fix" not "fixed" nor "fixes".
126
130
127
131
Explain the motivation for the change in the commit message body. This commit message SHOULD explain _why_ you are making the change.
128
-
You can include a comparison of the previous behavior with the new behavior in order to illustrate the impact of the change.
132
+
You can include a comparison of the previous behavior with the new behavior to illustrate the impact of the change.
129
133
130
134
#### Commit Message Footer
131
135
@@ -150,7 +154,7 @@ If the commit reverts a previous commit, it SHOULD begin with `Revert: `, follow
150
154
The content of the commit message body SHOULD contain:
151
155
152
156
- information about the SHA of the commit being reverted in the following format: `This reverts commit <SHA>`,
153
-
- a clear description of the reason for reverting the commit message.
157
+
- a clear description of why the commit message is being reverted.
154
158
155
159
### Before Commit
156
160
@@ -162,18 +166,18 @@ This project uses Prettier for code formatting. You can run `make format` to for
162
166
163
167
## Documenting the Components
164
168
165
-
1. All components MUST be documented in a `README` file in the root of the component, e.g.`packages/web-react/Accordion/README.md`.
169
+
1. All components MUST be documented in a `README` file in the root of the component, for example`packages/web-react/Accordion/README.md`.
166
170
2. The documentation MUST be written in Markdown.
167
171
3. The documentation MUST contain at least a basic example usage of the component.
168
172
4. For complex components or components with subcomponents, the documentation SHOULD contain examples of individual building blocks as well as an example composition.
169
173
5. Component and subcomponent props MUST be documented in a table.
170
174
1. The table MUST be placed in a section introduced by a headline called `API`.
171
175
2. The table MUST contain the following columns:
172
-
-`Name` — the name of the prop, e.g.`title`
173
-
-`Type` — the type of the prop, e.g.`string`, `number`, `bool`, `[horizontal | vertical]`, an existing [dictionary][dictionary], etc.
174
-
-`Default` — the default value of the prop, e.g.`null` or `—` (em-dash) if there is no default value
176
+
-`Name` — the name of the prop, for example`title`
177
+
-`Type` — the type of the prop, for example`string`, `number`, `bool`, `[horizontal | vertical]`, an existing [dictionary][dictionary], etc.
178
+
-`Default` — the default value of the prop, for example`null` or `—` (em-dash) if there is no default value
175
179
-`Required` — if the prop is required `✓` or not `✕`
176
-
-`Description` — the description of the prop, e.g.`Title of the accordion`
180
+
-`Description` — the description of the prop, for example`Title of the accordion`
177
181
3. The props MUST be sorted alphabetically by their name.
178
182
179
183
## Testing
@@ -183,9 +187,9 @@ Using this you can test the entire package and verify that all parts of the pack
183
187
184
188
The testing script includes:
185
189
186
-
- linting using [ESlint][eslint]
190
+
- linting using [ESLint][eslint]
187
191
- checking format using the [Prettier][prettier]
188
-
- checking types using the [Typescript][typescript] compiler
192
+
- checking types using the [TypeScript][typescript] compiler
189
193
- running unit test using the [Jest][jest]
190
194
191
195
### Unit Testing
@@ -243,16 +247,16 @@ When the tests fail, there will be a comment in the PR with a link to the report
243
247
You can also find the report URL in the GitHub Actions run under the `Run actions/upload-artifact` section.
244
248
Look for `Artifact download URL: https://github.com/lmc-eu/spirit-design-system/actions/runs/<run-id>/artifacts/<artifact-id>`.
245
249
246
-
⚠️ Currently we do not deploy the Web Twig package to any environment, so you can only test it locally.
250
+
⚠️ We do not deploy the Web Twig package to any environment, so you can only test it locally.
247
251
248
252
### Developing and Testing GitHub Actions
249
253
250
254
It can be time-consuming and painful to test GitHub Actions.
251
255
First, you have to change the GitHub Actions file locally, push your local code into the GitHub repository, and wait for the result.
252
256
253
-
To solve this issue, you can use [act][act]CLI tool to test and write the GitHub actions locally.
257
+
To solve this issue, you can use [act][act]command-line tool to test and write the GitHub actions locally.
254
258
255
-
For more, please read the article [How to Run GitHub Actions Locally with the act CLI tool][act-article].
259
+
For more, please read the article [How to Run GitHub Actions Locally with the act command-line tool][act-article].
Copy file name to clipboardExpand all lines: configs/typescript-config-spirit/README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -27,7 +27,7 @@ It is worth noting that when you extend a `tsconfig.json` file, the properties i
27
27
And **when both files define the same property, the child `tsconfig.json` wins**.
28
28
29
29
However, this is not the case with `include` and `exclude`.
30
-
If you define them in the child `tsconfig.json` file, that **exact value will be used; it won’t be merged** with the value from the base `tsconfig.json` file.
30
+
If you define them in the child `tsconfig.json` file, that **exact value will be used; it won't be merged** with the value from the base `tsconfig.json` file.
Copy file name to clipboardExpand all lines: docs/DICTIONARIES.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,8 +2,8 @@
2
2
3
3
This project uses `dictionaries` to unify props between different components.
4
4
5
-
- Every dictionary is always a range. E.g. the dictionary Size content Small, Medium, Large.
6
-
- If at least 1 item is used from the dictionary in a component's property, all the others should be used. E.g. if there are button sizes Medium and Large, there should also be the size Small.
5
+
- Every dictionary is always a range. For example the dictionary Size content Small, Medium, Large.
6
+
- If at least 1 item is used from the dictionary in a component's property, all the others should be used. For example if there are button sizes Medium and Large, there should also be the size Small.
7
7
- A given property is not a dictionary by itself. The property is contained in the dictionary. That is, the Action Primary Default color is contained in the Action Primary dictionary entry.
0 commit comments