You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+18-18Lines changed: 18 additions & 18 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
# Contributing to Spirit Design System
2
2
3
-
First of all, thanks for your contribution to this project! ❤️
3
+
Thanks for your contribution to this project! ❤️
4
4
Here are some tips how to make your contributing efforts efficient and eventually accepted & merged:
5
5
6
6
-[General Usage](#general-usage)
@@ -31,7 +31,7 @@ See [Developer Handbook][developer-handbook] for more information about developm
31
31
32
32
## Commit Conventions
33
33
34
-
All commits you make SHOULD adhere to our commit guidelines. We use [conventional commits][conventional-commits] strategy with a slight modification of our own - [@lmc-eu/commitlint-config][commitlint-config]. This is later used during the release phase to determine how to bump the packages' version numbers based on commit history. 🚀
34
+
All commits you make SHOULD adhere to our commit guidelines. We use [conventional commits][conventional-commits] strategy with a slight modification of our own - [@lmc-eu/commitlint-config][commitlint-config]. This is later used during the release phase to determine how to bump the packages’ version numbers based on commit history. 🚀
35
35
36
36
### Commit Message Format
37
37
@@ -74,7 +74,7 @@ The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is opti
74
74
75
75
MUST be one of the following:
76
76
77
-
-**Chore**: Changes to our CI configuration files and scripts (examples: CircleCI, SauceLabs) or changes that affect the build system
77
+
-**Chore**: Changes to our CI configuration files and scripts (examples: CircleCI, SauceLabs) or changes that affect the build tool
78
78
-**Deps**: Changes to dependencies
79
79
-**Docs**: Documentation only changes
80
80
-**Feat**: A new feature
@@ -109,7 +109,7 @@ The following is the list of supported scopes:
109
109
- Repository-wide:
110
110
-`ci`: used for changes that affect the Continuous Integration process and builds
111
111
-`repo`: used for repository-wide changes
112
-
- none/empty string: useful for `Test` and `Refactor` changes that are done across all packages (e.g. `Test: Add missing unit tests`) and for docs changes that are not related to a specific package (e.g.`Docs: Fix typo in the tutorial`).
112
+
- none/empty string: useful for `Test` and `Refactor` changes that are done across all packages (for example `Test: Add missing unit tests`) and for docs changes that are not related to a specific package (for example`Docs: Fix typo in the tutorial`).
113
113
114
114
##### Summary
115
115
@@ -124,7 +124,7 @@ Use the summary field to provide a succinct description of the change:
124
124
Just as in the summary, use the imperative, present tense: "fix" not "fixed" nor "fixes".
125
125
126
126
Explain the motivation for the change in the commit message body. This commit message SHOULD explain _why_ you are making the change.
127
-
You can include a comparison of the previous behavior with the new behavior in order to illustrate the impact of the change.
127
+
You can include a comparison of the previous behavior with the new behavior to illustrate the impact of the change.
128
128
129
129
#### Commit Message Footer
130
130
@@ -149,7 +149,7 @@ If the commit reverts a previous commit, it SHOULD begin with `Revert: `, follow
149
149
The content of the commit message body SHOULD contain:
150
150
151
151
- information about the SHA of the commit being reverted in the following format: `This reverts commit <SHA>`,
152
-
- a clear description of the reason for reverting the commit message.
152
+
- a clear description of why the commit message is being reverted.
153
153
154
154
### Before Commit
155
155
@@ -161,18 +161,18 @@ This project uses Prettier for code formatting. You can run `make format` to for
161
161
162
162
## Documenting the Components
163
163
164
-
1. All components MUST be documented in a `README` file in the root of the component, e.g.`packages/web-react/Accordion/README.md`.
164
+
1. All components MUST be documented in a `README` file in the root of the component, for example`packages/web-react/Accordion/README.md`.
165
165
2. The documentation MUST be written in Markdown.
166
166
3. The documentation MUST contain at least a basic example usage of the component.
167
167
4. For complex components or components with subcomponents, the documentation SHOULD contain examples of individual building blocks as well as an example composition.
168
168
5. Component and subcomponent props MUST be documented in a table.
169
169
1. The table MUST be placed in a section introduced by a headline called `API`.
170
170
2. The table MUST contain the following columns:
171
-
-`Name` — the name of the prop, e.g.`title`
172
-
-`Type` — the type of the prop, e.g.`string`, `number`, `bool`, `[horizontal | vertical]`, an existing [dictionary][dictionary], etc.
173
-
-`Default` — the default value of the prop, e.g.`null` or `—` (em-dash) if there is no default value
171
+
-`Name` — the name of the prop, for example`title`
172
+
-`Type` — the type of the prop, for example`string`, `number`, `bool`, `[horizontal | vertical]`, an existing [dictionary][dictionary], etc.
173
+
-`Default` — the default value of the prop, for example`null` or `—` (em-dash) if there is no default value
174
174
-`Required` — if the prop is required `✓` or not `✕`
175
-
-`Description` — the description of the prop, e.g.`Title of the accordion`
175
+
-`Description` — the description of the prop, for example`Title of the accordion`
176
176
3. The props MUST be sorted alphabetically by their name.
177
177
178
178
## Testing
@@ -182,15 +182,15 @@ Using this you can test the entire package and verify that all parts of the pack
182
182
183
183
The testing script includes:
184
184
185
-
- linting using [ESlint][eslint]
185
+
- linting using [ESLint][eslint]
186
186
- checking format using the [Prettier][prettier]
187
-
- checking types using the [Typescript][typescript] compiler
187
+
- checking types using the [TypeScript][typescript] compiler
188
188
- running unit test using the [Jest][jest]
189
189
190
190
### Unit Testing
191
191
192
192
You can run unit testing via `test:unit` scripts.
193
-
For all available scripts see the package's `package.json` file.
193
+
For all available scripts see the package’s `package.json` file.
194
194
195
195
### Manual Testing
196
196
@@ -225,7 +225,7 @@ We have two test suites and you can find them in the `./tests/e2e` directory:
225
225
226
226
-`demo-homepages` - tests the homepages of our demo apps.
227
227
- This test is used to verify that the demo apps are working properly and their homepages are not broken.
228
-
-`demo-components-compare` - tests components' pages of our demo apps'.
228
+
-`demo-components-compare` - tests components’ pages of our demo apps’.
229
229
- This test gets the list of components from the file system for each package and then it goes through each component and compares its page in all demo apps.
230
230
- Only one screenshot is taken for each component. If you run the update command, only the last screenshot will be saved.
231
231
@@ -242,16 +242,16 @@ When the tests fail, there will be a comment in the PR with a link to the report
242
242
You can also find the report URL in the GitHub Actions run under the `Run actions/upload-artifact` section.
243
243
Look for `Artifact download URL: https://github.com/lmc-eu/spirit-design-system/actions/runs/<run-id>/artifacts/<artifact-id>`.
244
244
245
-
⚠️ Currently we do not deploy the Web Twig package to any environment, so you can only test it locally.
245
+
⚠️ We do not deploy the Web Twig package to any environment, so you can only test it locally.
246
246
247
247
### Developing and Testing GitHub Actions
248
248
249
249
It can be time-consuming and painful to test GitHub Actions.
250
250
First, you have to change the GitHub Actions file locally, push your local code into the GitHub repository, and wait for the result.
251
251
252
-
To solve this issue, you can use [act][act]CLI tool to test and write the GitHub actions locally.
252
+
To solve this issue, you can use [act][act]command line tool to test and write the GitHub actions locally.
253
253
254
-
For more, please read the article [How to Run GitHub Actions Locally with the act CLI tool][act-article].
254
+
For more, please read the article [How to Run GitHub Actions Locally with the act command line tool][act-article].
Copy file name to clipboardExpand all lines: DEPRECATIONS-v2.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -21,11 +21,11 @@ Introducing deprecations and feature flags to be removed in the version 2 lists.
21
21
22
22
<!--lint enable heading-capitalization -->
23
23
24
-
-_spirit-web-twig_ was released as version 2 already. See the [CHANGELOG][twig-changelog] for more details or refer to the [migration guide][twig-migration-v2].
24
+
-_spirit-web-twig_ was released as version 2 already. See the [CHANGELOG][twig-changelog] for more details or check the [migration guide][twig-migration-v2].
25
25
26
26
---
27
27
28
-
Please refer back to this list or reach out to our team if you encounter any issues during migration.
28
+
If you face any problems during migration, please check this list or contact our team for assistance.
Copy file name to clipboardExpand all lines: docs/DICTIONARIES.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,8 +2,8 @@
2
2
3
3
This project uses `dictionaries` to unify props between different components.
4
4
5
-
- Every dictionary is always a range. E.g. the dictionary Size content Small, Medium, Large.
6
-
- If at least 1 item is used from the dictionary in a component's property, all the others should be used. E.g. if there are button sizes Medium and Large, there should also be the size Small.
5
+
- Every dictionary is always a range. For example the dictionary Size content Small, Medium, Large.
6
+
- If at least 1 item is used from the dictionary in a component’s property, all the others should be used. For example if there are button sizes Medium and Large, there should also be the size Small.
7
7
- A given property is not a dictionary by itself. The property is contained in the dictionary. That is, the Action Primary Default color is contained in the Action Primary dictionary entry.
0 commit comments