chore: lint and ci fixes

aloks98 · aloks98 · commit 9377baf3b3e1 · 2025-12-14T03:20:43.000+05:30
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -59,7 +59,7 @@ jobs:
           path: |
             ~/go/pkg/mod
             ~/.cache/go-build
-          key: ${{ runner.os }}-go-${{ hashFiles('backend/go.sum') }}
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
 
@@ -96,7 +96,7 @@ jobs:
           path: |
             ~/go/pkg/mod
             ~/.cache/go-build
-          key: ${{ runner.os }}-go-${{ hashFiles('backend/go.sum') }}
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
 
@@ -119,6 +119,16 @@ jobs:
         with:
           bun-version: latest
 
+      - name: Cache Bun dependencies
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.bun/install/cache
+            ui/node_modules
+          key: ${{ runner.os }}-bun-${{ hashFiles('ui/bun.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-bun-
+
       - name: Install dependencies
         working-directory: ui
         run: bun install
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -30,7 +30,7 @@ jobs:
           path: |
             ~/go/pkg/mod
             ~/.cache/go-build
-          key: ${{ runner.os }}-go-${{ hashFiles('backend/go.sum') }}
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
 
@@ -51,6 +51,17 @@ jobs:
         with:
           bun-version: latest
 
+      - name: Cache Bun dependencies
+        if: matrix.component == 'frontend'
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.bun/install/cache
+            ui/node_modules
+          key: ${{ runner.os }}-bun-${{ hashFiles('ui/bun.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-bun-
+
       - name: Install frontend dependencies
         if: matrix.component == 'frontend'
         working-directory: ui
diff --git a/GITHUB_ACTIONS.md b/GITHUB_ACTIONS.md
@@ -51,7 +51,9 @@ The workflow intelligently runs jobs based on which files changed:
 
 **Features:**
 - ⚡ **Fast PR checks**: Only runs relevant jobs
-- 🔄 Caching of Go modules and build artifacts
+- 🔄 **Dependency caching**:
+  - Go modules (`~/go/pkg/mod`) and build artifacts (`~/.cache/go-build`)
+  - Bun dependencies (`~/.bun/install/cache` and `ui/node_modules`)
 - 🚀 Parallel execution of independent jobs
 - 🐳 Docker layer caching for faster builds
 - 🔍 Always runs full suite on master branch
@@ -116,6 +118,7 @@ The workflow intelligently runs jobs based on which files changed:
 - 🔒 **Protected by tests**: Docker push only happens if all tests pass
 - 🎯 **Build from tag**: Ensures Docker image is built from tagged commit
 - 📦 **Dual tagging**: Pushes both version-specific and `latest` tags
+- 🔄 **Dependency caching**: Go and Bun dependencies cached for faster builds
 - 📝 **Auto-generated release notes**: GitHub automatically generates release notes from commits since last release
 - 🐳 **Complete installation guide**: Includes Docker and Docker Compose installation instructions
 
diff --git a/LINTING.md b/LINTING.md
@@ -105,7 +105,8 @@ When you run `git commit`, the hook will **CHECK ONLY** (not auto-fix):
 
 1. **Backend (.go files)**:
    - Run `gofumpt` to check formatting
-   - **Fails if code is not formatted**
+   - Run `golangci-lint` to check code quality
+   - **Fails if code is not formatted OR has linting errors**
 
 2. **Frontend (.ts, .tsx, .js, .jsx, .json, .css files)**:
    - Run Biome CI check (formatter + linter)
@@ -114,16 +115,20 @@ When you run `git commit`, the hook will **CHECK ONLY** (not auto-fix):
 
 ### If the commit fails:
 
-1. **Format your code manually**:
+1. **Format and fix linting errors**:
    ```bash
-   # Backend
+   # Backend - Format code
    cd backend && make fmt
 
-   # Frontend
+   # Backend - Check for lint errors
+   cd backend && make lint
+   # (Fix any lint errors manually)
+
+   # Frontend - Auto-fix formatting and linting
    cd ui && bun run check
    ```
 
-2. **Stage the formatted files**:
+2. **Stage the fixed files**:
    ```bash
    git add .
    ```
@@ -134,9 +139,10 @@ When you run `git commit`, the hook will **CHECK ONLY** (not auto-fix):
    ```
 
 This ensures:
-- Developers are aware of formatting issues before committing
+- Developers are aware of formatting AND linting issues before committing
 - CI validation is consistent with local pre-commit checks
 - No surprise auto-formatting in commits
+- Code quality is maintained from the first commit
 
 ## CI/CD Integration
 
diff --git a/backend/.golangci.yml b/backend/.golangci.yml
@@ -6,8 +6,10 @@ run:
 
 linters:
   disable:
-    - exportloopref  # Deprecated since Go 1.22
     - tenv           # Deprecated, replaced by usetesting
+    - gofumpt        # Use standalone gofumpt to avoid version conflicts
+    - gofmt          # Use standalone gofumpt to avoid version conflicts
+    - usetesting     # Best practice suggestion, not critical
 
   enable:
     # Critical linters
@@ -19,8 +21,6 @@ linters:
     - unused        # Check for unused code
 
     # Code quality
-    - gofmt         # Check formatting
-    - gofumpt       # Stricter gofmt
     - goimports     # Check imports formatting
     - misspell      # Find commonly misspelled words
     - unconvert     # Unnecessary type conversions
@@ -32,7 +32,6 @@ linters:
     - typecheck     # Type check
     - whitespace    # Detect leading/trailing whitespace
     - copyloopvar   # Replace exportloopref
-    - usetesting    # Replace tenv
 
 linters-settings:
   errcheck:
diff --git a/backend/Makefile b/backend/Makefile
@@ -18,15 +18,15 @@ install-tools: ## Install development tools (golangci-lint, gofumpt)
 	@go install mvdan.cc/gofumpt@latest
 	@echo "Tools installed successfully!"
 
-lint: ## Run golangci-lint
+lint: ## Run golangci-lint for linting and static analysis
 	@echo "Running golangci-lint..."
 	@$(GOLANGCI_LINT) run ./...
 
 fmt: ## Format code with gofumpt
 	@echo "Formatting code with gofumpt..."
 	@$(GOFUMPT) -l -w .
 
-fmt-check: ## Check if code is formatted
+fmt-check: ## Check if code is formatted with gofumpt
 	@echo "Checking code formatting..."
 	@$(GOFUMPT) -l . | grep . && echo "Code is not formatted. Run 'make fmt' to fix." && exit 1 || echo "Code is formatted correctly."
 
diff --git a/backend/internal/api/directory.go b/backend/internal/api/directory.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"html/template"
 	"io/fs"
+	"log/slog"
 	"net/http"
 	"os"
 	"path/filepath"
@@ -153,7 +154,10 @@ func renderDirectoryListing(c *gin.Context, path string, files []FileInfo) {
 	}
 
 	c.Header("Content-Type", "text/html; charset=utf-8")
-	tmpl.Execute(c.Writer, data)
+	if err := tmpl.Execute(c.Writer, data); err != nil {
+		slog.Error("failed to execute template", slog.Any("error", err))
+		ErrorResponse(c, http.StatusInternalServerError, ErrCodeInternalError, "Failed to generate directory listing")
+	}
 }
 
 // WalkDirectory recursively walks a directory and returns all files.
diff --git a/backend/internal/api/directory_test.go b/backend/internal/api/directory_test.go
@@ -419,18 +419,3 @@ func TestDirectoryHandlerDirectorySizeDisplay(t *testing.T) {
 		t.Error("HTML should show '7 B' for file size")
 	}
 }
-
-// Helper function for min/max.
-func min(a, b int) int {
-	if a < b {
-		return a
-	}
-	return b
-}
-
-func max(a, b int) int {
-	if a > b {
-		return a
-	}
-	return b
-}
diff --git a/backend/internal/db/sqlite.go b/backend/internal/db/sqlite.go
@@ -20,16 +20,6 @@ const (
 	isoSelectFields = `id, name, version, arch, edition, file_type, filename, file_path, download_link,
 		size_bytes, checksum, checksum_type, download_url, checksum_url,
 		status, progress, error_message, created_at, completed_at`
-
-	isoInsertFields = `id, name, version, arch, edition, file_type, filename, file_path, download_link,
-		size_bytes, checksum, checksum_type, download_url, checksum_url,
-		status, progress, error_message, created_at, completed_at`
-
-	isoUpdateFields = `name = ?, version = ?, arch = ?, edition = ?, file_type = ?,
-		filename = ?, file_path = ?, download_link = ?,
-		size_bytes = ?, checksum = ?, checksum_type = ?,
-		download_url = ?, checksum_url = ?, status = ?, progress = ?,
-		error_message = ?, completed_at = ?`
 )
 
 // DB wraps the SQLite database connection.
@@ -219,7 +209,7 @@ func (db *DB) GetISO(id string) (*models.ISO, error) {
 // ListISOs retrieves all ISOs ordered by created_at DESC.
 func (db *DB) ListISOs() ([]models.ISO, error) {
 	query := fmt.Sprintf("SELECT %s FROM isos ORDER BY created_at DESC", isoSelectFields)
-	rows, err := db.conn.Query(query)
+	rows, err := db.conn.Query(query) //nolint:sqlclosecheck // False positive: rows are closed via deferred closure below
 	if err != nil {
 		return nil, fmt.Errorf("failed to query ISO list: %w", err)
 	}
diff --git a/backend/internal/download/worker.go b/backend/internal/download/worker.go
@@ -145,7 +145,9 @@ func (w *Worker) download(ctx context.Context, iso *models.ISO, destPath string)
 	err := httputil.DownloadFileWithProgress(ctx, iso.DownloadURL, destPath, 32*1024, func(downloaded, total int64) {
 		// Update database with total size on first callback
 		if iso.SizeBytes == 0 && total > 0 {
-			w.db.UpdateISOSize(iso.ID, total)
+			if err := w.db.UpdateISOSize(iso.ID, total); err != nil {
+				slog.Warn("failed to update ISO size", slog.Any("error", err))
+			}
 			iso.SizeBytes = total
 		}
 
@@ -192,17 +194,23 @@ func (w *Worker) verifyChecksum(iso *models.ISO, filepath string) error {
 	}
 
 	// Update database with verified checksum
-	w.db.UpdateISOChecksum(iso.ID, actualChecksum)
+	if err := w.db.UpdateISOChecksum(iso.ID, actualChecksum); err != nil {
+		slog.Warn("failed to update ISO checksum", slog.Any("error", err))
+	}
 	iso.Checksum = actualChecksum
 
 	return nil
 }
 
 // updateStatus updates the ISO status and triggers progress callback.
 func (w *Worker) updateStatus(isoID string, status models.ISOStatus, progress int, errorMsg string) {
-	w.db.UpdateISOStatus(isoID, status, errorMsg)
+	if err := w.db.UpdateISOStatus(isoID, status, errorMsg); err != nil {
+		slog.Warn("failed to update ISO status", slog.Any("error", err))
+	}
 	if progress >= 0 {
-		w.db.UpdateISOProgress(isoID, progress)
+		if err := w.db.UpdateISOProgress(isoID, progress); err != nil {
+			slog.Warn("failed to update ISO progress", slog.Any("error", err))
+		}
 	}
 
 	if w.progressCallback != nil {
diff --git a/backend/internal/download/worker_test.go b/backend/internal/download/worker_test.go
@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"io"
 	"net/http"
 	"net/http/httptest"
 	"os"
@@ -517,12 +516,3 @@ func TestWorkerTempFileCleanup(t *testing.T) {
 		t.Errorf("Temp file should be cleaned up: %s", tmpFile)
 	}
 }
-
-// Helper to create a test HTTP server that serves content.
-func createTestServer(content []byte) *httptest.Server {
-	return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		w.Header().Set("Content-Length", fmt.Sprintf("%d", len(content)))
-		w.WriteHeader(http.StatusOK)
-		io.WriteString(w, string(content))
-	}))
-}
diff --git a/backend/internal/service/iso_service.go b/backend/internal/service/iso_service.go
@@ -64,7 +64,10 @@ func (s *ISOService) CreateISO(req CreateISORequest) (*models.ISO, error) {
 	}
 
 	if exists {
-		existingISO, _ := s.db.GetISOByComposite(normalizedName, req.Version, req.Arch, req.Edition, fileType)
+		existingISO, err := s.db.GetISOByComposite(normalizedName, req.Version, req.Arch, req.Edition, fileType)
+		if err != nil {
+			return nil, fmt.Errorf("failed to get existing ISO: %w", err)
+		}
 		return nil, &ISOAlreadyExistsError{ExistingISO: existingISO}
 	}
 
diff --git a/backend/internal/testutil/httputil.go b/backend/internal/testutil/httputil.go
@@ -75,7 +75,7 @@ func NewMockDownloadServer(t *testing.T, fileSize int, statusCode int) *httptest
 		for i := range content {
 			content[i] = byte('A' + (i % 26))
 		}
-		w.Write(content)
+		_, _ = w.Write(content) //nolint:errcheck // Test utility, errors will cause test failures anyway
 	}))
 }
 
diff --git a/backend/internal/ws/client.go b/backend/internal/ws/client.go
@@ -47,9 +47,9 @@ func (c *Client) readPump() {
 	}()
 
 	c.conn.SetReadLimit(maxMessageSize)
-	c.conn.SetReadDeadline(time.Now().Add(pongWait))
+	_ = c.conn.SetReadDeadline(time.Now().Add(pongWait)) //nolint:errcheck // Deadline errors are non-critical in WebSocket cleanup
 	c.conn.SetPongHandler(func(string) error {
-		c.conn.SetReadDeadline(time.Now().Add(pongWait))
+		_ = c.conn.SetReadDeadline(time.Now().Add(pongWait)) //nolint:errcheck // Deadline errors are non-critical in WebSocket cleanup
 		return nil
 	})
 
@@ -77,32 +77,32 @@ func (c *Client) writePump() {
 	for {
 		select {
 		case message, ok := <-c.send:
-			c.conn.SetWriteDeadline(time.Now().Add(writeWait))
+			_ = c.conn.SetWriteDeadline(time.Now().Add(writeWait)) //nolint:errcheck // Deadline errors are non-critical
 			if !ok {
 				// Hub closed the channel
-				c.conn.WriteMessage(websocket.CloseMessage, []byte{})
+				_ = c.conn.WriteMessage(websocket.CloseMessage, []byte{}) //nolint:errcheck // Close message is best-effort
 				return
 			}
 
 			w, err := c.conn.NextWriter(websocket.TextMessage)
 			if err != nil {
 				return
 			}
-			w.Write(message)
+			_, _ = w.Write(message) //nolint:errcheck // Write errors handled by Close()
 
 			// Add queued messages to the current WebSocket message
 			n := len(c.send)
 			for i := 0; i < n; i++ {
-				w.Write([]byte{'\n'})
-				w.Write(<-c.send)
+				_, _ = w.Write([]byte{'\n'}) //nolint:errcheck // Write errors handled by Close()
+				_, _ = w.Write(<-c.send)     //nolint:errcheck // Write errors handled by Close()
 			}
 
 			if err := w.Close(); err != nil {
 				return
 			}
 
 		case <-ticker.C:
-			c.conn.SetWriteDeadline(time.Now().Add(writeWait))
+			_ = c.conn.SetWriteDeadline(time.Now().Add(writeWait)) //nolint:errcheck // Deadline errors are non-critical
 			if err := c.conn.WriteMessage(websocket.PingMessage, nil); err != nil {
 				return
 			}
diff --git a/package.json b/package.json
@@ -11,7 +11,10 @@
     "lint-staged": "^15.3.0"
   },
   "lint-staged": {
-    "backend/**/*.go": "make -C backend fmt-check",
+    "backend/**/*.go": [
+      "make -C backend fmt-check",
+      "make -C backend lint"
+    ],
     "ui/**/*.{ts,tsx,js,jsx,json,css}": "cd ui && bun run check-only"
   }
 }
