Merge pull request #71 from alpacahq/nil-v2-agg-fix

Fix error when aggregate result is empty

Author: ttt733

alpaca_trade_api/polygon/entity.py

@@ -81,8 +81,9 @@ def df(self):
 
 class Aggsv2(list):
     def __init__(self, raw):
+        results = raw['results'] if raw.get('results') else []
         super().__init__(
-            Agg(tick) for tick in raw['results']
+            [Agg(tick) for tick in results]
         )
         self._raw = raw
 

tests/test_polygon/test_rest.py

@@ -9,8 +9,10 @@ def reqmock():
         yield m
 
 
-def endpoint(path, params=''):
-    return 'https://api.polygon.io/v1{}?apiKey=key-id&{}'.format(path, params)
+def endpoint(path, params='', api_version='v1'):
+    return 'https://api.polygon.io/{}{}?{}&apiKey=key-id'.format(
+      api_version, path, params
+    )
 
 
 def test_polygon(reqmock):
@@ -216,6 +218,42 @@ def test_polygon(reqmock):
     assert len(aggs) == 1
     assert aggs.df.iloc[0].high == 173.21
 
+# Historic Aggregates V2
+    reqmock.get(
+        endpoint(
+          '/aggs/ticker/AAPL/range/1/day/2018-2-2/2018-2-5',
+          params='unadjusted=False', api_version='v2'
+        ),
+        text='''
+{
+  "ticker": "AAPL",
+  "status": "OK",
+  "adjusted": true,
+  "queryCount": 55,
+  "resultsCount": 2,
+  "results": [
+    {
+      "o": 173.15,
+      "c": 173.2,
+      "l": 173.15,
+      "h": 173.21,
+      "v": 1800,
+      "t": 1517529605000
+    }
+  ]
+}''')
+
+    aggs = cli.historic_agg_v2(
+      'AAPL', 1, 'day',
+      _from='2018-2-2',
+      to='2018-2-5'
+    )
+    assert aggs[0].o == 173.15
+    assert len(aggs) == 1
+    assert aggs.df.iloc[0].h == 173.21
+    with pytest.raises(AttributeError):
+        aggs[0].foo
+
     # Last Trade
     reqmock.get(
         endpoint('/last/stocks/AAPL'),