Skip to content

Commit cdc49ac

Browse files
committed
after testing thorougly, confirming the workflow
1 parent e90fa73 commit cdc49ac

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

.github/workflows/cd.yaml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ jobs:
4141
environment: ${{ env.ENVIRONMENT }}
4242
steps:
4343
- uses: actions/checkout@v3
44-
# with:
45-
# token: ${{ secrets.GITHUB_TOKEN }}
4644
- name: Check changed files
4745
id: filter
4846
uses: dorny/paths-filter@v2
@@ -66,8 +64,6 @@ jobs:
6664
service: ${{ matrix.service }}
6765
steps:
6866
- uses: actions/checkout@v3
69-
# with:
70-
# token: ${{ secrets.GITHUB_TOKEN }}
7167
- name: Configure AWS ECR Details
7268
uses: aws-actions/configure-aws-credentials@v3
7369
with:
@@ -122,10 +118,9 @@ jobs:
122118
123119
- name: Update Docker image tag in Helm values
124120
env:
125-
SHORT_TAG: ${{ github.sha }}
126121
CLUSTER_NAME: ${{ vars.CLUSTER_NAME }}
127122
run: |
128-
SHORT_TAG=${SHORT_TAG::7}
123+
SHORT_TAG=${COMMIT::7}
129124
VALUES_FILE="deployments/clusters/$CLUSTER_NAME/values/strata-apps-values.yaml"
130125
131126
if [[ "${{ needs.detect-changes.outputs.frontend_changed }}" == "true" ]]; then
@@ -138,12 +133,11 @@ jobs:
138133
fi
139134
- name: Commit and push changes
140135
env:
141-
SHORT_TAG: ${{ github.sha }}
142136
GH_ACTIONS_USER_NAME: ${{ vars.GH_ACTIONS_USER_NAME }}
143137
CLUSTER_NAME: ${{ vars.CLUSTER_NAME }}
144138
BRANCH_OF_DEPLOYMENT_REPO: ${{ vars.BRANCH_OF_DEPLOYMENT_REPO }}
145139
run: |
146-
SHORT_TAG=${SHORT_TAG::7}
140+
SHORT_TAG=${COMMIT::7}
147141
cd deployments
148142
git config user.name "$GH_ACTIONS_USER_NAME"
149143
git config user.email "$GH_ACTIONS_USER_NAME@alpenlabs.io"

0 commit comments

Comments
 (0)