Skip to content

Commit 47a09fd

Browse files
committed
Make the deadline field more agnostic
- optional no longer mandatory
1 parent 3c36d0b commit 47a09fd

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

app/models/request.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ class Request < ApplicationRecord
33
has_many :users, through: :collaborations
44
has_one :response
55

6-
validates :source_id, :source_app, :requester_name, :requester_email, :status, :current_content, :deadline, presence: true
6+
validates :source_id, :source_app, :requester_name, :requester_email, :status, :current_content, presence: true
77
scope :for_source, ->(source_id) { where(source_id: source_id) }
88
scope :most_recent_first, -> { order(created_at: :desc) }
99
scope :most_recent_for_source, ->(source_id) { for_source(source_id).most_recent_first.first }

db/migrate/20260107162918_create_requests.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def change
1212
t.string :status, null: false, default: 'in_progress'
1313
t.text :previous_content
1414
t.text :current_content, null: false
15-
t.datetime :deadline, null: false
15+
t.datetime :deadline
1616

1717
t.timestamps
1818
end

db/schema.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
t.string "status", default: "in_progress", null: false
3434
t.text "previous_content"
3535
t.text "current_content", null: false
36-
t.datetime "deadline", null: false
36+
t.datetime "deadline"
3737
t.datetime "created_at", null: false
3838
t.datetime "updated_at", null: false
3939
t.string "source_app", null: false

spec/models/request_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
expect(record).not_to be_valid
88
end
99

10-
it "includes errors for each missing attribute" do
10+
it "includes errors for each missing mandatory attribute" do
1111
record = described_class.new
1212
record.valid?
1313

14-
expect(record.errors.attribute_names).to include(:source_id, :source_app, :requester_name, :requester_email, :current_content, :deadline)
14+
expect(record.errors.attribute_names).to include(:source_id, :source_app, :requester_name, :requester_email, :current_content)
1515
end
1616

1717
it "is valid when all required attributes are set" do

0 commit comments

Comments
 (0)