Skip to content

Commit a222bf5

Browse files
authored
Merge pull request #23 from alphagov/revert-15-add-needed-frontend-framework-changes
Revert "Setup UI environment for Fact Check Manager"
2 parents 8c164fe + 9d7bf7f commit a222bf5

File tree

10 files changed

+19
-186
lines changed

10 files changed

+19
-186
lines changed

Gemfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ source "https://rubygems.org"
33
# Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
44
gem "rails", "8.0.3"
55
# The original asset pipeline for Rails [https://github.com/rails/sprockets-rails]
6+
gem "sprockets-rails"
67
# Use sqlite3 as the database for Active Record
78
# gem "sqlite3", ">= 1.4"
89
# # Use the Puma web server [https://github.com/puma/puma]
@@ -11,14 +12,14 @@ gem "rails", "8.0.3"
1112
# gem "importmap-rails"
1213

1314
gem "bootsnap", require: false
15+
gem "bootstrap-sass"
1416
gem "dartsass-rails"
1517
gem "erb_lint"
1618
gem "gds-api-adapters"
1719
gem "gds-sso"
1820
gem "govuk_app_config", "~> 9.22.3"
1921
gem "govuk_publishing_components"
2022
gem "govuk_sidekiq"
21-
gem "nokodiff"
2223
gem "pg"
2324
gem "plek"
2425
gem "sentry-sidekiq"

Gemfile.lock

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ GEM
7575
addressable (2.8.8)
7676
public_suffix (>= 2.0.2, < 8.0)
7777
ast (2.4.3)
78+
autoprefixer-rails (10.4.21.0)
79+
execjs (~> 2)
7880
base64 (0.3.0)
7981
benchmark (0.5.0)
8082
better_html (2.2.0)
@@ -87,6 +89,9 @@ GEM
8789
bigdecimal (3.3.1)
8890
bootsnap (1.19.0)
8991
msgpack (~> 1.2)
92+
bootstrap-sass (3.4.1)
93+
autoprefixer-rails (>= 5.2.1)
94+
sassc (>= 2.0.0)
9095
brakeman (7.1.1)
9196
racc
9297
builder (3.3.0)
@@ -181,16 +186,6 @@ GEM
181186
rake (>= 13)
182187
googleapis-common-protos-types (1.22.0)
183188
google-protobuf (~> 4.26)
184-
govspeak (10.8.6)
185-
actionview (>= 6, < 8.1.2)
186-
addressable (>= 2.3.8, < 2.8.9)
187-
govuk_publishing_components (>= 43)
188-
htmlentities (~> 4)
189-
i18n (>= 0.7, < 1.14.9)
190-
kramdown (>= 2.3.1, < 2.5.3)
191-
nokogiri (~> 1.12)
192-
rinku (~> 2.0)
193-
sanitize (>= 6, < 8)
194189
govuk_app_config (9.22.3)
195190
connection_pool (< 3)
196191
logstasher (~> 2.1)
@@ -228,7 +223,6 @@ GEM
228223
puma
229224
selenium-webdriver (>= 4.0)
230225
hashie (5.0.0)
231-
htmlentities (4.4.2)
232226
http-accept (1.7.0)
233227
http-cookie (1.1.0)
234228
domain_name (~> 0.5)
@@ -287,13 +281,6 @@ GEM
287281
net-protocol
288282
netrc (0.11.0)
289283
nio4r (2.7.5)
290-
nokodiff (0.2.0)
291-
actionview (>= 6, < 8.1.3)
292-
diff-lcs
293-
gds-api-adapters (>= 101.0, < 101.3)
294-
govspeak (>= 10.6.3)
295-
rails (>= 6, < 8.1.3)
296-
view_component (~> 4)
297284
nokogiri (1.18.10-aarch64-linux-gnu)
298285
racc (~> 1.4)
299286
nokogiri (1.18.10-aarch64-linux-musl)
@@ -591,7 +578,6 @@ GEM
591578
mime-types (>= 1.16, < 4.0)
592579
netrc (~> 0.8)
593580
rexml (3.4.4)
594-
rinku (2.0.6)
595581
rouge (4.6.1)
596582
rspec-core (3.13.6)
597583
rspec-support (~> 3.13.0)
@@ -648,9 +634,6 @@ GEM
648634
rubocop (~> 1.72, >= 1.72.1)
649635
ruby-progressbar (1.13.0)
650636
rubyzip (3.2.2)
651-
sanitize (7.0.0)
652-
crass (~> 1.0.2)
653-
nokogiri (>= 1.16.8)
654637
sass-embedded (1.94.2-aarch64-linux-gnu)
655638
google-protobuf (~> 4.31)
656639
sass-embedded (1.94.2-aarch64-linux-musl)
@@ -667,6 +650,8 @@ GEM
667650
google-protobuf (~> 4.31)
668651
sass-embedded (1.94.2-x86_64-linux-musl)
669652
google-protobuf (~> 4.31)
653+
sassc (2.4.0)
654+
ffi (~> 1.9)
670655
securerandom (0.4.1)
671656
selenium-webdriver (4.38.0)
672657
base64 (~> 0.2)
@@ -724,10 +709,6 @@ GEM
724709
uri (1.1.1)
725710
useragent (0.16.11)
726711
version_gem (1.1.9)
727-
view_component (4.2.0)
728-
actionview (>= 7.1.0)
729-
activesupport (>= 7.1.0)
730-
concurrent-ruby (~> 1)
731712
warden (1.2.9)
732713
rack (>= 2.0.9)
733714
warden-oauth2 (0.0.1)
@@ -758,6 +739,7 @@ PLATFORMS
758739

759740
DEPENDENCIES
760741
bootsnap
742+
bootstrap-sass
761743
byebug
762744
dartsass-rails
763745
erb_lint
@@ -769,7 +751,6 @@ DEPENDENCIES
769751
govuk_sidekiq
770752
govuk_test
771753
listen
772-
nokodiff
773754
pg
774755
plek
775756
rails (= 8.0.3)
@@ -779,6 +760,7 @@ DEPENDENCIES
779760
sidekiq
780761
simplecov (~> 0.22)
781762
simplecov-html (~> 0.12)
763+
sprockets-rails
782764
terser
783765
uglifier
784766

app/assets/config/manifest.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
//= link_tree ../images
2-
//= link application.js
3-
//= link_tree ../builds
2+
//= link_directory ../stylesheets .css
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
// require_directory ./modules
1+
//= require_directory ./modules
22

33
//= require govuk_publishing_components/dependencies
44
//= require govuk_publishing_components/lib
55

66
// Analytics modules
7-
// require analytics_modules/ga4-form-setup
8-
// require analytics_modules/ga4-form-change-tracker
9-
// require analytics_modules/ga4-index-section-setup
7+
//= require analytics_modules/ga4-form-setup
8+
//= require analytics_modules/ga4-form-change-tracker
9+
//= require analytics_modules/ga4-index-section-setup
1010

1111
window.GOVUK.approveAllCookieTypes()
1212
window.GOVUK.cookie('cookies_preferences_set', 'true', { days: 365 })
Lines changed: 1 addition & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,3 @@
11
$govuk-page-width: 1140px;
22

3-
// GOVUK Design System
4-
@import 'govuk_publishing_components/govuk_frontend_support';
5-
@import 'govuk_publishing_components/component_support';
6-
@import 'govuk_publishing_components/components/accordion';
7-
@import 'govuk_publishing_components/components/add-another';
8-
@import 'govuk_publishing_components/components/back-link';
9-
@import 'govuk_publishing_components/components/button';
10-
@import 'govuk_publishing_components/components/checkboxes';
11-
@import 'govuk_publishing_components/components/date-input';
12-
@import 'govuk_publishing_components/components/details';
13-
@import 'govuk_publishing_components/components/document-list';
14-
@import 'govuk_publishing_components/components/emergency-banner';
15-
@import 'govuk_publishing_components/components/error-alert';
16-
@import 'govuk_publishing_components/components/error-message';
17-
@import 'govuk_publishing_components/components/error-summary';
18-
@import 'govuk_publishing_components/components/fieldset';
19-
@import 'govuk_publishing_components/components/govspeak';
20-
@import 'govuk_publishing_components/components/heading';
21-
@import 'govuk_publishing_components/components/hint';
22-
@import 'govuk_publishing_components/components/input';
23-
@import 'govuk_publishing_components/components/inset-text';
24-
@import 'govuk_publishing_components/components/label';
25-
@import 'govuk_publishing_components/components/layout-footer';
26-
@import 'govuk_publishing_components/components/layout-for-admin';
27-
@import 'govuk_publishing_components/components/layout-header';
28-
@import 'govuk_publishing_components/components/lead-paragraph';
29-
@import 'govuk_publishing_components/components/notice';
30-
@import 'govuk_publishing_components/components/radio';
31-
@import 'govuk_publishing_components/components/reorderable-list';
32-
@import 'govuk_publishing_components/components/search';
33-
@import 'govuk_publishing_components/components/secondary-navigation';
34-
@import 'govuk_publishing_components/components/select';
35-
@import 'govuk_publishing_components/components/select-with-search';
36-
@import 'govuk_publishing_components/components/service-navigation';
37-
@import 'govuk_publishing_components/components/skip-link';
38-
@import 'govuk_publishing_components/components/success-alert';
39-
@import 'govuk_publishing_components/components/summary-card';
40-
@import 'govuk_publishing_components/components/summary-list';
41-
@import 'govuk_publishing_components/components/table';
42-
@import 'govuk_publishing_components/components/tabs';
43-
@import 'govuk_publishing_components/components/tag';
44-
@import 'govuk_publishing_components/components/textarea';
45-
@import 'govuk_publishing_components/components/warning-text';
46-
3+
@import 'govuk_publishing_components/govuk_frontend_support';

app/controllers/application_controller.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
class ApplicationController < ActionController::Base
22
protect_from_forgery with: :exception
3-
layout "design_system"
3+
layout "application"
44

55
include GDS::SSO::ControllerMethods
66

77
before_action :authenticate_user!
8+
89
def hello_world
910
render "hello_world"
1011
end

app/views/layouts/design_system.html.erb

Lines changed: 0 additions & 87 deletions
This file was deleted.

config/application.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
require "action_view/railtie"
1414
# require "action_cable/engine"
1515
require "rails/test_unit/railtie"
16-
require "sprockets/railtie"
1716

1817
require "open-uri"
1918
require "builder"

config/assets.rb

Lines changed: 0 additions & 12 deletions
This file was deleted.

config/initializers/dartsass.rb

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)