Merge pull request #40 from alphagov/main-7285-create-ui-for-factcheck-unhappy-path

MAIN-7285 - Add frontend handling for "unhappy" fact check response

Author: Tetrino

app/views/application/confirm_response.html.erb

@@ -2,6 +2,9 @@
 <% content_for :title_context, @form_data[:page_title] %>
 <% content_for :back_link, respond_path(back: :true) %>
 <% content_for :title, t("fact_check_verification.heading") %>
+<% if @errors.any? %>
+  <% content_for :error_summary, render(partial: "application/errors/submission_error_summary") %>
+<% end %>
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
     <%= form_with url: confirm_response_path,
@@ -21,8 +24,16 @@
               t("fact_check_response.correct") :
               t("fact_check_response.incorrect"),
           },
-        ],
-        margin_bottom: 6,
+          (@form_data[:status] == "incorrect" ? {
+            field: t("fact_check_verification.factual_errors"),
+            edit: {
+              href: respond_path(back: :true),
+              text: t("fact_check_verification.change_link"),
+            },
+            value: simple_format(@form_data[:details]),
+          } : nil),
+        ].compact,
+        margin_bottom: 9,
       } %>
 
       <%= render "govuk_publishing_components/components/heading", {

…mations/_response_error_summary.html.erb …/errors/_response_error_summary.html.erbapp/views/application/confirmations/_response_error_summary.html.erb renamed to app/views/application/errors/_response_error_summary.html.erb app/views/application/confirmations/_response_error_summary.html.erb renamed to app/views/application/errors/_response_error_summary.html.erb

@@ -0,0 +1,5 @@
+<%= render "govuk_publishing_components/components/error_alert", {
+  id: "api_submission_failed",
+  message: t("fact_check_verification.error_heading"),
+  description: t("fact_check_verification.error_description"),
+} %>

app/views/application/errors/_submission_error_summary.html.erb

@@ -3,7 +3,7 @@
 <% content_for :back_link, "_blank" %>
 <% content_for :title, t("fact_check_response.heading") %>
 <% if @errors.any? %>
-  <% content_for :error_summary, render(partial: "application/confirmations/response_error_summary") %>
+  <% content_for :error_summary, render(partial: "application/errors/response_error_summary") %>
 <% end %>
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
@@ -30,7 +30,7 @@
             text: t("fact_check_response.incorrect"),
             id: "incorrect",
             checked: @errors[:details].present? || @form_data.present? &&  @form_data["status"] == "incorrect",
-            conditional: render(partial: "application/confirmations/factual_error_textarea"),
+            conditional: render(partial: "application/partials/factual_error_textarea"),
           },
         ],
       } %>

app/views/application/fact_check_response.html.erb

@@ -6,6 +6,8 @@
             name: "fact_check_response[details]",
             textarea_id: "fact_check_details",
             hint: sanitize(t("fact_check_response.factual_errors_hint")),
+            value: @form_data&.dig("details"),
             error: @errors[:details].presence,
+            error_message: @errors[:details].present? ? t("fact_check_response.factual_errors_empty_field") : nil,
             rows: 18,
           } %>

…mations/_factual_error_textarea.html.erb …artials/_factual_error_textarea.html.erbapp/views/application/confirmations/_factual_error_textarea.html.erb renamed to app/views/application/partials/_factual_error_textarea.html.erb app/views/application/confirmations/_factual_error_textarea.html.erb renamed to app/views/application/partials/_factual_error_textarea.html.erb

@@ -29,6 +29,8 @@ en:
     send_response: "Now send your response"
     send_response_warning: "Only one fact check response can be submitted. Make sure you’ve discussed this with colleagues first."
     confirm_button: "Confirm and send"
+    error_heading: "There was a problem"
+    error_description: "Please try submitting again"
   fact_check_submitted:
     fact_check_submitted: "Fact check submitted"
     fact_check_description: "Your response has been sent"

config/locales/en.yml

@@ -63,5 +63,53 @@
       expect(page).to have_text(I18n.t("fact_check_response.continue_button"))
       expect(page).to have_checked_field(I18n.t("fact_check_response.correct"), visible: :all)
     end
+
+    it "allows the user to enter content into the factual error textbox and have it persist to confirmation" do
+      visit respond_path
+
+      expect(page).to have_text(I18n.t("fact_check_response.heading"))
+      expect(page).to have_text(I18n.t("fact_check_response.form_heading"))
+      expect(page).to have_text(I18n.t("fact_check_response.correct"))
+      expect(page).to have_text(I18n.t("fact_check_response.incorrect"))
+      expect(page).to have_button(I18n.t("fact_check_response.continue_button"))
+
+      choose(I18n.t("fact_check_response.incorrect"), allow_label_click: true)
+      page.fill_in "fact_check_details", with: "Fact check error detail test string"
+
+      click_button(I18n.t("fact_check_response.continue_button"))
+
+      expect(page).to have_text(I18n.t("fact_check_response.incorrect"))
+      expect(page).to have_text(I18n.t("fact_check_verification.factual_errors"))
+      expect(page).to have_text("Fact check error detail test string")
+    end
+
+    it "allows the user to click the change link without losing the detail contents for an incorrect response" do
+      visit respond_path
+
+      expect(page).to have_text(I18n.t("fact_check_response.heading"))
+      expect(page).to have_text(I18n.t("fact_check_response.form_heading"))
+      expect(page).to have_text(I18n.t("fact_check_response.correct"))
+      expect(page).to have_text(I18n.t("fact_check_response.incorrect"))
+      expect(page).to have_button(I18n.t("fact_check_response.continue_button"))
+
+      choose(I18n.t("fact_check_response.incorrect"), allow_label_click: true)
+      page.fill_in "fact_check_details", with: "Fact check error detail test string"
+
+      click_button(I18n.t("fact_check_response.continue_button"))
+
+      expect(page).to have_text(I18n.t("fact_check_response.incorrect"))
+      expect(page).to have_text(I18n.t("fact_check_verification.factual_errors"))
+      expect(page).to have_text("Fact check error detail test string")
+
+      click_link(I18n.t("fact_check_verification.change_link"), match: :first)
+
+      expect(page).to have_text(I18n.t("fact_check_response.heading"))
+      expect(page).to have_text(I18n.t("fact_check_response.form_heading"))
+      expect(page).to have_text(I18n.t("fact_check_response.correct"))
+      expect(page).to have_text(I18n.t("fact_check_response.incorrect"))
+      expect(page).to have_text(I18n.t("fact_check_response.continue_button"))
+      expect(page).to have_checked_field(I18n.t("fact_check_response.incorrect"), visible: :all)
+      expect(page).to have_text("Fact check error detail test string")
+    end
   end
 end