Remove daily_submission_emails_enabled feature flag

Author: SamJamCul

infra/deployments/forms/forms-admin/main.tf

@@ -25,7 +25,6 @@ module "forms_admin" {
   analytics_enabled                 = var.forms_admin_settings.analytics_enabled
   act_as_user_enabled               = var.forms_admin_settings.act_as_user_enabled
   welsh_enabled                     = var.forms_admin_settings.welsh_enabled
-  daily_submission_emails_enabled   = var.forms_admin_settings.daily_submission_emails_enabled
   org_admin_alerts_enabled          = var.forms_admin_settings.org_admin_alerts_enabled
   enable_mailchimp_sync             = var.forms_admin_settings.synchronize_to_mailchimp
   enable_organisations_sync         = var.forms_admin_settings.synchronize_orgs_from_govuk

infra/deployments/forms/inputs.tf

@@ -129,22 +129,21 @@ EOF
 variable "forms_admin_settings" {
   description = "Forms Admin configuration values"
   type = object({
-    cpu                             = number
-    memory                          = number
-    min_capacity                    = number
-    max_capacity                    = number
-    enable_maintenance_mode         = bool
-    auth_provider                   = string
-    previous_auth_provider          = string
-    cloudwatch_metrics_enabled      = bool
-    analytics_enabled               = bool
-    act_as_user_enabled             = bool
-    welsh_enabled                   = bool
-    daily_submission_emails_enabled = bool
-    org_admin_alerts_enabled        = bool
-    govuk_app_domain                = string
-    synchronize_to_mailchimp        = bool
-    synchronize_orgs_from_govuk     = bool
+    cpu                         = number
+    memory                      = number
+    min_capacity                = number
+    max_capacity                = number
+    enable_maintenance_mode     = bool
+    auth_provider               = string
+    previous_auth_provider      = string
+    cloudwatch_metrics_enabled  = bool
+    analytics_enabled           = bool
+    act_as_user_enabled         = bool
+    welsh_enabled               = bool
+    org_admin_alerts_enabled    = bool
+    govuk_app_domain            = string
+    synchronize_to_mailchimp    = bool
+    synchronize_orgs_from_govuk = bool
   })
   nullable = false
 }

infra/deployments/forms/tfvars/dev.tfvars

@@ -68,22 +68,21 @@ container_registry      = "711966560482.dkr.ecr.eu-west-2.amazonaws.com"
 dlq_arn                 = "arn:aws:sqs:eu-west-2:711966560482:eventbridge-dead-letter-queue"
 send_logs_to_cyber      = true
 forms_admin_settings = {
-  cpu                             = 256
-  memory                          = 512
-  min_capacity                    = 3
-  max_capacity                    = 3
-  enable_maintenance_mode         = false
-  auth_provider                   = "auth0"
-  previous_auth_provider          = null
-  cloudwatch_metrics_enabled      = true
-  analytics_enabled               = true
-  act_as_user_enabled             = true
-  welsh_enabled                   = true
-  daily_submission_emails_enabled = true
-  org_admin_alerts_enabled        = true
-  govuk_app_domain                = "integration.publishing.service.gov.uk"
-  synchronize_to_mailchimp        = false
-  synchronize_orgs_from_govuk     = false
+  cpu                         = 256
+  memory                      = 512
+  min_capacity                = 3
+  max_capacity                = 3
+  enable_maintenance_mode     = false
+  auth_provider               = "auth0"
+  previous_auth_provider      = null
+  cloudwatch_metrics_enabled  = true
+  analytics_enabled           = true
+  act_as_user_enabled         = true
+  welsh_enabled               = true
+  org_admin_alerts_enabled    = true
+  govuk_app_domain            = "integration.publishing.service.gov.uk"
+  synchronize_to_mailchimp    = false
+  synchronize_orgs_from_govuk = false
 }
 forms_product_page_settings = {
   cpu          = 256

infra/deployments/forms/tfvars/production.tfvars

@@ -124,22 +124,21 @@ container_registry      = "711966560482.dkr.ecr.eu-west-2.amazonaws.com"
 dlq_arn                 = "arn:aws:sqs:eu-west-2:711966560482:eventbridge-dead-letter-queue"
 send_logs_to_cyber      = true
 forms_admin_settings = {
-  cpu                             = 512
-  memory                          = 1024
-  min_capacity                    = 6
-  max_capacity                    = 36
-  enable_maintenance_mode         = false
-  auth_provider                   = "auth0"
-  previous_auth_provider          = null
-  cloudwatch_metrics_enabled      = true
-  analytics_enabled               = true
-  act_as_user_enabled             = false
-  welsh_enabled                   = true
-  daily_submission_emails_enabled = true
-  org_admin_alerts_enabled        = false
-  govuk_app_domain                = "publishing.service.gov.uk"
-  synchronize_to_mailchimp        = true
-  synchronize_orgs_from_govuk     = true
+  cpu                         = 512
+  memory                      = 1024
+  min_capacity                = 6
+  max_capacity                = 36
+  enable_maintenance_mode     = false
+  auth_provider               = "auth0"
+  previous_auth_provider      = null
+  cloudwatch_metrics_enabled  = true
+  analytics_enabled           = true
+  act_as_user_enabled         = false
+  welsh_enabled               = true
+  org_admin_alerts_enabled    = false
+  govuk_app_domain            = "publishing.service.gov.uk"
+  synchronize_to_mailchimp    = true
+  synchronize_orgs_from_govuk = true
 }
 forms_product_page_settings = {
   cpu          = 256

infra/deployments/forms/tfvars/staging.tfvars

@@ -33,22 +33,21 @@ container_registry      = "711966560482.dkr.ecr.eu-west-2.amazonaws.com"
 dlq_arn                 = "arn:aws:sqs:eu-west-2:711966560482:eventbridge-dead-letter-queue"
 send_logs_to_cyber      = true
 forms_admin_settings = {
-  cpu                             = 256
-  memory                          = 512
-  min_capacity                    = 3
-  max_capacity                    = 3
-  enable_maintenance_mode         = false
-  auth_provider                   = "auth0"
-  previous_auth_provider          = null
-  cloudwatch_metrics_enabled      = true
-  analytics_enabled               = true
-  act_as_user_enabled             = true
-  welsh_enabled                   = true
-  daily_submission_emails_enabled = true
-  org_admin_alerts_enabled        = false
-  govuk_app_domain                = "staging.publishing.service.gov.uk"
-  synchronize_to_mailchimp        = false
-  synchronize_orgs_from_govuk     = false
+  cpu                         = 256
+  memory                      = 512
+  min_capacity                = 3
+  max_capacity                = 3
+  enable_maintenance_mode     = false
+  auth_provider               = "auth0"
+  previous_auth_provider      = null
+  cloudwatch_metrics_enabled  = true
+  analytics_enabled           = true
+  act_as_user_enabled         = true
+  welsh_enabled               = true
+  org_admin_alerts_enabled    = false
+  govuk_app_domain            = "staging.publishing.service.gov.uk"
+  synchronize_to_mailchimp    = false
+  synchronize_orgs_from_govuk = false
 }
 forms_product_page_settings = {
   cpu          = 256

infra/deployments/forms/tfvars/user-research.tfvars

@@ -31,22 +31,21 @@ container_registry      = "711966560482.dkr.ecr.eu-west-2.amazonaws.com"
 dlq_arn                 = "arn:aws:sqs:eu-west-2:711966560482:eventbridge-dead-letter-queue"
 send_logs_to_cyber      = true
 forms_admin_settings = {
-  cpu                             = 256
-  memory                          = 512
-  min_capacity                    = 0
-  max_capacity                    = 0
-  enable_maintenance_mode         = false
-  auth_provider                   = "user_research"
-  previous_auth_provider          = null
-  cloudwatch_metrics_enabled      = false
-  analytics_enabled               = false
-  act_as_user_enabled             = false
-  welsh_enabled                   = true
-  daily_submission_emails_enabled = true
-  org_admin_alerts_enabled        = false
-  govuk_app_domain                = ""
-  synchronize_to_mailchimp        = false
-  synchronize_orgs_from_govuk     = false
+  cpu                         = 256
+  memory                      = 512
+  min_capacity                = 0
+  max_capacity                = 0
+  enable_maintenance_mode     = false
+  auth_provider               = "user_research"
+  previous_auth_provider      = null
+  cloudwatch_metrics_enabled  = false
+  analytics_enabled           = false
+  act_as_user_enabled         = false
+  welsh_enabled               = true
+  org_admin_alerts_enabled    = false
+  govuk_app_domain            = ""
+  synchronize_to_mailchimp    = false
+  synchronize_orgs_from_govuk = false
 }
 forms_product_page_settings = {
   cpu          = 256

infra/modules/forms-admin/main.tf

@@ -160,10 +160,6 @@ module "ecs_service" {
       name  = "SETTINGS__FEATURES__WELSH",
       value = var.welsh_enabled
     },
-    {
-      name  = "SETTINGS__FEATURES__DAILY_SUBMISSION_EMAILS_ENABLED",
-      value = var.daily_submission_emails_enabled
-    },
     {
       name  = "SETTINGS__FEATURES__ORG_ADMIN_ALERTS_ENABLED",
       value = var.org_admin_alerts_enabled

infra/modules/forms-admin/variables.tf

@@ -96,12 +96,6 @@ variable "welsh_enabled" {
   default     = false
 }
 
-variable "daily_submission_emails_enabled" {
-  type        = bool
-  description = "Enables the ability to configure sending daily emails with a CSV of all submissions for the previous day"
-  default     = false
-}
-
 variable "org_admin_alerts_enabled" {
   type        = bool
   description = "Enables sending alerts to Org Admins about forms they control"