-
Notifications
You must be signed in to change notification settings - Fork 7
Expand file tree
/
Copy pathbase_controller_spec.rb
More file actions
434 lines (352 loc) · 13.4 KB
/
base_controller_spec.rb
File metadata and controls
434 lines (352 loc) · 13.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
require "rails_helper"
RSpec.describe Forms::BaseController, type: :request do
let(:timestamp_of_request) { Time.utc(2022, 12, 14, 10, 0o0, 0o0) }
let(:form_response_data) do
build(
:v2_form_document,
:with_support,
id: 2,
start_page:,
privacy_policy_url: "http://www.example.gov.uk/privacy_policy",
what_happens_next_markdown: "Good things come to those that wait",
declaration_text: "agree to the declaration",
steps: steps_data,
language:,
)
end
let(:start_page) { 1 }
let(:language) { "en" }
let(:no_data_found_response) do
{
"error": "not_found",
}
end
let(:steps_data) do
[
(attributes_for :v2_question_page_step,
id: 1,
next_page: 2,
answer_type: "text",
answer_settings: { input_type: "single_line" }
),
(attributes_for :v2_question_page_step,
id: 2,
answer_type: "text",
answer_settings: { input_type: "single_line" }
),
]
end
let(:req_headers) { { "Accept" => "application/json" } }
let(:api_url_suffix) { "/live" }
let(:output) { StringIO.new }
let(:logger) do
ApplicationLogger.new(output).tap do |logger|
logger.formatter = JsonLogFormatter.new
end
end
before do
ActiveResource::HttpMock.respond_to do |mock|
mock.get "/api/v2/forms/2#{api_url_suffix}", req_headers, form_response_data.to_json, 200
mock.get "/api/v2/forms/9999#{api_url_suffix}", req_headers, no_data_found_response, 404
end
end
describe "logging" do
let(:form_id) { 2 }
let(:trace_id) { "Root=1-63441c4a-abcdef012345678912345678" }
let(:request_id) { "a-request-id" }
before do
Rails.logger.broadcast_to logger
get form_id_path(mode: "form", form_id:), headers: {
"HTTP_X_AMZN_TRACE_ID": trace_id,
"X-REQUEST-ID": request_id,
}
end
after do
Rails.logger.stop_broadcasting_to logger
end
it "logs when the form is visited" do
expect(log_lines[0]["event"]).to eq("form_visit")
end
it "includes the form_name on log lines" do
expect(log_lines[0]["form_name"]).to eq(form_response_data.name)
end
it "includes the form_id on log lines" do
expect(log_lines[0]["form_id"]).to eq(form_id.to_s)
end
it "includes preview bool on log lines" do
expect(log_lines[0]["preview"]).to eq("false")
end
it "includes the trace ID on log lines" do
expect(log_lines[0]["trace_id"]).to eq(trace_id)
end
it "includes the request_host on log lines" do
expect(log_lines[0]["request_host"]).to eq("www.example.com")
end
it "includes the request_id on log lines" do
expect(log_lines[0]["request_id"]).to eq(request_id)
end
end
describe "#redirect_to_user_friendly_url" do
before do
get form_id_path(mode: "form", form_id: 2)
end
context "when the form exists and has no start page" do
let(:start_page) { nil }
it "Returns a 404" do
expect(response).to have_http_status(:not_found)
end
end
end
describe "#error_repeat_submission" do
before do
ActiveResource::HttpMock.respond_to do |mock|
allow(LogEventService).to receive(:log_form_start).at_least(:once)
mock.get "/api/v2/forms/2/live", req_headers, form_response_data.to_json, 200
end
get error_repeat_submission_path(mode: "form", form_id: 2, form_slug: form_response_data.form_slug)
end
it "renders the page with a link back to the form start page" do
expect(response.body).to include(form_page_path(mode: "form", form_id: 2, form_slug: form_response_data.form_slug, page_slug: 1))
end
end
describe "#show" do
context "with preview mode on" do
context "with a draft form" do
let(:api_url_suffix) { "/draft" }
context "when a form exists" do
before do
allow(LogEventService).to receive(:log_form_start)
travel_to timestamp_of_request do
get form_path(mode: "preview-draft", form_id: 2, form_slug: form_response_data.form_slug)
end
end
context "when the form has a start page" do
it "Redirects to the first page" do
expect(response).to redirect_to(form_page_path(mode: "preview-draft", form_id: 2, form_slug: form_response_data.form_slug, page_slug: 1))
end
it "does not log the form_visit event" do
expect(LogEventService).not_to have_received(:log_form_start)
end
end
context "when the form has no start page" do
let(:start_page) { nil }
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
end
it "Returns the correct X-Robots-Tag header" do
expect(response.headers["X-Robots-Tag"]).to eq("noindex, nofollow")
end
describe "Privacy page" do
it "returns http code 200" do
get form_privacy_path(mode: "preview-draft", form_id: 2, form_slug: "form-name")
expect(response).to have_http_status(:ok)
end
it "contains link to data controller's privacy policy" do
get form_privacy_path(mode: "preview-draft", form_id: 2, form_slug: "form-name")
expect(response.body).to include("http://www.example.gov.uk/privacy_policy")
end
end
end
context "when a form doesn't exists" do
before do
get form_path(mode: "preview-draft", form_id: 9999, form_slug: "form-name-1")
end
it "Render the not found page" do
expect(response.body).to include(I18n.t("errors.not_found.title"))
end
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
end
context "when the form has no start page" do
let(:start_page) { nil }
before do
get form_path(mode: "preview-draft", form_id: 9999, form_slug: "form-name")
end
it "Render the not found page" do
expect(response.body).to include(I18n.t("errors.not_found.title"))
end
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
end
end
context "with a live form" do
let(:api_url_suffix) { "/live" }
context "when a form exists" do
before do
allow(LogEventService).to receive(:log_form_start)
travel_to timestamp_of_request do
get form_path(mode: "preview-live", form_id: 2, form_slug: form_response_data.form_slug)
end
end
context "when the form has a start page" do
it "Redirects to the first page" do
expect(response).to redirect_to(form_page_path(mode: "preview-live", form_id: 2, form_slug: form_response_data.form_slug, page_slug: 1))
end
it "does not log the form_visit event" do
expect(LogEventService).not_to have_received(:log_form_start)
end
end
context "when the form has no start page" do
let(:start_page) { nil }
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
end
it "Returns the correct X-Robots-Tag header" do
expect(response.headers["X-Robots-Tag"]).to eq("noindex, nofollow")
end
describe "Privacy page" do
it "returns http code 200" do
get form_privacy_path(mode: "preview-live", form_id: 2, form_slug: form_response_data.form_slug)
expect(response).to have_http_status(:ok)
end
it "contains link to data controller's privacy policy" do
get form_privacy_path(mode: "preview-live", form_id: 2, form_slug: form_response_data.form_slug)
expect(response.body).to include("http://www.example.gov.uk/privacy_policy")
end
end
end
context "when a form doesn't exists" do
before do
get form_path(mode: "preview-live", form_id: 9999, form_slug: "form-name-1")
end
it "Render the not found page" do
expect(response.body).to include(I18n.t("errors.not_found.title"))
end
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
end
context "when the form has no start page" do
let(:start_page) { nil }
before do
get form_path(mode: "preview-live", form_id: 9999, form_slug: "form-name")
end
it "Render the not found page" do
expect(response.body).to include(I18n.t("errors.not_found.title"))
end
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
end
end
end
context "with preview mode off" do
context "when a form is live" do
context "when a form exists" do
before do
allow(LogEventService).to receive(:log_form_start)
travel_to timestamp_of_request do
get form_path(mode: "form", form_id: 2, form_slug: form_response_data.form_slug)
end
end
context "when the form has a start page" do
it "Redirects to the first page" do
expect(response).to redirect_to(form_page_path(mode: "form", form_id: 2, form_slug: form_response_data.form_slug, page_slug: 1))
end
it "Logs the form_visit event" do
expect(LogEventService).to have_received(:log_form_start)
end
end
context "when the form has no start page" do
let(:start_page) { nil }
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
end
it "Returns the correct X-Robots-Tag header" do
expect(response.headers["X-Robots-Tag"]).to eq("noindex, nofollow")
end
end
context "when a live form doesn't exist" do
before do
get form_path(mode: "form", form_id: 9999, form_slug: "form-name")
end
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
it "Render the not found page" do
expect(response.body).to include(I18n.t("errors.not_found.title"))
end
end
end
context "when the form is archived" do
before do
ActiveResource::HttpMock.respond_to do |mock|
mock.get "/api/v2/forms/2/live", req_headers, nil, 404
mock.get "/api/v2/forms/2/archived", req_headers, form_response_data.to_json, 200
end
get form_path(mode: "form", form_id: 2, form_slug: form_response_data.form_slug)
end
it "Renders the form archived page" do
expect(response.body).to include(I18n.t("form.archived.title"))
end
end
end
end
describe "locale" do
context "when getting a form page that exists" do
before do
get form_page_path(mode: "form", form_id: 2, form_slug: form_response_data.form_slug, page_slug: 1)
end
context "when the form is English" do
it "renders content in English" do
expect(response.body).to include(I18n.t("support_details.get_help_with_this_form"))
end
end
context "when the form is Welsh" do
let(:language) { "cy" }
it "renders content in Welsh" do
expect(response.body).to include(I18n.t("support_details.get_help_with_this_form", locale: :cy))
end
end
context "when the language attribute is not set for the form" do
let(:form_response_data) do
form_document = build(
:v2_form_document,
:with_support,
id: 2,
start_page:,
privacy_policy_url: "http://www.example.gov.uk/privacy_policy",
what_happens_next_markdown: "Good things come to those that wait",
declaration_text: "agree to the declaration",
steps: steps_data,
)
form_document.delete_field(:language)
form_document
end
it "renders content in English" do
expect(response.body).to include(I18n.t("support_details.get_help_with_this_form"))
end
end
end
context "when getting a form page that doesn't exist" do
before do
get form_page_path(mode: "form", form_id: 2, form_slug: form_response_data.form_slug, page_slug: 42)
end
context "when the form is English" do
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
it "renders the error page in English" do
expect(response.body).to include(I18n.t("errors.not_found.title"))
end
end
context "when the form is Welsh" do
let(:language) { "cy" }
it "returns 404" do
expect(response).to have_http_status(:not_found)
end
it "renders the error page in Welsh" do
expect(response.body).to include(I18n.t("errors.not_found.title", locale: :cy))
end
end
end
end
def log_lines
output.string.split("\n").map { |line| JSON.parse(line) }
end
end