Default runner to talk to forms-admin rather than forms-api

We have switched our deployed versions of forms-runner to make
requests to the forms-admin API endpoints through the internal load
balancer rather than to forms-api by setting this environment variable
for the ECS tasks.

Default the local configuration to make requests to forms-admin rather
than forms-api to match the deployed configuration.

Because we need to use the hostname for the internal load balancer in
the deployed environments, we need to keep a separate setting for this
URL to the `forms_admin.base_url` setting which is used to construct
links to the admin interface. We may want to consider renaming this
setting in future to make it not refer to forms-api.

Author: stephencdaly

Gemfile

@@ -38,7 +38,7 @@ gem "tzinfo-data"
 # Reduces boot times through caching; required in config/boot.rb
 gem "bootsnap", require: false
 
-# For forms-api
+# For requests to the forms-admin API
 gem "activeresource"
 
 # Use postgresql as the database for Active Record

README.md

@@ -47,7 +47,7 @@ or run the rails server:
 npm run dev
 ```
 
-You will also need to run the [forms-api service](https://github.com/alphagov/forms-api), as this app needs the API to create and access forms.
+You will also need to run the [forms-admin service](https://github.com/alphagov/forms-admin), as this app needs the API to create and access forms.
 
 #### Getting AWS credentials
 

config/settings.yml

@@ -8,8 +8,8 @@ forms_admin:
 forms_api:
   # Authentication key to authenticate forms-runner to forms-api
   auth_key: development_key
-  # URL to form-api endpoints
-  base_url: http://localhost:9292
+  # URL to form-admin API endpoints
+  base_url: http://localhost:3000
 
 # Settings for GOV.UK Notify api & email templates
 govuk_notify:

spec/config/settings_spec.rb

@@ -30,7 +30,7 @@
     forms_api = settings[:forms_api]
 
     include_examples expected_value_test, :auth_key, forms_api, "development_key"
-    include_examples expected_value_test, :base_url, forms_api, "http://localhost:9292"
+    include_examples expected_value_test, :base_url, forms_api, "http://localhost:3000"
   end
 
   describe ".govuk_notify" do