Skip to content

Review apps: add Terraform in support of forms-runner review apps#1387

Merged
AP-Hunt merged 2 commits intomainfrom
review-apps
May 14, 2025
Merged

Review apps: add Terraform in support of forms-runner review apps#1387
AP-Hunt merged 2 commits intomainfrom
review-apps

Conversation

@AP-Hunt
Copy link
Contributor

@AP-Hunt AP-Hunt commented May 12, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/4r1IFARH/675-add-review-apps-to-forms-runner

This Terraform is cloned from the equivalent code in forms-admin, and adjusted for the needs of forms-runner. The code duplication is a choice we made, because these two sets of Terraform code are only similar, and not the same bar some parameter differences. Trying to share code between the two would cause more problems than it solves.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@AP-Hunt AP-Hunt force-pushed the review-apps branch 3 times, most recently from 18e9e3e to 219351e Compare May 14, 2025 09:08
@AP-Hunt AP-Hunt marked this pull request as ready for review May 14, 2025 09:16
AP-Hunt added 2 commits May 14, 2025 10:30
This Terraform is cloned from the equivalent code in forms-admin, and adjusted
for the needs of forms-runner. The code duplication is a choice we made,
because these two sets of Terraform code are only similar, and not the same bar
some parameter differences. Trying to share code between the two would cause
more problems than it solves.
These workflows are also clones of what exists in forms-admin
@sonarqubecloud
Copy link

Copy link
Contributor

@sarahseewhy sarahseewhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid. There's nothing that I can see which needs changing. Code is clear and I appreciate all the comments and documentation. Thank you 🪄

@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@AP-Hunt AP-Hunt merged commit b52cd45 into main May 14, 2025
7 checks passed
@AP-Hunt AP-Hunt deleted the review-apps branch May 14, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants