Review apps: add Terraform in support of forms-runner review apps#1387
Review apps: add Terraform in support of forms-runner review apps#1387
Conversation
18e9e3e to
219351e
Compare
This Terraform is cloned from the equivalent code in forms-admin, and adjusted for the needs of forms-runner. The code duplication is a choice we made, because these two sets of Terraform code are only similar, and not the same bar some parameter differences. Trying to share code between the two would cause more problems than it solves.
These workflows are also clones of what exists in forms-admin
|
sarahseewhy
left a comment
There was a problem hiding this comment.
This looks solid. There's nothing that I can see which needs changing. Code is clear and I appreciate all the comments and documentation. Thank you 🪄
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |



What problem does this pull request solve?
Trello card: https://trello.com/c/4r1IFARH/675-add-review-apps-to-forms-runner
This Terraform is cloned from the equivalent code in forms-admin, and adjusted for the needs of forms-runner. The code duplication is a choice we made, because these two sets of Terraform code are only similar, and not the same bar some parameter differences. Trying to share code between the two would cause more problems than it solves.
Things to consider when reviewing