Skip to content

Add EMAIL environment variable to review app#1602

Merged
SamJamCul merged 1 commit intomainfrom
add-email-env-var-to-review-app
Aug 22, 2025
Merged

Add EMAIL environment variable to review app#1602
SamJamCul merged 1 commit intomainfrom
add-email-env-var-to-review-app

Conversation

@SamJamCul
Copy link
Contributor

@SamJamCul SamJamCul commented Aug 22, 2025

When seeding the database, the seed needs to draw an email from either the EMAIL environment variable, or from the user's git login - which isn't available in review apps. We need to set an EMAIL env var when setting up a review app so that it can populate the db accordingly.

What problem does this pull request solve?

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@SamJamCul @lfdebrux
Add EMAIL environment variable to review app
813aa02 
When seeding the database, the seed needs to draw an email from either
the EMAIL environment variable, or from the user's git login - which
isn't available in review apps. We need to set an EMAIL env var when
setting up a review app so that it can populate the db accordingly.

Co-authored-by: Laurence de Bruxelles <laurence.debruxelles@dsit.gov.uk>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@SamJamCul SamJamCul merged commit aa4b8be into main Aug 22, 2025
12 checks passed
@SamJamCul SamJamCul deleted the add-email-env-var-to-review-app branch August 22, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfdebrux lfdebrux lfdebrux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SamJamCul @lfdebrux