Skip to content

BAU: give review apps deployment some love#1746

Merged
cadmiumcat merged 2 commits intomainfrom
review-apps-love
Nov 27, 2025
Merged

BAU: give review apps deployment some love#1746
cadmiumcat merged 2 commits intomainfrom
review-apps-love

Conversation

@cadmiumcat
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/hKlz9OrU/774-automating-updates-of-terraform-in-the-app-repos

Update terraform + dependencies, and get dependabot to keep them up to date in future
(Same changes as govuk-forms/forms-product-page#938)

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@cadmiumcat cadmiumcat force-pushed the review-apps-love branch 2 times, most recently from 70e6c64 to 7d3960a Compare November 24, 2025 11:31
@github-actions
Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@cadmiumcat cadmiumcat enabled auto-merge November 26, 2025 11:08
@sonarqubecloud
Copy link
Copy Markdown

@cadmiumcat cadmiumcat merged commit e377714 into main Nov 27, 2025
7 of 8 checks passed
@cadmiumcat cadmiumcat deleted the review-apps-love branch November 27, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants