Skip to content

Add initial "Copy of answers" screen#1967

Merged
chao-xian merged 8 commits intomainfrom
copy-of-answers
Mar 18, 2026
Merged

Add initial "Copy of answers" screen#1967
chao-xian merged 8 commits intomainfrom
copy-of-answers

Conversation

@chao-xian
Copy link
Contributor

@chao-xian chao-xian commented Mar 13, 2026 •
edited
Loading

What problem does this pull request solve?

Add a new screen in the journey asking the user if they want to receive a copy of their answers.

This doesn't do anything yet once the user responds, but as it's behind a feature flag it won't affect anything. This PR is simply to split the work so that the next phase is sending the user to GOV.UK OneLogin.

You should be able to see the new screen at:

https://pr-1967.submit.review.forms.service.gov.uk/form/5/a-welsh-form/copy-of-answers (once previous answers are supplied)

Trello card: https://trello.com/c/T7Pbl1wf

localhost_3001_form_9_testing-ol_copy-of-answers cy

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@chao-xian chao-xian changed the title Copy of answers Add initial "Copy of answers" screen Mar 13, 2026
@chao-xian chao-xian force-pushed the copy-of-answers branch 4 times, most recently from 848aef3 to 8a5bbe6 Compare March 16, 2026 18:23
@chao-xian chao-xian marked this pull request as ready for review March 17, 2026 12:27
hannahkc
hannahkc previously requested changes Mar 17, 2026
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 17, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@chao-xian chao-xian requested a review from hannahkc March 17, 2026 17:33
hannahkc
hannahkc reviewed Mar 17, 2026
View reviewed changes
Copy link
Contributor

@hannahkc hannahkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks fine now. (we'll update the Welsh when we get the translations)

@hannahkc hannahkc dismissed their stale review March 17, 2026 17:41

content issues are fixed.

thomasiles
thomasiles approved these changes Mar 18, 2026
View reviewed changes
Copy link
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works well for me locally, nice one! 🏅

I noticed the page doesn't play back the users choice if they use the back button/link. I don't know what it should do but we might want to point it out to the design team at some point to get their view. Not for this PR though, just something in the future.

@chao-xian chao-xian added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 58a5a96 Mar 18, 2026
7 checks passed
@chao-xian chao-xian deleted the copy-of-answers branch March 18, 2026 12:03
@chao-xian chao-xian mentioned this pull request Mar 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannahkc hannahkc hannahkc left review comments

@thomasiles thomasiles thomasiles approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chao-xian @thomasiles @hannahkc