Merge pull request #6311 from alphagov/remove-rubysass-libsass

Author: querkmachine

.github/workflows/sass.yaml

@@ -98,155 +98,3 @@ jobs:
           name: Dart Sass v1 (latest) output
           path: .tmp/index.css
           if-no-files-found: ignore
-
-  # Node Sass v3.4.0 = LibSass v3.3.0
-  lib-sass:
-    name: LibSass v3.5.5 (deprecated)
-    runs-on: ubuntu-22.04
-
-    steps:
-      - name: Checkout code
-        uses: actions/[email protected]
-
-      - name: Setup Node.js
-        uses: actions/[email protected]
-        with:
-          cache: npm
-          # Node.js 15 is required for the stable support of ES Module
-          # used when installing `node-sass`
-          node-version: 15
-
-      - name: Install package
-        # Sass 5.0.0 is the first version that supports Python 3
-        # and as such can be built on a GitHub Actions runner
-        run: |
-          npm install -g [email protected]
-          node-sass --version
-
-      - name: Run command
-        run: |
-          mkdir -p .tmp
-          time node-sass packages/govuk-frontend/src/govuk/index.scss > .tmp/index.css
-
-      # Check output for uncompiled Sass
-      - name: Check output
-        run: |
-          ! grep "\$govuk-" .tmp/index.css
-
-      - name: Save compiled Sass
-        uses: actions/[email protected]
-        if: ${{ !cancelled() }}
-        with:
-          name: LibSass v3.5.5 (deprecated) output
-          path: .tmp/index.css
-          if-no-files-found: ignore
-
-  # Node Sass v8.x = LibSass v3 latest
-  lib-sass-latest:
-    name: LibSass v3 (latest, deprecated)
-    runs-on: ubuntu-22.04
-
-    steps:
-      - name: Checkout code
-        uses: actions/[email protected]
-
-      - name: Setup Node.js
-        uses: actions/[email protected]
-        with:
-          cache: npm
-          node-version-file: .nvmrc # Node.js project version must support Node Sass v8.x
-
-      - name: Install package
-        run: |
-          npm install -g node-sass@v8
-          node-sass --version
-
-      - name: Run command
-        run: |
-          mkdir -p .tmp
-          time node-sass packages/govuk-frontend/src/govuk/index.scss > .tmp/index.css
-
-      # Check output for uncompiled Sass
-      - name: Check output
-        run: |
-          ! grep "\$govuk-" .tmp/index.css
-
-      - name: Save compiled Sass
-        uses: actions/[email protected]
-        if: ${{ !cancelled() }}
-        with:
-          name: LibSass v3 (latest, deprecated) output
-          path: .tmp/index.css
-          if-no-files-found: ignore
-
-  ruby-sass:
-    name: Ruby Sass v3.4.0 (deprecated)
-    runs-on: ubuntu-22.04
-
-    steps:
-      - name: Checkout code
-        uses: actions/[email protected]
-
-      - name: Setup Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 2.3 # Oldest version supported by Bundler v2
-
-      - name: Install gem
-        run: |
-          gem install sass -v 3.4.0
-          sass --version
-
-      - name: Run command
-        run: |
-          mkdir -p .tmp
-          time sass packages/govuk-frontend/src/govuk/index.scss > .tmp/index.css
-
-      # Check output for uncompiled Sass
-      - name: Check output
-        run: |
-          ! grep "\$govuk-" .tmp/index.css
-
-      - name: Save compiled Sass
-        uses: actions/[email protected]
-        if: ${{ !cancelled() }}
-        with:
-          name: Ruby Sass v3.4.0 (deprecated) output
-          path: .tmp/index.css
-          if-no-files-found: ignore
-
-  ruby-sass-latest:
-    name: Ruby Sass v3 (latest, deprecated)
-    runs-on: ubuntu-22.04
-
-    steps:
-      - name: Checkout code
-        uses: actions/[email protected]
-
-      - name: Setup Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 3.2 # Ruby 3.2 supported by Ruby Sass v3
-
-      - name: Install gem
-        run: |
-          gem install sass -v '~> 3.0'
-          sass --version
-
-      - name: Run command
-        run: |
-          mkdir -p .tmp
-          time sass packages/govuk-frontend/src/govuk/index.scss > .tmp/index.css
-
-      # Check output for uncompiled Sass
-      - name: Check output
-        run: |
-          ! grep "\$govuk-" .tmp/index.css
-
-      - name: Save compiled Sass
-        uses: actions/[email protected]
-        if: ${{ !cancelled() }}
-        with:
-          name: Ruby Sass v3 (latest, deprecated) output
-          path: .tmp/index.css
-          if-no-files-found: ignore

CHANGELOG.md

@@ -10,6 +10,19 @@ To install this version with npm, run `npm install [email protected]`.
 
 ### Breaking changes
 
+#### We've ended support for Ruby Sass and LibSass
+
+GOV.UK Frontend no longer supports Ruby Sass and LibSass. You must update your project to [Dart Sass](https://sass-lang.com/dart-sass/) to continue using GOV.UK Frontend.
+
+Support for Ruby Sass ended in 2019, and LibSass was deprecated in 2020. A number of Sass implementations, including Node Sass, SassC and sass-rs, are dependent upon LibSass. GOV.UK Frontend also no longer supports these implementations.
+
+The Sass developers have provided guides for:
+
+- [migrating from Ruby Sass to Dart Sass](https://sass-lang.com/ruby-sass/)
+- [migrating from LibSass to Dart Sass](https://sass-lang.com/blog/libsass-is-deprecated/#how-do-i-migrate)
+
+This change was introduced in [pull request #6311: Remove support for Ruby Sass and LibSass](https://github.com/alphagov/govuk-frontend/pull/6311).
+
 #### Use GOV.UK brand colours
 
 We’ve updated GOV.UK Frontend to use the web palette defined by the [GOV.UK Brand guidelines](https://www.gov.uk/government/publications/govuk-brand-guidelines), as well as the 25% and 50% shades when they exist for a given colour.

packages/govuk-frontend/src/govuk/settings/_index.scss

@@ -19,16 +19,3 @@
 @import "typography-responsive";
 
 @import "links";
-
-// LibSass evaluates this as a single unquoted string, equivalent to
-// "true == false", whereas Dart Sass evaluates it as "true" == "false".
-// Because a string in Sass is truthy, LibSass will output the warning; Dart
-// Sass will not.
-@if #{true} == #{false} {
-  @include _warning(
-    "libsass",
-    "It looks like you may be using LibSass to compile your Sass. LibSass is " +
-      "deprecated and will not be supported by the next major version of " +
-      "GOV.UK Frontend. See https://sass-lang.com/libsass/ for more information."
-  );
-}